951260 - Social Status button icon stretched on retina screen

Status: VERIFIED FIXED

(Firefox Graveyard :: SocialAPI, defect)

Description

[Florian Quèze [:florian]]

Attachment: Screenshot

This seems to be a regression from bug 914921.

On the screenshot, you can also see that the gear icon added by bug 935640 needs a retina version.

Comment 1

[Florian Quèze [:florian]]

Attachment: Patch

The patch just removes 2 CSS rules that are causing the issue.

Shane, do you remember why you added these rules?

Comment 2

[Shane Caraveo (:mixedpuppy)]

(In reply to Florian Quèze [:florian] [:flo] from comment #1)
> Created attachment 8348868 [details] [diff] [review]
> Patch
> 
> The patch just removes 2 CSS rules that are causing the issue.
> 
> Shane, do you remember why you added these rules?

Hmm, I need to think about that, we should be using 32x icons if the provider supplied one in the manifest.  iirc, most live providers do.  I need to look at whether there is a good way to deal with css when the provider has supplied an appropriate icon. Until then, not sure about landing this patch.

We just need to get a 32x gear icon for the sidebar, that would be the right fix there.

Comment 3

[Shane Caraveo (:mixedpuppy)]

Comment on attachment 8348868 [details] [diff] [review]
Patch

sigh, ok, I didn't think this through completely, the patch is correct, but we may still need to think about how were handling the icons from the provider (in a separate bug).  And a separate bug for the gear icon is fine as well.

Comment 4

[Florian Quèze [:florian]]

https://hg.mozilla.org/integration/fx-team/rev/4053bdc8e0c0

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/4053bdc8e0c0

Comment 6

[u279076]

Florian, can you please verify this is fixed with today's Nightly?

Comment 7

[Florian Quèze [:florian]]

(In reply to Anthony Hughes, QA Mentor (:ashughes) from comment #6)
> Florian, can you please verify this is fixed with today's Nightly?

I'm sure I tried this in several nightlies where it was fixed (months ago).