951779 - Don't list up to date articles on the localization dashboard.

Status: RESOLVED FIXED

(support.mozilla.org :: Localization, task, P1)

Description

[Kadir Topal [:atopal]]

The most visited list on the localization dashboard should only show articles that need action. The list that links from the bottom of it should show all articles.

Comment 1

[Ricky Rosario [:rrosario, :r1cky]]

We are done for the year. Moving to next sprint.

The way our readouts work, this isn't possible. So we need to figure out how to modify/redo them in some way. Sounds scary because the readout code is => 3pts for now

Comment 2

[Ricky Rosario [:rrosario, :r1cky]]

unestimating and throwing back into current sprint after realizing how bad the current situation is. Let's try to fix quick today (I may have a fix hack already). If that doesn't work out, we'll roll back bug 943364.

Comment 3

[Ricky Rosario [:rrosario, :r1cky]]

(In reply to Ricky Rosario [:rrosario, :r1cky] from comment #1)
> The way our readouts work, this isn't possible. So we need to figure out how
> to modify/redo them in some way. Sounds scary because the readout code is =>
> 3pts for now

I overrode the render() method in this readout and was able to insert a hack so that it showed different rows depending on the value of the max_rows parameter which is only passed when on the main dashboard page. Then I was able to filter in python instead of SQL which made it much easier for me.

I put up a branch on stage now for Kadir to verify the behavior. Then I will submit a PR.

Comment 4

[Ricky Rosario [:rrosario, :r1cky]]

This was about 1pt.

Comment 5

[Ricky Rosario [:rrosario, :r1cky]]

Landed on master:
https://github.com/mozilla/kitsune/commit/a796a6f864be04014d6b9b5266d8daf251a948db

Comment 6

[Ricky Rosario [:rrosario, :r1cky]]

deployed to prod.

Comment 7

[Ricky Rosario [:rrosario, :r1cky]]

oops, i did this