Australis: Small windows lose the reload button

VERIFIED FIXED in Firefox 29

Status

()

defect
VERIFIED FIXED
6 years ago
5 years ago

People

(Reporter: bj, Assigned: dao)

Tracking

(Blocks 1 bug)

Trunk
Firefox 29
x86_64
Linux
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

When a window is made narrow almost everything gets moved to an overflow menu. The only exceptions I can find: The reload button and the down arrow next to it.

See the attached screen shot.
Blocks: 897160
Posted patch patchSplinter Review
With this change, stuff still gets cut off if there's a long identity label, but this seems like the edge case of an edge case not worth worrying about too much...
Assignee: nobody → dao
Status: NEW → ASSIGNED
Attachment #8349976 - Flags: review?(jaws)
Comment on attachment 8349976 [details] [diff] [review]
patch

Review of attachment 8349976 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/base/content/browser.css
@@ +283,5 @@
>    max-width: none;
>  }
>  
>  #urlbar-container {
> +  min-width: 30ch;

50ch is just as arbitrary as 30ch, but I chose 50ch to make sure that we had room for the identity block and the URL to be displayed. If we are considering switching this to 30ch, why not 25ch or something even smaller?
(In reply to Jared Wein [:jaws] (Away 20 Dec to 2 Jan) from comment #2)
> 50ch is just as arbitrary as 30ch, but I chose 50ch to make sure that we had
> room for the identity block and the URL to be displayed. If we are
> considering switching this to 30ch, why not 25ch or something even smaller?

Since the same could be asked about any lower value, are you suggesting that I remove the min-width? I could do that, I see no huge value in it.
Flags: needinfo?(jaws)
I'm not suggesting we remove the min-width. Maybe we should get some statistics about what the average length of the identity block for HTTPS+EV sites and base this min-width off of making sure that we can show the identity block in its full form as well as the domain name of the website in the location bar inputField.
Flags: needinfo?(jaws)
Comment on attachment 8349976 [details] [diff] [review]
patch

(In reply to Jared Wein [:jaws] (Away 20 Dec to 2 Jan) from comment #4)
> I'm not suggesting we remove the min-width. Maybe we should get some
> statistics about what the average length of the identity block for HTTPS+EV
> sites and base this min-width off of making sure that we can show the
> identity block in its full form as well as the domain name of the website in
> the location bar inputField.

This sounds like a good candidate for a followup. Don't want to over-engineer here.
Attachment #8349976 - Flags: review?(jaws)
Does the reload button only clip on Linux? I can't get it to clip on Win7 when at Google.com, which the initial screenshot appears to be showing. http://screencast.com/t/nQYZ5sv0
(In reply to Jared Wein [:jaws] (Away 20 Dec to 2 Jan) from comment #6)
> Does the reload button only clip on Linux? I can't get it to clip on Win7
> when at Google.com, which the initial screenshot appears to be showing.
> http://screencast.com/t/nQYZ5sv0

I just tried on Windows 7 and got the same behavior--no clipping for small windows on google.com. (And I also tried again on Ubuntu with today's build and still see the clipping.)
Comment on attachment 8349976 [details] [diff] [review]
patch

Review of attachment 8349976 [details] [diff] [review]:
-----------------------------------------------------------------

Can you provide a linux-only patch here?
Attachment #8349976 - Flags: review?(jaws) → review-
Comment on attachment 8349976 [details] [diff] [review]
patch

As mentioned in bug 897160 comment 57, I want to relax the excessive min-width across platforms. I used this bug as a vehicle, since this patch also fixes the Linux-specific issue this bug was filed for.
Attachment #8349976 - Flags: review- → review?(jaws)
backed this change out for mochitest-bc failures like https://tbpl.mozilla.org/php/getParsedLog.php?id=32911981&tree=Fx-Team
(In reply to Carsten Book [:Tomcat] from comment #11)
> backed this change out for mochitest-bc failures like
> https://tbpl.mozilla.org/php/getParsedLog.php?id=32911981&tree=Fx-Team

(just for the record, that was

https://hg.mozilla.org/integration/fx-team/rev/e23526533508

and Dão also landed

https://hg.mozilla.org/integration/fx-team/rev/b735ff10fdb3

to attempt to fix the test)
https://hg.mozilla.org/mozilla-central/rev/b735ff10fdb3
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 29
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Target Milestone: Firefox 29 → ---
https://hg.mozilla.org/mozilla-central/rev/77f74253bfbe
Status: REOPENED → RESOLVED
Closed: 6 years ago6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 29
Depends on: 962844
Depends on: 970020
Keywords: verifyme
Mozilla/5.0 (X11; Linux x86_64; rv:29.0) Gecko/20100101 Firefox/29.0		

Confirming this is now fixed on Ubuntu 12.04 64bit using Latest Aurora (build ID:20140304004003).
Status: RESOLVED → VERIFIED
Keywords: verifyme
Depends on: 980043
You need to log in before you can comment on or make changes to this bug.