962844 - [Australis] urlbar with EV SSL overlaps searchbar in narrow window

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect)

Description

[Christian Ascheberg]

Attachment: screenshot

See screenshot:
- background window: before regression
- foreground window at same width: urlbar overlaps searchbar

Last good nightly: 2014-01-14
First bad nightly: 2014-01-15

Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=34dddf6f7ec1&tochange=81bced59e8b3

Comment 1

[Dão Gottwald [:dao]]

Attachment: patch

Ideally the max-width of the identity labels would be relative to the actual urlbar width, but I couldn't get that to work. Not sure if it's possible with -moz-box layout.

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8364353 [details] [diff] [review]
patch

Review of attachment 8364353 [details] [diff] [review]:
-----------------------------------------------------------------

This regresses bug 951928. Can a media query be used to lessen the width of the identity-block when the window is narrow?

Comment 3

[Dão Gottwald [:dao]]

Comment on attachment 8364353 [details] [diff] [review]
patch

(In reply to Jared Wein [:jaws] from comment #2)
> Comment on attachment 8364353 [details] [diff] [review]
> patch
> 
> Review of attachment 8364353 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> This regresses bug 951928.

I think the combination of narrow window + long identity label is enough of an edge case to accept some shortcomings, although as I said ideally we'd make the identity labels' maximum width flexible.

> Can a media query be used to lessen the width of
> the identity-block when the window is narrow?

I'll give it a try.

Comment 4

[Dão Gottwald [:dao]]

Attachment: patch v2

The 7em width didn't seem to make a difference in my testing, so I removed it.

Comment 5

[Dão Gottwald [:dao]]

https://hg.mozilla.org/integration/fx-team/rev/30d6d1f88b00

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/30d6d1f88b00

Comment 7

[Christian Ascheberg]

Attachment: screenshot, patch v2 applied

It is still possible that the urlbar and searchbar overlap. Also the window needs to be really wide now to display all of the EV SSL text.

Before bug 951928 the searchbar was just moved to the "More tools..." dropdown much earlier. Wouldn't it be possible to get that behavior back?

Comment 8

[Dão Gottwald [:dao]]

(In reply to Christian Ascheberg from comment #7)
> Created attachment 8367338 [details]
> screenshot, patch v2 applied
> 
> It is still possible that the urlbar and searchbar overlap.

I didn't see that on Linux with my patch applied. I guess this might be due to font-size differences, in which case we should maybe make the location and search bar's minimum widths use pixel values. Or maybe it's due to other platform differences. Or maybe this is an issue on Linux and I somehow didn't see it. In any case, can you file a new bug on this specific case?

> Before bug 951928 the searchbar was just moved to the "More tools..."
> dropdown much earlier. Wouldn't it be possible to get that behavior back?

Yes, if we allowed the search bar to move without the location bar reaching its minimum width. But that's not how this code currently works, as I understand it.

Comment 9

[Christian Ascheberg]

(In reply to Dão Gottwald [:dao] from comment #8)
> (In reply to Christian Ascheberg from comment #7)
> > Created attachment 8367338 [details]
> > screenshot, patch v2 applied
> > 
> > It is still possible that the urlbar and searchbar overlap.
> 
> [...] In any case, can you file a new bug on this specific case?

Can't you just reopen this bug? I would just file a bug with the same description again. Or what do you mean by 'specific case'?

Comment 10

[Dão Gottwald [:dao]]

"Specific case" meaning that this would affect a smaller range of window sizes, since attachment 8367338 [details] has less overlap than attachment 8364018 [details]. Also, I couldn't reproduce the remaining issue on Linux since this patch landed, while I could reproduce the original bug without my patch on Linux.

Comment 11

[Dão Gottwald [:dao]]

(In reply to Dão Gottwald [:dao] from comment #10)
> "Specific case" meaning that this would affect a smaller range of window
> sizes, since attachment 8367338 [details] has less overlap than attachment
> 8364018 [details]. Also, I couldn't reproduce the remaining issue on Linux
> since this patch landed, while I could reproduce the original bug without my
> patch on Linux.

Bug 970020 has now been filed on this.

Comment 12

[Cornel Ionce [:noni] [Hubs QA]]

Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:29.0) Gecko/20100101 Firefox/29.0
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:29.0) Gecko/20100101 Firefox/29.0
Mozilla/5.0 (X11; Linux i686; rv:29.0) Gecko/20100101 Firefox/29.0

Verified fixed on Firefox 29 beta 6 (build ID: 20140407135746), issue is no longer reproducing.