Move pdf.js from /browser to a toplevel directory

NEW
Unassigned

Status

defect
P4
normal
5 years ago
7 months ago

People

(Reporter: mbrubeck, Unassigned)

Tracking

(Blocks 1 bug, {memory-footprint})

Trunk
x86_64
Windows 8.1
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

5 years ago
Currently pdf.js and Shumway are checked in to /browser/extensions for desktop Firefox.  Android and Metro Firefox do hacky things to build separate copies from that directory.  This is especially bad for installer size on Windows, where we ship two copies of each extension (one in browser and one in metro).

We should move these files to a location where we can more easily share them between apps, and install them just once on Windows.  Would /toolkit/extensions work?  Any other suggestions?
(Reporter)

Comment 1

5 years ago
We should make sure this can work for Firefox OS in the future, too.
(Reporter)

Updated

5 years ago
Blocks: 952846
Whiteboard: [triage]

Comment 2

5 years ago
(In reply to Matt Brubeck (:mbrubeck) from comment #0)
> We should move these files to a location where we can more easily share them
> between apps, and install them just once on Windows.  Would
> /toolkit/extensions work?  Any other suggestions?

/extensions/ already exists.
/toolkit/components/ too.
I'd dis-recommend the badly named /toolkit/mozapps/
And whose bright idea was it to have /toolkit/mozapps/extensions/ ?

Comment 3

5 years ago
This should be a new toplevel directory. Flat is better.
Also keep in mind that portions on the projects might differ between platforms, e.g. pdf.js for ffos, android and desktop will have different viewers however core part will stay the same.
Blocks: metrobacklog
No longer blocks: metrov1backlog
Whiteboard: [triage] → [defect] p=0

Updated

5 years ago
Summary: Move pdf.js and Shumway from /browser to a shared location like toolkit → Move pdf.js and Shumway from /browser to a toplevel directory
No longer blocks: 952846
(Reporter)

Updated

5 years ago
No longer blocks: 923596
(Reporter)

Updated

5 years ago
Priority: -- → P2
Whiteboard: [defect] p=0 → p=0
Brendan has to sign off on the creation of new toplevel directories.

Bikeshed: why can't we move things under /extensions?

Comment 6

5 years ago
Because flat is better (Brendan and I have discussed/agree!) and extensions has been a dumping ground for crap over the years.
No longer blocks: metrobacklog
Whiteboard: p=0

Updated

5 years ago
See Also: → 942707

Updated

3 years ago
Summary: Move pdf.js and Shumway from /browser to a toplevel directory → Move pdf.js from /browser to a toplevel directory

Updated

7 months ago
Component: Build Config → General
Product: Firefox → Firefox Build System

Updated

7 months ago
Priority: P2 → P4
You need to log in before you can comment on or make changes to this bug.