Closed Bug 952844 Opened 7 years ago Closed 20 days ago

Move pdf.js from /browser to a toplevel directory

Categories

(Firefox Build System :: General, defect, P4)

x86_64
Windows 8.1
defect

Tracking

(Not tracked)

RESOLVED WORKSFORME

People

(Reporter: mbrubeck, Unassigned)

References

(Blocks 1 open bug)

Details

(Keywords: memory-footprint)

Currently pdf.js and Shumway are checked in to /browser/extensions for desktop Firefox.  Android and Metro Firefox do hacky things to build separate copies from that directory.  This is especially bad for installer size on Windows, where we ship two copies of each extension (one in browser and one in metro).

We should move these files to a location where we can more easily share them between apps, and install them just once on Windows.  Would /toolkit/extensions work?  Any other suggestions?
We should make sure this can work for Firefox OS in the future, too.
Blocks: 952846
Whiteboard: [triage]
(In reply to Matt Brubeck (:mbrubeck) from comment #0)
> We should move these files to a location where we can more easily share them
> between apps, and install them just once on Windows.  Would
> /toolkit/extensions work?  Any other suggestions?

/extensions/ already exists.
/toolkit/components/ too.
I'd dis-recommend the badly named /toolkit/mozapps/
And whose bright idea was it to have /toolkit/mozapps/extensions/ ?
This should be a new toplevel directory. Flat is better.
Also keep in mind that portions on the projects might differ between platforms, e.g. pdf.js for ffos, android and desktop will have different viewers however core part will stay the same.
Blocks: metrobacklog
No longer blocks: metrov1backlog
Whiteboard: [triage] → [defect] p=0
Summary: Move pdf.js and Shumway from /browser to a shared location like toolkit → Move pdf.js and Shumway from /browser to a toplevel directory
No longer blocks: 952846
No longer blocks: 923596
Priority: -- → P2
Whiteboard: [defect] p=0 → p=0
Brendan has to sign off on the creation of new toplevel directories.

Bikeshed: why can't we move things under /extensions?
Because flat is better (Brendan and I have discussed/agree!) and extensions has been a dumping ground for crap over the years.
No longer blocks: metrobacklog
Whiteboard: p=0
See Also: → 942707
Summary: Move pdf.js and Shumway from /browser to a toplevel directory → Move pdf.js from /browser to a toplevel directory
Component: Build Config → General
Product: Firefox → Firefox Build System
Priority: P2 → P4

It moved to toolkit in 80 in bug 1618465.

Status: NEW → RESOLVED
Closed: 20 days ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.