Closed
Bug 955589
Opened 10 years ago
Closed 10 years ago
Conference invites don't work
Categories
(Chat Core :: Yahoo! Messenger, defect)
Chat Core
Yahoo! Messenger
Tracking
(Not tracked)
RESOLVED
FIXED
1.5
People
(Reporter: aleth, Assigned: qheaden)
References
Details
Attachments
(1 file)
1.19 KB,
patch
|
clokep
:
review+
|
Details | Diff | Splinter Review |
*** Original post on bio 2150 at 2013-09-03 13:35:00 UTC *** Both Mic and I tried to invite each other to conferences we had created. It was impossible to actually receive an invite. Nothing in the error console, and we tried using the full email address for /invite as well on the off-chance it would help.
Assignee | ||
Comment 1•10 years ago
|
||
*** Original post on bio 2150 at 2013-09-03 16:49:47 UTC *** I can verify that inviting other Yahoo users chatting via Instantbird does not work. Inviting those using libpurple clients, or the official Yahoo client can be invited. So this points to breakage in the JS-Yahoo code for accepting conference invites.
Assignee | ||
Comment 2•10 years ago
|
||
*** Original post on bio 2150 as attmnt 2840 at 2013-09-06 17:56:00 UTC *** Strangely, this patch is simply undoing what was done in the patch for bug 955531 (bio 2094). When I removed the fixes for bug 955531 (bio 2094), I still couldn't reproduce the error found there. Perhaps I changed something somewhere else that fixes the issue in 2094. Anyway, this patch fixes this problem. It turns out that the server sends the invite to other users using the server ack status code, so we shouldn't block those kinds of packets in the conference invite handler, or else the user won't be able to join the conference.
Attachment #8354610 -
Flags: review?(clokep)
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → qheaden
Status: NEW → ASSIGNED
Comment 3•10 years ago
|
||
Comment on attachment 8354610 [details] [diff] [review] Patch 1 *** Original change on bio 2150 attmnt 2840 at 2013-09-07 12:25:10 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8354610 -
Flags: review?(clokep) → review+
Reporter | ||
Updated•10 years ago
|
Whiteboard: [checkin-needed]
Comment 4•10 years ago
|
||
*** Original post on bio 2150 at 2013-09-09 23:36:06 UTC *** http://hg.instantbird.org/instantbird/rev/1b7a09391357
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [checkin-needed]
Target Milestone: --- → 1.5
You need to log in
before you can comment on or make changes to this bug.
Description
•