955697 - Move more stuff to moz.build

Status: RESOLVED INVALID

(Chat Core :: General, defect)

Description

[Patrick Cloke [:clokep]]

*** Original post on bio 2249 at 2013-11-11 22:19:00 UTC ***

*** Due to BzAPI limitations, the initial description is in comment 1 ***

Comment 1

[Patrick Cloke [:clokep]]

Attachment: Patch for XPCSHELL_TESTS

*** Original post on bio 2249 as attmnt 3043 at 2013-11-11 22:19:00 UTC ***

We have a bunch of more stuff to move to moz.build:
- Bio 869359 - Move XPCSHELL_TESTS to moz.build as XPCSHELL_TESTS_MANIFESTS in comm-central https://bugzilla.mozilla.org/show_bug.cgi?id=869359

Comment 2

[Patrick Cloke [:clokep]]

Attachment: XPIDL

*** Original post on bio 2249 as attmnt 3044 at 2013-11-11 22:22:00 UTC ***

Bio 850389 - Move XPIDL variables to moz.build files
https://bugzilla.mozilla.org/show_bug.cgi?id=850389

Comment 3

[Patrick Cloke [:clokep]]

Attachment: Patch for MODULE

*** Original post on bio 2249 as attmnt 3045 at 2013-11-11 22:24:00 UTC ***

Bio 869425 - Move MODULE to moz.build in comm-central
https://bugzilla.mozilla.org/show_bug.cgi?id=869425

Comment 4

[Florian Quèze [:florian]]

Comment on attachment 8354824 [details] [diff] [review]
Patch for XPCSHELL_TESTS

*** Original change on bio 2249 attmnt 3043 at 2013-11-11 23:52:51 UTC ***

It's strange that test/appInfoUtils.jsm is now declared both in the Makefile.in and the moz.build

Comment 5

[Florian Quèze [:florian]]

*** Original post on bio 2249 at 2013-11-12 00:06:10 UTC ***

Comment on attachment 8354825 [details] [diff] [review] (bio-attmnt 3044)
Patch for XPIDL

Are we trying to have changesets identical to what's on c-c, or to clean this up?

The MODULE variable in chat/components/public/Makefile.in really looks like it was used as a shorthand for XPIDL_MODULE. So I suspect we could get rid of this makefile completely.

Comment 6

[Florian Quèze [:florian]]

*** Original post on bio 2249 at 2013-11-12 00:13:16 UTC ***

Comment on attachment 8354826 [details] [diff] [review] (bio-attmnt 3045)
Patch for MODULE

Oh well, I guess this covers my previous comment ;).

Looks like we can also get rid of this file:
purple/purplexpcom/public/Makefile.in


There's a MODULE line in instantbird/components/mintrayr/Makefile.in that doesn't seem obviously useful.

I wonder if the MODULE line in instantbird/components/Makefile.in wanted to be an XPIDL_MODULE one in the moz.build file.

Comment 7

[Patrick Cloke [:clokep]]

Comment on attachment 8354826 [details] [diff] [review]
Patch for MODULE

*** Original change on bio 2249 attmnt 3045 at 2013-11-12 01:16:20 UTC ***

This doesn't build. I have a new version. :-)

Comment 8

[Patrick Cloke [:clokep]]

Attachment: Patch for XPCSHELL_TESTS v2

*** Original post on bio 2249 as attmnt 3046 at 2013-11-12 11:51:00 UTC ***

Turns out TESTING_JS_MODULES doesn't exist in moz.build, it still gets done in Makefiles.

Comment 9

[Patrick Cloke [:clokep]]

Comment on attachment 8354824 [details] [diff] [review]
Patch for XPCSHELL_TESTS

*** Original change on bio 2249 attmnt 3043 at 2013-11-12 11:51:01 UTC was without comment, so any subsequent comment numbers will be shifted ***

Comment 10

[Florian Quèze [:florian]]

Comment on attachment 8354827 [details] [diff] [review]
Patch for XPCSHELL_TESTS v2

*** Original change on bio 2249 attmnt 3046 at 2013-11-13 19:45:20 UTC was without comment, so any subsequent comment numbers will be shifted ***

Comment 11

[Florian Quèze [:florian]]

Comment on attachment 8354825 [details] [diff] [review]
XPIDL

*** Original change on bio 2249 attmnt 3044 at 2013-11-13 19:47:31 UTC ***

I'm assuming a newer version of this patch will arrive, following comment 6, comment 4 and comment 5. If this is wrong, please re-request review and answer my previous questions.

Comment 12

[Patrick Cloke [:clokep]]

*** Original post on bio 2249 at 2013-11-13 21:17:37 UTC ***

(In reply to comment #8)
> I'm assuming a newer version of this patch will arrive, following comment 6,
> comment 4 and comment 5. If this is wrong, please re-request review and answer
> my previous questions.


Sorry, I didn't think those needed answers, it sounded like you figured it out.

(In reply to comment #4)
> Are we trying to have changesets identical to what's on c-c, or to clean this
> up?
I don't understand this question very well. I'm porting each c-c changeset individually, but adding the instantbird/ and purple/ changes to it. Does that make sense?

> The MODULE variable in chat/components/public/Makefile.in really looks like it
> was used as a shorthand for XPIDL_MODULE. So I suspect we could get rid of this
> makefile completely.
I got rid of any Makefiles once they were empty. I don't understand the difference between MODULE and XPIDL_MODULE, I just ported them wherever they were previously defined in Makefiles.

(In reply to comment #5)
> Looks like we can also get rid of this file:
> purple/purplexpcom/public/Makefile.in
I did get rid of this in a newer version of the MODULE attachment, it isn't attached yet.

> There's a MODULE line in instantbird/components/mintrayr/Makefile.in that
> doesn't seem obviously useful.
I ported this in a newer version. When are these necessary vs. not necessary?

> I wonder if the MODULE line in instantbird/components/Makefile.in wanted to be
> an XPIDL_MODULE one in the moz.build file.
Again, what is the difference? I have no way of knowing when it is useful vs. not, can you help me out here?

(In reply to comment #6)
> This doesn't build. I have a new version. :-)
I'll upload my newer version.

Comment 13

[Patrick Cloke [:clokep]]

Attachment: Patch for XPIDL v2

*** Original post on bio 2249 as attmnt 3061 at 2013-11-21 12:50:00 UTC was without comment, so any subsequent comment numbers will be shifted ***

Comment 14

[Patrick Cloke [:clokep]]

Comment on attachment 8354825 [details] [diff] [review]
XPIDL

*** Original change on bio 2249 attmnt 3044 at 2013-11-21 12:50:46 UTC was without comment, so any subsequent comment numbers will be shifted ***

Comment 15

[Patrick Cloke [:clokep]]

Attachment: Patch for XPCSHELL_TESTS v3

*** Original post on bio 2249 as attmnt 3062 at 2013-11-21 12:51:00 UTC was without comment, so any subsequent comment numbers will be shifted ***

Comment 16

[Patrick Cloke [:clokep]]

Comment on attachment 8354827 [details] [diff] [review]
Patch for XPCSHELL_TESTS v2

*** Original change on bio 2249 attmnt 3046 at 2013-11-21 12:51:22 UTC was without comment, so any subsequent comment numbers will be shifted ***

Comment 17

[Patrick Cloke [:clokep]]

Comment on attachment 8354842 [details] [diff] [review]
Patch for XPIDL v2

*** Original change on bio 2249 attmnt 3061 at 2013-11-21 12:51:33 UTC was without comment, so any subsequent comment numbers will be shifted ***

Comment 18

[Patrick Cloke [:clokep]]

Attachment: Patch for MODULE v2

*** Original post on bio 2249 as attmnt 3063 at 2013-11-21 13:32:00 UTC ***

This should be applied:
XPCSHELL_TESTS
XPIDL
MODULE

Comment 19

[Patrick Cloke [:clokep]]

Comment on attachment 8354826 [details] [diff] [review]
Patch for MODULE

*** Original change on bio 2249 attmnt 3045 at 2013-11-21 13:32:04 UTC was without comment, so any subsequent comment numbers will be shifted ***

Comment 20

[Patrick Cloke [:clokep]]

*** Original post on bio 2249 at 2013-11-22 20:09:41 UTC ***

This also needs:
https://hg.mozilla.org/comm-central/rev/ea8f59513b2d
https://hg.mozilla.org/comm-central/rev/3281b0e5ed4d

Comment 21

[Patrick Cloke [:clokep]]

Attachment: Patch for XPIDL v3

*** Original post on bio 2249 as attmnt 3069 at 2013-11-22 20:13:00 UTC ***

This adds a rule to make XPIDL_MODULE not allowed in Makefiles.

Comment 22

[Patrick Cloke [:clokep]]

Comment on attachment 8354842 [details] [diff] [review]
Patch for XPIDL v2

*** Original change on bio 2249 attmnt 3061 at 2013-11-22 20:13:36 UTC was without comment, so any subsequent comment numbers will be shifted ***

Comment 23

[Patrick Cloke [:clokep]]

Attachment: Patch for MODULE v3

*** Original post on bio 2249 as attmnt 3070 at 2013-11-22 20:14:00 UTC ***

This MODULE patch actually works.

Comment 24

[Patrick Cloke [:clokep]]

Comment on attachment 8354844 [details] [diff] [review]
Patch for MODULE v2

*** Original change on bio 2249 attmnt 3063 at 2013-11-22 20:14:12 UTC was without comment, so any subsequent comment numbers will be shifted ***

Comment 25

[Patrick Cloke [:clokep]]

Bug 956609 made this unnecessary.