956101 - Thunderbird data is missing from telemetry.mozilla.org

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[Jonas Finnemann Jensen (:jonasfj)]

Thunderbird telemetry data seems to be missing on the telemetry-server side, see bug 956060. Once this is resolved we need to check if data for thunderbird appears on telemetry.mozilla.org, if not then this need to be fixed too.

Comment 1

[Jonas Finnemann Jensen (:jonasfj)]

I see data for Thunderbird here:
http://telemetry.mozilla.org/#nightly/29/CYCLE_COLLECTOR/saved_session/Thunderbird

I believe this showed up a while ago...

As in bug 956060 I see no data for release channels, if this is a bug, it should be addressed in telemetry-server. But from comment 2 on bug 956060 (https://bugzilla.mozilla.org/show_bug.cgi?id=956060#c2) it seems this might be a client issue.

I don't think this was ever an aggregation issue, so I'll resolve it invalid.
Basically, we don't have submissions from the release channel, only from nightly/29.

Comment 2

[Henri Sivonen (:hsivonen)]

I don't see Thunderbird data on http://telemetry.mozilla.org. Not for releases. Not for Earlybird.

What am I missing? Or has thing regressed?

Comment 3

[Mark Reid [:mreid]]

I see data coming in for Thunderbird 28, and a few submissions from version 29. Nothing for more recent versions of Thunderbird in the past several days (since September 1st).

Comment 4

[Henri Sivonen (:hsivonen)]

(In reply to Mark Reid [:mreid] from comment #3)
> I see data coming in for Thunderbird 28, and a few submissions from version
> 29. Nothing for more recent versions of Thunderbird in the past several days
> (since September 1st).

Any idea why this might be and how this could be fixed?

Reopening. If this is not a server problem, let's move this to a client component.

Comment 5

[Mark Reid [:mreid]]

Mark, in https://bugzilla.mozilla.org/show_bug.cgi?id=956060#c2 you mentioned that a flag had been switched off for Thunderbird, and that was causing clients not to submit Telemetry data.  Has something happened to turn that switch off again?

Is it possible that Thunderbird is still trying to submit to data.mozilla.com instead of incoming.telemetry.mozilla.org?

Comment 6

[Mark Banner (:standard8)]

In theory, as far as I can tell, telemetry is still on in prefs and being submitted to incoming.telemetry.mozilla.org.

Comment 7

[Mark Reid [:mreid]]

I did a bit of poking around on this.

I found that Telemetry pings were not being saved to $profile_dir/saved-telemetry-pings/ on shutdown.

I was able to force a test submission to a local server using the error console, pasting:
Components.utils.import("resource://gre/modules/TelemetryPing.jsm"); TelemetryPing.testPing("http://localhost:8080");

After the test submission, a saved ping did appear in the above directory upon shutdown.

I think Telemetry is not being properly initialized in Thunderbird.

Comment 8

[ISHIKAWA, Chiaki]

(In reply to Mark Reid [:mreid] from comment #7)

> 
> I think Telemetry is not being properly initialized in Thunderbird.


Is there a document about how to write/improve such iniialization Telemetry?

I tried to see if I could figure out by looking at MXR listing, etc., searches,
and read FAQs, etc. But the source code is not that helpful, and the
Document I searched are all related to the "USE" of already working 
feature in Firefox, and not implementation-specific.

If there is no documentation, then if only someone can point to where 
this "initialization" of telemetry
is taking pace in firefox by pointing out specific file and line, 
maybe someone can pitch in to help improve the TB situation 
(naybe, I am too optimistic.)

Comment 9

[Mark Reid [:mreid]]

I'm not sure of the details on the client - I was pretty much just looking to rule out a problem on the server.

Irving, can you provide any leads to help track this down?

Comment 10

[:Irving Reid (No longer working on Firefox)]

Not sure who the best person to inherit this is.

Comment 11

[Joshua Cranmer [:jcranmer]]

Huh. After doing some research, it appears that bug 913070 caused a drop-off in telemetry results, which was fixed by bug 962153... because the component that actually sends the pings on startup wasn't packaged.

Comment 12

[Joshua Cranmer [:jcranmer]]

Attachment: Add telemetry to the TB package manifest

Maybe this will do the trick?

Comment 13

[Joshua Cranmer [:jcranmer]]

(Note: if it does work, I plan to request uplift to aurora/beta/release/esr -- low risk and high value)

Comment 14

[Vladan Djeric (:vladan)]

Comment on attachment 8522496 [details] [diff] [review]
Add telemetry to the TB package manifest

Review of attachment 8522496 [details] [diff] [review]:
-----------------------------------------------------------------

r+ if it creates pings in the saved-session-telemetry folder

Comment 15

[Mark Banner (:standard8)]

Comment on attachment 8522496 [details] [diff] [review]
Add telemetry to the TB package manifest

Looks fine to me, though I've not tested it.

Comment 16

[Joshua Cranmer [:jcranmer]]

https://hg.mozilla.org/comm-central/rev/47be95d387af

Comment 17

[Joshua Cranmer [:jcranmer]]

Comment on attachment 8522496 [details] [diff] [review]
Add telemetry to the TB package manifest

[Approval Request Comment]
Regression caused by (bug #): bug 913070
User impact if declined: No telemetry reports until TB 36 rides the trains
Testing completed (on c-c, etc.): Hopefully, by the time this approval is granted, we'll see telemetry results from nightly users.
Risk to taking this patch (and alternatives if risky): Basically none.

Comment 18

[Mark Banner (:standard8)]

Comment on attachment 8522496 [details] [diff] [review]
Add telemetry to the TB package manifest

Simple enough that a=Standard8 everywhere.

Comment 19

[Mark Banner (:standard8)]

https://hg.mozilla.org/releases/comm-aurora/rev/884f2101fff3
https://hg.mozilla.org/releases/comm-beta/rev/097e1c11dc55
https://hg.mozilla.org/releases/comm-esr31/rev/e5636db97c3e