Closed
Bug 956487
Opened 10 years ago
Closed 10 years ago
IM: Pseudo is messed after landing of bug 920801
Categories
(Thunderbird :: Instant Messaging, defect)
Thunderbird
Instant Messaging
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 29.0
People
(Reporter: Paenglab, Assigned: Paenglab)
References
Details
(Keywords: regression)
Attachments
(2 files)
2.04 KB,
image/png
|
Details | |
1.57 KB,
patch
|
florian
:
review+
|
Details | Diff | Splinter Review |
With today's Daily the pseudo in chat is doubled and with a "> in between. Also the tooltip for long pseudos doesn't show the name. I suppose it comes from this changeset: http://hg.mozilla.org/comm-central/rev/a03020deadf5
Comment 1•10 years ago
|
||
The immediate fix is to remove the title attribute from https://mxr.mozilla.org/comm-central/source/mail/components/im/messages/Incoming/Content.html?force=1, as it now generates broken HTML. This will remove the nick tooltips in TB. To restore them, we should port the improved tooltips from IB in a separate bug.
Assignee | ||
Comment 2•10 years ago
|
||
I also removed the title in Context.html, okay? Which IB bug is for the improved tooltips? Maybe I can port this to TB.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8355862 -
Flags: review?(florian)
Comment 3•10 years ago
|
||
(In reply to Richard Marti (:Paenglab) from comment #2) > Which IB bug is for the improved tooltips? Maybe I can port this to TB. The bug for the resigned tooltips is bug 954653. The bug for showing tooltips when hovering nicks inside a conversation is bug 955121. Both are worth porting to Thunderbird, but I guess only the later is the one that matters here to replace the tooltips we are removing.
Comment 4•10 years ago
|
||
Comment on attachment 8355862 [details] [diff] [review] Pseudo fix Review of attachment 8355862 [details] [diff] [review]: ----------------------------------------------------------------- (In reply to Richard Marti (:Paenglab) from comment #2) > Created attachment 8355862 [details] [diff] [review] > Pseudo fix > > I also removed the title in Context.html, okay? Good catch! Thanks :).
Attachment #8355862 -
Flags: review?(florian) → review+
Assignee | ||
Updated•10 years ago
|
Keywords: checkin-needed
Comment 5•10 years ago
|
||
https://hg.mozilla.org/comm-central/rev/97e4cad8ce7b
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 29.0
Comment 6•10 years ago
|
||
Thanks!
You need to log in
before you can comment on or make changes to this bug.
Description
•