956487 - IM: Pseudo is messed after landing of bug 920801

Status: RESOLVED FIXED

(Thunderbird :: Instant Messaging, defect)

Description

[Richard Marti (:Paenglab)]

Attachment: Messed pseudo

With today's Daily the pseudo in chat is doubled and with a "> in between. Also the tooltip for long pseudos doesn't show the name.

I suppose it comes from this changeset: http://hg.mozilla.org/comm-central/rev/a03020deadf5

Comment 1

[aleth [:aleth]]

The immediate fix is to remove the title attribute from https://mxr.mozilla.org/comm-central/source/mail/components/im/messages/Incoming/Content.html?force=1, as it now generates broken HTML.

This will remove the nick tooltips in TB. To restore them, we should port the improved tooltips from IB in a separate bug.

Comment 2

[Richard Marti (:Paenglab)]

Attachment: Pseudo fix

I also removed the title in Context.html, okay?

Which IB bug is for the improved tooltips? Maybe I can port this to TB.

Comment 3

[Florian Quèze [:florian]]

(In reply to Richard Marti (:Paenglab) from comment #2)

> Which IB bug is for the improved tooltips? Maybe I can port this to TB.

The bug for the resigned tooltips is bug 954653. The bug for showing tooltips when hovering nicks inside a conversation is bug 955121. Both are worth porting to Thunderbird, but I guess only the later is the one that matters here to replace the tooltips we are removing.

Comment 4

[Florian Quèze [:florian]]

Comment on attachment 8355862 [details] [diff] [review]
Pseudo fix

Review of attachment 8355862 [details] [diff] [review]:
-----------------------------------------------------------------

(In reply to Richard Marti (:Paenglab) from comment #2)
> Created attachment 8355862 [details] [diff] [review]
> Pseudo fix
> 
> I also removed the title in Context.html, okay?

Good catch! Thanks :).

Comment 5

[Josiah Bruner [:jsbruner]]

https://hg.mozilla.org/comm-central/rev/97e4cad8ce7b

Comment 6

[aleth [:aleth]]

Thanks!