Port chat/ changes from Instantbird to comm-central - 6

RESOLVED FIXED in Thunderbird 29.0

Status

defect
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: clokep, Assigned: clokep)

Tracking

Trunk
Thunderbird 29.0
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(4 attachments, 2 obsolete attachments)

(Assignee)

Description

6 years ago
+++ This bug was initially created as a clone of Bug #842183 +++

Instantbird and comm-central's chat/ folders have diverged again. Time for another sync/
(Assignee)

Comment 1

6 years ago
Bio 1870 - Leading whitespace is lost from messages, r=fqueze.
Bio 898 - Copying text from conversations removes leading indent, r=fqueze.
Bio 1878 - Warn when receiving script and style tags in IM messages, r=clokep.
Bio 909 - Prepend # automatically to IRC channel names if no prefix was specified, r=clokep.
Bio 1038 - Add followed people to the participants timeline, r=aleth.
Bio 1886 - The topic of a Twitter timeline disappears if you close the conversation, r=aleth.
Bio 677 - Reopen Twitter stream when track preference changes, r=aleth,fqueze.
Bio 851 - Twitter commands, r=aleth,fqueze.
Bio 1902 - Change behaviour around unhandled CTCP messages, r=clokep.
Bio 1906 - Keep the 50 debug log messages just before a disconnection with an error, even after the account is reconnected, r=clokep.
Bio 1902 - Change behaviour around unhandled CTCP messages - follow-up to fix the target the ERRMSG is sent to, r=clokep.
Bio 1918 - Sort channel list in IRC tooltips, r=clokep.
Bio 1887 - Friends don't get added as participants when reopening a closed timeline, r=clokep.
Bio 1387 - The 'Copy Link to Tweet' action should be in the context menu even when the twitter account is disconnected, r=clokep
Bio 1732 - Port the log tree and concatenated daily logs from TB, r=fqueze.
Bio 1050 - Take account of URL shortening in twitter character count, r=aleth.
Bio 1652 - [a11y] Tooltips are missing in log viewer and message theme preview, r=fqueze.
Bio 1100 - Use toolkit untrusted cert dialog for "SSL Handshake failed" errors: chat/ part, r=fqueze.
Bio 1050 - Take account of URL shortening in twitter character count - follow-up to fix XMPP, r=fqueze.
Bio 1842 - Add pref to set length of debug logs, r=fqueze.
Bio 1934 - Make max message length for IRC smarter, r=clokep.
Bio 1829 - Update to Mozilla 20 - changes to imICommandsService, trayToolkit.cpp and purpleSockets, r=fqueze.
Bio 1927 - Add hidden option to allow using Facebook beta server, r=fqueze.
Bio 1939 - Warning: ReferenceError: reference to undefined property this._encoding, r=clokep.
Bio 1938 - Accounts are reconnected during shutdown, r=clokep.
Bio 1888 - New messages not displayed after detaching and reattaching a conversation tab, r=aleth.
Bio 1941 - Some characters lost when splitting messages, r=clokep.
Bio 1941 - Some characters lost when splitting messages - follow-up to fix broken xpcshell test, r=clokep.
Bio 1943 - irc.js should use lazy getters for localized strings, r=clokep.
Bio 1935 - Blackslash not handled correctly in CTCP messages, r=clokep.
Bio 1948 - Reference to undefined property this._account.maxMessageLength, r=clokep.
Bio 1950 - Completing "/me" shows the list of suggestions as action inside a system message, r=Mic.
Bio 1944 - XMPPSession shouldn't keep copies of the account's password, r=clokep.
Bio 1370 - Fix JS-IRC's usage of normalizedChatBuddy getter, r=aleth.
Bio 1370 - Fix JS-IRC's usage of normalizedChatBuddy getter - fix bad patch merge.
Bio 1370 - Avoid flashing the wrong case when double clicking on a participant with JS-IRC - Followup to fix bustage, r=clokep.
Bio 1967 - Ci is not defind in ircNonStandard, r=clokep.
Bio 1968 - CTCP quoting is broken, r=aleth,nhnt11.
Bio 1962 - Backslash is stripped from incoming action messages, r=aleth,clokep.
Bio 1757 - Nicks starting or ending by a non-alphanumeric character aren't detected correctly for pings, r=fqueze.
Bio 1980 - In IRC account properties, Auto-Joined Channels doesn't support non-ASCII symbols, r=fqueze.
Bio 1554 - IRC should notify the user when messages couldn't be sent, r=clokep.
Bio 1554 - IRC should notify the user when messages couldn't be sent: fix test bustage, r=bustage-fix.
Bio 2010 - Some JS errors when joining some IRC channels - better debug messages, r=clokep.
Bio 1973 - Concatenated logs don't work for buddies and contacts, r=fqueze.
Bio 1973 - Fix bustage (add missing commas in imILogger.idl).
Bio 1769 - Make names of protocols localizable, r=clokep.
Bio 1942 - fix sending of IRC pings, r=clokep.
Bio 2020 - Fix typo in socket.jsm documentation, r=clokep.
Bio 2021 - Add method to get all contacts from ContactsService, r=Mic,fqueze.
Bio 2023 - Services.cmd.unregisterCommand is broken, r=fqueze.
Bio 2022 - Support mIRC-style italics formatting, r=clokep.
Bio 1940 - Fix errors/warnings on detaching/reattaching conversations, r=fqueze.
Bio 2006 - The /invite command should support taking more than one nick as parameter, r=aleth.
Bio 2026 - Filter out empty contacts in Services.contacts.getContacts(), r=fqueze.
Bio 1979 - 'Typing' indicator is never cleared / Hangout users are shown typing when they aren't, r=clokep.
Bio 1589 - Replace libpurple XMPP with JS-XMPP - enabled JS-XMPP pref'ed off, r=clokep.
Bio 1981 - Make socket.jsm more binary friendly, r=Mic.
Bio 2059 - Failure to remove selection listener after switching logs in log viewer, r=fqueze.
Bio 2061 - Section scroll doesn't find all sessions, r=fqueze.
Bio 2062 - Magic Copy should heed the clipboard.autocopy pref, r=fqueze.
Bio 972 - Mark GTalk users on Android as "mobile", r=clokep.
Bio 1982 - Create Yahoo! Messenger Protocol Plug-In, r=clokep.
Bio 2080 - Buddy Authorization Handler Doesn't Work, r=clokep.
Bio 2086 - Could not decode UTF-8 message into UTF-16, r=aleth.
Bio 2083 - Account created with username@yahoo.* instead of username is handled badly, r=clokep.
Bio 2083 - Account created with username@yahoo.* instead of username is handled badly: tests, r=clokep.
Bio 2096 - Yahoo: Chat Message Handler Can Throw Error, r=clokep.
Bio 2079 - JS-Yahoo has no protocol icon, r=clokep.
Bio 2087 - Accepting an invitation to chat can end in a loop, r=clokep.
Bio 2088 - New contact does not get added to the correct tag, r=clokep.
Bio 2070 - Add support for setting Buddy Icons, r=clokep.
Bio 2070 - Add Support for getting Buddy Icons, r=clokep.
Bio 2108 - Test Fail Due to Bug 2070, r=clokep.
Bio 2105 - Tags Service Should Provide a Default Contact Group, r=clokep,fqueze.
Bio 2090 - /invite command is broken in private conversations, r=clokep.
Bio 2110 - Formatted Incoming Messages Always Shown With Large Letters, r=clokep.
Bio 2095 - MUC participants don't leave the MUC when they go offline, r=clokep.
Bio 2094 - Required key 52 wasn't found, r=clokep.
Bio 2120 - Spurious "You have rejoined the room" on being invited into a channel, r=clokep.
Bio 2121 - The /join command shouldn't send a JOIN command to the server if we are already in the channel, r=clokep.
Bio 2123 - 'Unhandled CAP/ISUPPORT messages' warnings are too noisy, r=clokep.
Bio 2009 - Accounts don't automatically reconnect when back online if the 'offline' status was set while the computer was offline, r=fqueze.
Bio 1994 - Account reconnects after using the /quit command, r=fqueze,clokep.
Bio 1994 - Account reconnects after using the /quit command - follow-up to fix a shutdown warning, r=clokep.
Bio 2117 - Yahoo: /invite should print a system message to show it's done something, r=clokep,fqueze.
Bio 2130 - Warning: received presence stanza for unknown buddy <user's JID with another resource>, r=clokep.
Bio 2112 - Yahoo: Abstract Buddy Request Code Into jsProtoHelper.js, r=clokep,fqueze.
Bio 451 - Participants Need Context Menu, r=fqueze.
Bio 2139 - Add ib-sender class to %senderScreenName% and %senderDisplayName%, r=fqueze.
Bio 2066 - New conversation tab should display chat rooms, r=fqueze,aleth
Bio 2066 - New conversation tab should suggest chat rooms - Implement parsing of LIST data in js-irc, r=clokep,aleth.
Bio 2141 - Don't include ib-sender span in magic copy, r=fqueze.
Bio 2132 - Sender name not set in Yahoo conversations, r=aleth,clokep.
Bio 2089 - JS-Yahoo: Debug logs are binary only, r=clokep,fqueze.
Bio 2093 - JS-Yahoo: "Adding chat buddy twice" error when inviting someone to a chatroom, r=clokep.
Bio 2111 - JS-Yahoo: Yahoo Web Client Causes Endless Typing Notification, r=clokep.
Bio 2150 - JS-Yahoo: Conference invites don't work, r=clokep.
Bio 2111 - Yahoo Web Client Causes Endless Typing Notification, rs=bustage-fix.
Bio 2157 - Call getChatRoomDefaultFieldValues lazily for awesometab roomInfos, r=clokep,fqueze.
Bio 2166 - JS-IRC spends more time than it needs in hasOwnProperty calls, r=clokep.
Bio 2164 - Socket.resetPingTimer shows up in LIST profiles, r=clokep.
Bio 2163 - Displaying a large conversation log freezes the UI for a while before the first messages get displayed, r=aleth.
Bio 2162 - IRC's /list command should use the requestRoomInfo API, r=aleth,clokep.
Bio 2153 - Make UTF-8 conversion warnings less noisy, r=clokep.
Bio 608 - Exception from buddies of an unknown account type, r=clokep.
Bio 2173 - Clicking the topic in the header of an IRC channel with no topic and focusing something else without typing anything clears the topic, r=clokep.
Bio 2102 - JS-Yahoo: Support Server Pings, r=clokep.
Bio 2147 - Bubbles' last message sometimes doesn't auto-scroll, r=fqueze.
Bio 1900 - aPhotoNode.getElement(...) is null when connecting to LiveJournal, r=fqueze.
(Assignee)

Updated

6 years ago
Blocks: 905094
(Assignee)

Comment 2

6 years ago
We need to check these changes for UI / preference changes, I've created an Etherpad to do this: https://etherpad.mozilla.org/ib-c-c-merge-6

If people could take a look at this I think we'll get good coverage.
Flags: needinfo?(florian)
Flags: needinfo?(benediktp)
Flags: needinfo?(aleth)

Comment 3

6 years ago
I've looked through the etherpad.
Flags: needinfo?(aleth)
(Assignee)

Updated

6 years ago
Blocks: 863226
(Assignee)

Comment 4

6 years ago
From the etherpad it's my understanding the following summary is true:

Things will break without changes for:
Bio 1906 - Keep the 50 debug log messages just before a disconnection with an error, even after the account is reconnected, r=clokep.
Bio 1050 - Take account of URL shortening in twitter character count, r=aleth. Will probably break stuff if merged
Bio 1842 - Add pref to set length of debug logs, r=fqueze. Default value for new pref will be missing.

Shinier things won't be taken advantage of with the changes in:
Bio 1652 - [a11y] Tooltips are missing in log viewer and message theme preview, r=fqueze.
Bio 1100 - Use toolkit untrusted cert dialog for "SSL Handshake failed" errors: chat/ part, r=fqueze.
Bio 1757 - Nicks starting or ending by a non-alphanumeric character aren't detected correctly for pings, r=fqueze.
Bio 1980 - In IRC account properties, Auto-Joined Channels doesn't support non-ASCII symbols, r=fqueze.
Bio 2010 - Some JS errors when joining some IRC channels - better debug messages, r=clokep.
Bio 2147 - Bubbles' last message sometimes doesn't auto-scroll, r=fqueze.
Bio 1827 - Add an easy way to copy an account specific debug log, r=clokep. (Note that this was actually merged in bug 842183, but the UI was never added.)

Additionally,
Bug 863226 is porting |Bio 1732 - Port the log tree and concatenated daily logs from TB, r=fqueze.|
(Assignee)

Updated

6 years ago
Blocks: 780749
(Assignee)

Comment 5

6 years ago
Posted patch Port required changes to UI (obsolete) — Splinter Review
This ports the changes that are "required" by the UI + the copy debug logs.
Attachment #813814 - Flags: review?(florian)
(Assignee)

Comment 6

6 years ago
(In reply to Patrick Cloke [:clokep] from comment #5)
> Created attachment 813814 [details] [diff] [review]
> Port required changes to UI
> 
> This ports the changes that are "required" by the UI + the copy debug logs.

This comment is pretty wrong, this ports Bio 1827, Bio 1100, Bio 1906 and Bio 1050. Bio 1852 is not needed.

The rest of the bugs I'll do in another patch.
(Assignee)

Comment 7

6 years ago
(In reply to Patrick Cloke [:clokep] from comment #4)
> Bio 1652 - [a11y] Tooltips are missing in log viewer and message theme
> preview, r=fqueze.
There seems to be no log viewer in TB, so I guess this isn't an issue?

> Bio 1757 - Nicks starting or ending by a non-alphanumeric character aren't
> detected correctly for pings, r=fqueze.
This isn't actually an issue, it's for a feature the TB UI doesn't support.

> Bio 1980 - In IRC account properties, Auto-Joined Channels doesn't support
> non-ASCII symbols, r=fqueze.
I actually found a bug in Instantbird when porting this! This has now been fixed!

> Bio 2010 - Some JS errors when joining some IRC channels - better debug
> messages, r=clokep.
This was straightforward.

> Bio 2147 - Bubbles' last message sometimes doesn't auto-scroll, r=fqueze.
I don't think this actually needs to be ported.

At this point all the UI stuff should be ported.
Attachment #813814 - Attachment is obsolete: true
Attachment #813814 - Flags: review?(florian)
Attachment #815330 - Flags: review?(florian)
(Assignee)

Comment 8

6 years ago
This is the rest of the changes. (I even found and fixed an Instantbird bug by porting these!)
Attachment #819524 - Flags: review?(florian)
Flags: needinfo?(florian)
Flags: needinfo?(benediktp)
(Assignee)

Comment 9

5 years ago
Mapping to BMO bug numbers:

(In reply to Patrick Cloke [:clokep] from comment #1)
> Created attachment 810205 [details] [diff] [review]
> 110 bugs ported from the IB repository
>
> Bug 955303 - Leading whitespace is lost from messages, r=fqueze.
> Bug 954331 - Copying text from conversations removes leading indent, r=fqueze.
> Bug 955311 - Warn when receiving script and style tags in IM messages,
> r=clokep.
> Bug 954342 - Prepend # automatically to IRC channel names if no prefix was
> specified, r=clokep.
> Bug 954473 - Add followed people to the participants timeline, r=aleth.
> Bug 955320 - The topic of a Twitter timeline disappears if you close the
> conversation, r=aleth.
> Bug 954112 - Reopen Twitter stream when track preference changes,
> r=aleth,fqueze.
> Bug 954284 - Twitter commands, r=aleth,fqueze.
> Bug 955338 - Change behaviour around unhandled CTCP messages, r=clokep.
> Bug 955342 - Keep the 50 debug log messages just before a disconnection with
> an error, even after the account is reconnected, r=clokep.
> Bug 955338 - Change behaviour around unhandled CTCP messages - follow-up to
> fix the target the ERRMSG is sent to, r=clokep.
> Bug 955355 - Sort channel list in IRC tooltips, r=clokep.
> Bug 955321 - Friends don't get added as participants when reopening a closed
> timeline, r=clokep.
> Bug 954822 - The 'Copy Link to Tweet' action should be in the context menu
> even when the twitter account is disconnected, r=clokep
> Bug 955162 - Port the log tree and concatenated daily logs from TB, r=fqueze.
> Bug 954484 - Take account of URL shortening in twitter character count,
> r=aleth.
> Bug 955081 - [a11y] Tooltips are missing in log viewer and message theme
> preview, r=fqueze.
> Bug 954534 - Use toolkit untrusted cert dialog for "SSL Handshake failed"
> errors: chat/ part, r=fqueze.
> Bug 954484 - Take account of URL shortening in twitter character count -
> follow-up to fix XMPP, r=fqueze.
> Bug 955275 - Add pref to set length of debug logs, r=fqueze.
> Bug 955372 - Make max message length for IRC smarter, r=clokep.
> Bug 955262 - Update to Mozilla 20 - changes to imICommandsService,
> trayToolkit.cpp and purpleSockets, r=fqueze.
> Bug 955364 - Add hidden option to allow using Facebook beta server, r=fqueze.
> Bug 955377 - Warning: ReferenceError: reference to undefined property
> this._encoding, r=clokep.
> Bug 955376 - Accounts are reconnected during shutdown, r=clokep.
> Bug 955323 - New messages not displayed after detaching and reattaching a
> conversation tab, r=aleth.
> Bug 955379 - Some characters lost when splitting messages, r=clokep.
> Bug 955379 - Some characters lost when splitting messages - follow-up to fix
> broken xpcshell test, r=clokep.
> Bug 955381 - irc.js should use lazy getters for localized strings, r=clokep.
> Bug 955373 - Blackslash not handled correctly in CTCP messages, r=clokep.
> Bug 955386 - Reference to undefined property this._account.maxMessageLength,
> r=clokep.
> Bug 955388 - Completing "/me" shows the list of suggestions as action inside a
> system message, r=Mic.
> Bug 955382 - XMPPSession shouldn't keep copies of the account's password,
> r=clokep.
> Bug 954804 - Fix JS-IRC's usage of normalizedChatBuddy getter, r=aleth.
> Bug 954804 - Fix JS-IRC's usage of normalizedChatBuddy getter - fix bad patch
> merge.
> Bug 954804 - Avoid flashing the wrong case when double clicking on a
> participant with JS-IRC - Followup to fix bustage, r=clokep.
> Bug 955404 - Ci is not defind in ircNonStandard, r=clokep.
> Bug 955405 - CTCP quoting is broken, r=aleth,nhnt11.
> Bug 955399 - Backslash is stripped from incoming action messages,
> r=aleth,clokep.
> Bug 955189 - Nicks starting or ending by a non-alphanumeric character aren't
> detected correctly for pings, r=fqueze.
> Bug 955417 - In IRC account properties, Auto-Joined Channels doesn't support
> non-ASCII symbols, r=fqueze.
> Bug 954986 - IRC should notify the user when messages couldn't be sent,
> r=clokep.
> Bug 954986 - IRC should notify the user when messages couldn't be sent: fix
> test bustage, r=bustage-fix.
> Bug 955446 - Some JS errors when joining some IRC channels - better debug
> messages, r=clokep.
> Bug 955410 - Concatenated logs don't work for buddies and contacts, r=fqueze.
> Bug 955410 - Fix bustage (add missing commas in imILogger.idl).
> Bug 955201 - Make names of protocols localizable, r=clokep.
> Bug 955380 - fix sending of IRC pings, r=clokep.
> Bug 955457 - Fix typo in socket.jsm documentation, r=clokep.
> Bug 955458 - Add method to get all contacts from ContactsService, r=Mic,fqueze.
> Bug 955460 - Services.cmd.unregisterCommand is broken, r=fqueze.
> Bug 955459 - Support mIRC-style italics formatting, r=clokep.
> Bug 955378 - Fix errors/warnings on detaching/reattaching conversations,
> r=fqueze.
> Bug 955442 - The /invite command should support taking more than one nick as
> parameter, r=aleth.
> Bug 955463 - Filter out empty contacts in Services.contacts.getContacts(),
> r=fqueze.
> Bug 955416 - 'Typing' indicator is never cleared / Hangout users are shown
> typing when they aren't, r=clokep.
> Bug 955019 - Replace libpurple XMPP with JS-XMPP - enabled JS-XMPP pref'ed
> off, r=clokep.
> Bug 955418 - Make socket.jsm more binary friendly, r=Mic.
> Bug 955496 - Failure to remove selection listener after switching logs in log
> viewer, r=fqueze.
> Bug 955498 - Section scroll doesn't find all sessions, r=fqueze.
> Bug 955499 - Magic Copy should heed the clipboard.autocopy pref, r=fqueze.
> Bug 954406 - Mark GTalk users on Android as "mobile", r=clokep.
> Bug 955419 - Create Yahoo! Messenger Protocol Plug-In, r=clokep.
> Bug 955517 - Buddy Authorization Handler Doesn't Work, r=clokep.
> Bug 955523 - Could not decode UTF-8 message into UTF-16, r=aleth.
> Bug 955520 - Account created with username@yahoo.* instead of username is
> handled badly, r=clokep.
> Bug 955520 - Account created with username@yahoo.* instead of username is
> handled badly: tests, r=clokep.
> Bug 955534 - Yahoo: Chat Message Handler Can Throw Error, r=clokep.
> Bug 955516 - JS-Yahoo has no protocol icon, r=clokep.
> Bug 955524 - Accepting an invitation to chat can end in a loop, r=clokep.
> Bug 955525 - New contact does not get added to the correct tag, r=clokep.
> Bug 955507 - Add support for setting Buddy Icons, r=clokep.
> Bug 955507 - Add Support for getting Buddy Icons, r=clokep.
> Bug 955546 - Test Fail Due to Bug 2070, r=clokep.
> Bug 955543 - Tags Service Should Provide a Default Contact Group,
> r=clokep,fqueze.
> Bug 955527 - /invite command is broken in private conversations, r=clokep.
> Bug 955548 - Formatted Incoming Messages Always Shown With Large Letters,
> r=clokep.
> Bug 955532 - MUC participants don't leave the MUC when they go offline,
> r=clokep.
> Bug 955531 - Required key 52 wasn't found, r=clokep.
> Bug 955558 - Spurious "You have rejoined the room" on being invited into a
> channel, r=clokep.
> Bug 955559 - The /join command shouldn't send a JOIN command to the server if
> we are already in the channel, r=clokep.
> Bug 955561 - 'Unhandled CAP/ISUPPORT messages' warnings are too noisy,
> r=clokep.
> Bug 955445 - Accounts don't automatically reconnect when back online if the
> 'offline' status was set while the computer was offline, r=fqueze.
> Bug 955430 - Account reconnects after using the /quit command, r=fqueze,clokep.
> Bug 955430 - Account reconnects after using the /quit command - follow-up to
> fix a shutdown warning, r=clokep.
> Bug 955555 - Yahoo: /invite should print a system message to show it's done
> something, r=clokep,fqueze.
> Bug 955568 - Warning: received presence stanza for unknown buddy <user's JID
> with another resource>, r=clokep.
> Bug 955550 - Yahoo: Abstract Buddy Request Code Into jsProtoHelper.js,
> r=clokep,fqueze.
> Bug 953891 - Participants Need Context Menu, r=fqueze.
> Bug 955578 - Add ib-sender class to %senderScreenName% and
> %senderDisplayName%, r=fqueze.
> Bug 955503 - New conversation tab should display chat rooms, r=fqueze,aleth
> Bug 955503 - New conversation tab should suggest chat rooms - Implement
> parsing of LIST data in js-irc, r=clokep,aleth.
> Bug 955580 - Don't include ib-sender span in magic copy, r=fqueze.
> Bug 955570 - Sender name not set in Yahoo conversations, r=aleth,clokep.
> Bug 955526 - JS-Yahoo: Debug logs are binary only, r=clokep,fqueze.
> Bug 955530 - JS-Yahoo: "Adding chat buddy twice" error when inviting someone
> to a chatroom, r=clokep.
> Bug 955549 - JS-Yahoo: Yahoo Web Client Causes Endless Typing Notification,
> r=clokep.
> Bug 955589 - JS-Yahoo: Conference invites don't work, r=clokep.
> Bug 955549 - Yahoo Web Client Causes Endless Typing Notification,
> rs=bustage-fix.
> Bug 955597 - Call getChatRoomDefaultFieldValues lazily for awesometab
> roomInfos, r=clokep,fqueze.
> Bug 955607 - JS-IRC spends more time than it needs in hasOwnProperty calls,
> r=clokep.
> Bug 955605 - Socket.resetPingTimer shows up in LIST profiles, r=clokep.
> Bug 955603 - Displaying a large conversation log freezes the UI for a while
> before the first messages get displayed, r=aleth.
> Bug 955602 - IRC's /list command should use the requestRoomInfo API,
> r=aleth,clokep.
> Bug 955592 - Make UTF-8 conversion warnings less noisy, r=clokep.
> Bug 954044 - Exception from buddies of an unknown account type, r=clokep.
> Bug 955615 - Clicking the topic in the header of an IRC channel with no topic
> and focusing something else without typing anything clears the topic,
> r=clokep.
> Bug 955540 - JS-Yahoo: Support Server Pings, r=clokep.
> Bug 955586 - Bubbles' last message sometimes doesn't auto-scroll, r=fqueze.
> Bug 955336 - aPhotoNode.getElement(...) is null when connecting to
> LiveJournal, r=fqueze.
(Assignee)

Comment 10

5 years ago
I had to update a moz.build file for Yahoo to get this to work again.
Attachment #810205 - Attachment is obsolete: true

Comment 11

5 years ago
Comment on attachment 815330 [details] [diff] [review]
Port UI changes v2

These are ports and I can't see anything obviously wrong in the context.
Attachment #815330 - Flags: review?(florian) → review+

Updated

5 years ago
Attachment #819524 - Flags: review?(florian) → review+
(Assignee)

Comment 12

5 years ago
116 changesets pushed:
https://hg.mozilla.org/comm-central/rev/3e81cf3efd98
https://hg.mozilla.org/comm-central/rev/e720381b4638
https://hg.mozilla.org/comm-central/rev/c696530a607a
https://hg.mozilla.org/comm-central/rev/c31337c60042
https://hg.mozilla.org/comm-central/rev/5387ac2aed9d
https://hg.mozilla.org/comm-central/rev/aa5fbdd584dc
https://hg.mozilla.org/comm-central/rev/174e953530d4
https://hg.mozilla.org/comm-central/rev/ce66b3977e6e
https://hg.mozilla.org/comm-central/rev/a2f06b8473a1
https://hg.mozilla.org/comm-central/rev/bc65956b1d13
https://hg.mozilla.org/comm-central/rev/ea3659ab611c
https://hg.mozilla.org/comm-central/rev/5ea24c395b34
https://hg.mozilla.org/comm-central/rev/72567e4d363a
https://hg.mozilla.org/comm-central/rev/133082203440
https://hg.mozilla.org/comm-central/rev/b0968f4a94fd
https://hg.mozilla.org/comm-central/rev/1bfad1b005f0
https://hg.mozilla.org/comm-central/rev/557b36fa2897
https://hg.mozilla.org/comm-central/rev/ebef4f1285c8
https://hg.mozilla.org/comm-central/rev/fb9d89b5ab52
https://hg.mozilla.org/comm-central/rev/3f97f11a9f93
https://hg.mozilla.org/comm-central/rev/c9f507debfdd
https://hg.mozilla.org/comm-central/rev/57e093d9a07a
https://hg.mozilla.org/comm-central/rev/60160e0235f6
https://hg.mozilla.org/comm-central/rev/fcfb779036f8
https://hg.mozilla.org/comm-central/rev/f2d3130ef087
https://hg.mozilla.org/comm-central/rev/03aafd631eb7
https://hg.mozilla.org/comm-central/rev/93c4d3966783
https://hg.mozilla.org/comm-central/rev/2b2189cb9952
https://hg.mozilla.org/comm-central/rev/2923892b1616
https://hg.mozilla.org/comm-central/rev/350e6ce586d4
https://hg.mozilla.org/comm-central/rev/06cdc5f8ea07
https://hg.mozilla.org/comm-central/rev/c55b40e46558
https://hg.mozilla.org/comm-central/rev/7ff40d7a00a1
https://hg.mozilla.org/comm-central/rev/939855b11ec6
https://hg.mozilla.org/comm-central/rev/b97a22cab358
https://hg.mozilla.org/comm-central/rev/47409da51f6a
https://hg.mozilla.org/comm-central/rev/f26eaf0b284f
https://hg.mozilla.org/comm-central/rev/8101d8833521
https://hg.mozilla.org/comm-central/rev/ef4b6648fe74
https://hg.mozilla.org/comm-central/rev/3396b2463b3f
https://hg.mozilla.org/comm-central/rev/b2e3053e472d
https://hg.mozilla.org/comm-central/rev/e2e4cb76fc31
https://hg.mozilla.org/comm-central/rev/09ee46fefd5f
https://hg.mozilla.org/comm-central/rev/782a4fb25d4a
https://hg.mozilla.org/comm-central/rev/014c02dbc7a0
https://hg.mozilla.org/comm-central/rev/e2d63b7923bd
https://hg.mozilla.org/comm-central/rev/a375d55b4148
https://hg.mozilla.org/comm-central/rev/8a4529b48a6e
https://hg.mozilla.org/comm-central/rev/6cccd568970c
https://hg.mozilla.org/comm-central/rev/78b30c1b29a4
https://hg.mozilla.org/comm-central/rev/2aa2ef15e7d6
https://hg.mozilla.org/comm-central/rev/db018b285737
https://hg.mozilla.org/comm-central/rev/04fa099d4be2
https://hg.mozilla.org/comm-central/rev/e4effea05461
https://hg.mozilla.org/comm-central/rev/8324c18b0f4b
https://hg.mozilla.org/comm-central/rev/6a9af75f4e29
https://hg.mozilla.org/comm-central/rev/a30b5531163e
https://hg.mozilla.org/comm-central/rev/4c9351bd5918
https://hg.mozilla.org/comm-central/rev/db45cbc73ef1
https://hg.mozilla.org/comm-central/rev/ed664ae37a85
https://hg.mozilla.org/comm-central/rev/bea37b48ad83
https://hg.mozilla.org/comm-central/rev/a500f206d3a6
https://hg.mozilla.org/comm-central/rev/747ff789d4b0
https://hg.mozilla.org/comm-central/rev/ef20b332dcb5
https://hg.mozilla.org/comm-central/rev/6d17bdadec9a
https://hg.mozilla.org/comm-central/rev/af852c95d503
https://hg.mozilla.org/comm-central/rev/7c17f3271bc1
https://hg.mozilla.org/comm-central/rev/4cec969a5e08
https://hg.mozilla.org/comm-central/rev/d2bb806f7e34
https://hg.mozilla.org/comm-central/rev/a387c35d05cd
https://hg.mozilla.org/comm-central/rev/2664294510bd
https://hg.mozilla.org/comm-central/rev/58ce0ebc197c
https://hg.mozilla.org/comm-central/rev/4118c32453d9
https://hg.mozilla.org/comm-central/rev/0b47d1b6e333
https://hg.mozilla.org/comm-central/rev/6954f01c576c
https://hg.mozilla.org/comm-central/rev/3dbce16f96f1
https://hg.mozilla.org/comm-central/rev/2ac98be60ecf
https://hg.mozilla.org/comm-central/rev/f3efffc251fd
https://hg.mozilla.org/comm-central/rev/70c3e2c1bc0e
https://hg.mozilla.org/comm-central/rev/ad7f12617fd6
https://hg.mozilla.org/comm-central/rev/ea76e1013f60
https://hg.mozilla.org/comm-central/rev/4abf922d5e23
https://hg.mozilla.org/comm-central/rev/cc73c057d07e
https://hg.mozilla.org/comm-central/rev/d375722ec3b7
https://hg.mozilla.org/comm-central/rev/e7c5ad420731
https://hg.mozilla.org/comm-central/rev/b0b495a3e1de
https://hg.mozilla.org/comm-central/rev/6454c8844985
https://hg.mozilla.org/comm-central/rev/b933b6e6702d
https://hg.mozilla.org/comm-central/rev/298db19d0ab7
https://hg.mozilla.org/comm-central/rev/a03020deadf5
https://hg.mozilla.org/comm-central/rev/256879537b8d
https://hg.mozilla.org/comm-central/rev/0ac184902c8a
https://hg.mozilla.org/comm-central/rev/3f26bb17ff2b
https://hg.mozilla.org/comm-central/rev/497e40cc9e01
https://hg.mozilla.org/comm-central/rev/6feec0fae9f1
https://hg.mozilla.org/comm-central/rev/032fae55ffaf
https://hg.mozilla.org/comm-central/rev/f34ff51816f2
https://hg.mozilla.org/comm-central/rev/2ed4a880cd09
https://hg.mozilla.org/comm-central/rev/a1e9e803c610
https://hg.mozilla.org/comm-central/rev/e0d71fb168b4
https://hg.mozilla.org/comm-central/rev/4b685a9e7383
https://hg.mozilla.org/comm-central/rev/1e5ced179bb7
https://hg.mozilla.org/comm-central/rev/aa9648134550
https://hg.mozilla.org/comm-central/rev/a0fde7f21942
https://hg.mozilla.org/comm-central/rev/7f24d4cea1c9
https://hg.mozilla.org/comm-central/rev/c47804c65bb4
https://hg.mozilla.org/comm-central/rev/9468904a2b53
https://hg.mozilla.org/comm-central/rev/b07d3f67e940
https://hg.mozilla.org/comm-central/rev/4ee1299a54bd
https://hg.mozilla.org/comm-central/rev/1d7c27dcd3c0
https://hg.mozilla.org/comm-central/rev/75e8768c941d
https://hg.mozilla.org/comm-central/rev/b52a6febc68d
https://hg.mozilla.org/comm-central/rev/17414d672f5d
https://hg.mozilla.org/comm-central/rev/d86cdb0344e2
https://hg.mozilla.org/comm-central/rev/01a788d85004
https://hg.mozilla.org/comm-central/rev/e91ae242d0e9
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 31.0
(Assignee)

Comment 13

5 years ago
The three yahoo tests are failing with:
TEST-UNEXPECTED-FAIL | /builds/slave/talos-slave/test/build/xpcshell/tests/chat/protocols/yahoo/test/test_yahooAccount.js | test failed (with xpcshell return code: 3), see following log:
>>>>>>>
System JS : WARNING /builds/slave/talos-slave/test/build/xpcshell/head.js:459 - reference to undefined property e.stack
System JS : ERROR /builds/slave/talos-slave/test/build/xpcshell/head.js:198 - TypeError: stack is undefined
[3672] WARNING: '!compMgr', file /builds/slave/tb-c-cen-osx64-d-0000000000000/build/mozilla/xpcom/glue/nsComponentManagerUtils.cpp, line 59
[3672] WARNING: OOPDeinit() without successful OOPInit(): file ../../../../mozilla/toolkit/crashreporter/nsExceptionHandler.cpp, line 2336
nsStringStats
 => mAllocCount:           2545
 => mReallocCount:           75
 => mFreeCount:            2545
 => mShareCount:           8211
 => mAdoptCount:            105
 => mAdoptFreeCount:        105
 => Process ID: 3672, Thread ID: 140735088389312
<<<<<<<
TEST-INFO | /builds/slave/talos-slave/test/build/xpcshell/tests/chat/protocols/yahoo/test/test_yahooLoginHelper.js | running test ...
TEST-UNEXPECTED-FAIL | /builds/slave/talos-slave/test/build/xpcshell/tests/chat/protocols/yahoo/test/test_yahooLoginHelper.js | test failed (with xpcshell return code: 3), see following log:
>>>>>>>
[3673] WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80520012: file ../../../../../mozilla/js/xpconnect/loader/mozJSComponentLoader.cpp, line 928
System JS : ERROR /builds/slave/talos-slave/test/build/xpcshell/head.js:198 - TypeError: stack is undefined
[3673] WARNING: '!compMgr', file /builds/slave/tb-c-cen-osx64-d-0000000000000/build/mozilla/xpcom/glue/nsComponentManagerUtils.cpp, line 59
[3673] WARNING: OOPDeinit() without successful OOPInit(): file ../../../../mozilla/toolkit/crashreporter/nsExceptionHandler.cpp, line 2336
nsStringStats
 => mAllocCount:           2723
 => mReallocCount:           90
 => mFreeCount:            2723
 => mShareCount:           8345
 => mAdoptCount:            138
 => mAdoptFreeCount:        138
 => Process ID: 3673, Thread ID: 140735088389312
<<<<<<<
TEST-INFO | /builds/slave/talos-slave/test/build/xpcshell/tests/chat/protocols/yahoo/test/test_yahoopacket.js | running test ...
TEST-UNEXPECTED-FAIL | /builds/slave/talos-slave/test/build/xpcshell/tests/chat/protocols/yahoo/test/test_yahoopacket.js | test failed (with xpcshell return code: 3), see following log:
>>>>>>>
[3674] WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80520012: file ../../../../../mozilla/js/xpconnect/loader/mozJSComponentLoader.cpp, line 928
System JS : ERROR /builds/slave/talos-slave/test/build/xpcshell/head.js:198 - TypeError: stack is undefined
[3674] WARNING: '!compMgr', file /builds/slave/tb-c-cen-osx64-d-0000000000000/build/mozilla/xpcom/glue/nsComponentManagerUtils.cpp, line 59
[3674] WARNING: OOPDeinit() without successful OOPInit(): file ../../../../mozilla/toolkit/crashreporter/nsExceptionHandler.cpp, line 2336
nsStringStats
 => mAllocCount:           2723
 => mReallocCount:           90
 => mFreeCount:            2723
 => mShareCount:           8345
 => mAdoptCount:            138
 => mAdoptFreeCount:        138
 => Process ID: 3674, Thread ID: 140735088389312
<<<<<<<
TEST-INFO | C:\slave\test\build\xpcshell\tests\chat\protocols\yahoo\test\test_yahoopacket.js | running test ...
TEST-UNEXPECTED-FAIL | C:\slave\test\build\xpcshell\tests\chat\protocols\yahoo\test\test_yahoopacket.js | test failed (with xpcshell return code: 3)
>>>>>>>
<<<<<<<

These pass fine on my local machine and there doesn't seem to be any real information about the error (what is "return code: 3"?) I'd rather disable these tests than back out everything I've just landed (they're tests for the JavaScript Yahoo protocol, which is still a bit experimental).
(Assignee)

Comment 14

5 years ago
This will disable the Yahoo tests as Yahoo isn't even packaged yet on Thunderbird.
Attachment #8355672 - Flags: review?(florian)
Attachment #8355672 - Flags: review?(florian) → review+
(Assignee)

Comment 15

5 years ago
(In reply to Patrick Cloke [:clokep] from comment #14)
> Created attachment 8355672 [details] [diff] [review]
> disable-yahoo-tests.diff
https://hg.mozilla.org/comm-central/rev/8198dbdebd96
Depends on: 956487
(Assignee)

Updated

5 years ago
Target Milestone: Thunderbird 31.0 → Thunderbird 29.0
(Assignee)

Updated

5 years ago
Blocks: 956767
(Assignee)

Updated

5 years ago
Blocks: 957918
(In reply to Patrick Cloke [:clokep] from comment #12)

> https://hg.mozilla.org/comm-central/rev/1bfad1b005f0

This was pushed with an invalid encoding, fixed in: https://hg.mozilla.org/comm-central/rev/13d313915cc4
(Assignee)

Updated

5 years ago
Blocks: 742726
(Assignee)

Updated

5 years ago
Depends on: 1011616
(Assignee)

Updated

5 years ago
Duplicate of this bug: 1026434
You need to log in before you can comment on or make changes to this bug.