Closed
Bug 956767
Opened 10 years ago
Closed 10 years ago
Can not set Auto-Join for channels in chat
Categories
(Thunderbird :: Instant Messaging, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 29.0
People
(Reporter: walts48, Assigned: clokep)
References
Details
Attachments
(1 file)
1.15 KB,
patch
|
florian
:
review+
|
Details | Diff | Splinter Review |
User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:27.0) Gecko/20100101 Firefox/27.0 (Beta/Release) Build ID: 20131216183647 Steps to reproduce: Setup chat account. Connected to chat account. Attempted to set Auto-join when joining channels. Tried to add channels to account settings with account not connected. Actual results: Dialog windows would not close when clicking OK. No channels added to Auto-joined Channels. Timestamp: 01/06/2014 12:06:19 PM Error: aAutoJoin is not defined Source File: resource://gre/components/imIncomingServer.js Line: 87 Expected results: Dialog windows should have closed with channels being added to Auto-joined Channels
Assignee | ||
Comment 1•10 years ago
|
||
This is an imperfect port of an Instantbird patch in bug 920801. [1] and [2] have different cases. I'll try to fix this tonight. [1] http://mxr.mozilla.org/comm-central/source/mail/components/im/imIncomingServer.js#83 [2] http://mxr.mozilla.org/comm-central/source/mail/components/im/imIncomingServer.js#87
Assignee | ||
Comment 2•10 years ago
|
||
Attachment #8356529 -
Flags: review?(florian)
Updated•10 years ago
|
Attachment #8356529 -
Flags: review?(florian) → review+
Assignee | ||
Updated•10 years ago
|
Keywords: checkin-needed
Comment 3•10 years ago
|
||
https://hg.mozilla.org/comm-central/rev/9571cb0f87a2
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 29.0
Comment 4•10 years ago
|
||
This bug still exists in TB 32.0a1 on Mac OS X 10.9.1.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment 5•10 years ago
|
||
Should a separate bug be filed, or should we expand the scope of this bug?
Comment 6•10 years ago
|
||
(In reply to Joshua Smith [:joshua-s] from comment #4) > This bug still exists in TB 32.0a1 on Mac OS X 10.9.1. Unless you have the JS error in comment 0 ("Error: aAutoJoin is not defined"), you are talking about a different issue and should file a new bug.
Status: REOPENED → RESOLVED
Closed: 10 years ago → 10 years ago
Resolution: --- → FIXED
Comment 7•10 years ago
|
||
(In reply to Florian Quèze [:florian] [:flo] from comment #6) > (In reply to Joshua Smith [:joshua-s] from comment #4) > > This bug still exists in TB 32.0a1 on Mac OS X 10.9.1. > > Unless you have the JS error in comment 0 ("Error: aAutoJoin is not > defined"), you are talking about a different issue and should file a new bug. I can't see a JS error in the Error Console. Otherwise, the Actual Results are the same.
Reporter | ||
Comment 8•10 years ago
|
||
(In reply to Joshua Smith [:joshua-s] from comment #7) > (In reply to Florian Quèze [:florian] [:flo] from comment #6) > > (In reply to Joshua Smith [:joshua-s] from comment #4) > > > This bug still exists in TB 32.0a1 on Mac OS X 10.9.1. > > > > Unless you have the JS error in comment 0 ("Error: aAutoJoin is not > > defined"), you are talking about a different issue and should file a new bug. > > I can't see a JS error in the Error Console. Otherwise, the Actual Results > are the same. Still occurs in TB 30.0b1 on Linux. I originally filed this bug because you can't close the Auto-Join dialog window with 'Auto-join this Chat Room' checked. I guess my Error Console error was misinterpreted. That bug is fixed.
You need to log in
before you can comment on or make changes to this bug.
Description
•