956767 - Can not set Auto-Join for channels in chat

Status: RESOLVED FIXED

(Thunderbird :: Instant Messaging, defect)

Description

[WaltS48 [:walts48]]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:27.0) Gecko/20100101 Firefox/27.0 (Beta/Release)
Build ID: 20131216183647

Steps to reproduce:

Setup chat account.
Connected to chat account.
Attempted to set Auto-join when joining channels.

Tried to add channels to account settings with account not connected.


Actual results:

Dialog windows would not close when clicking OK.
No channels added to Auto-joined Channels.

Timestamp: 01/06/2014 12:06:19 PM
Error: aAutoJoin is not defined
Source File: resource://gre/components/imIncomingServer.js
Line: 87


Expected results:

Dialog windows should have closed with channels being added to Auto-joined Channels

Comment 1

[Patrick Cloke [:clokep]]

This is an imperfect port of an Instantbird patch in bug 920801. [1] and [2] have different cases. I'll try to fix this tonight.

[1] http://mxr.mozilla.org/comm-central/source/mail/components/im/imIncomingServer.js#83
[2] http://mxr.mozilla.org/comm-central/source/mail/components/im/imIncomingServer.js#87

Comment 2

[Patrick Cloke [:clokep]]

Attachment: Fix capitalization

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/comm-central/rev/9571cb0f87a2

Comment 4

[Joshua Smith [:joshua-s]]

This bug still exists in TB 32.0a1 on Mac OS X 10.9.1.

Comment 5

[Joshua Smith [:joshua-s]]

Should a separate bug be filed, or should we expand the scope of this bug?

Comment 6

[Florian Quèze [:florian]]

(In reply to Joshua Smith [:joshua-s] from comment #4)
> This bug still exists in TB 32.0a1 on Mac OS X 10.9.1.

Unless you have the JS error in comment 0 ("Error: aAutoJoin is not defined"), you are talking about a different issue and should file a new bug.

Comment 7

[Joshua Smith [:joshua-s]]

(In reply to Florian Quèze [:florian] [:flo] from comment #6)
> (In reply to Joshua Smith [:joshua-s] from comment #4)
> > This bug still exists in TB 32.0a1 on Mac OS X 10.9.1.
> 
> Unless you have the JS error in comment 0 ("Error: aAutoJoin is not
> defined"), you are talking about a different issue and should file a new bug.

I can't see a JS error in the Error Console.  Otherwise, the Actual Results are the same.

Comment 8

[WaltS48 [:walts48]]

(In reply to Joshua Smith [:joshua-s] from comment #7)
> (In reply to Florian Quèze [:florian] [:flo] from comment #6)
> > (In reply to Joshua Smith [:joshua-s] from comment #4)
> > > This bug still exists in TB 32.0a1 on Mac OS X 10.9.1.
> > 
> > Unless you have the JS error in comment 0 ("Error: aAutoJoin is not
> > defined"), you are talking about a different issue and should file a new bug.
> 
> I can't see a JS error in the Error Console.  Otherwise, the Actual Results
> are the same.

Still occurs in TB 30.0b1 on Linux.

I originally filed this bug because you can't close the Auto-Join dialog window with 'Auto-join this Chat Room' checked.

I guess my Error Console error was misinterpreted. That bug is fixed.