9570 - [DOGFOOD]Editor cannot save on top of original file

Status: VERIFIED DUPLICATE of bug 17102

(Core :: DOM: Editor, defect, P1)

Description

[Chris McAfee]

Linux.
Edit foo.html, try to save over original file,
file does not get saved.

Comment 1

[Akkana Peck]

Simon said he was rewriting the save code ...

Comment 2

[Simon Fraser [no longer active]]

Sujay, can you test this on all 3 platforms? Thanks.

Comment 3

[sujay]

sorry late in getting back to this bug..

Win, Linux, all work for me using recent builds (8/27). But Mac
doesn't work..It still brings in the original file.

I simply created foo.html and then re-edited it changing the
content. Then I re-opened foo.html and saw the changes...

let me know if you needed me to test something different.

Comment 4

[buster]

seems like a simple Mac cleanup task.  M13.

Comment 5

[Chris McAfee]

Wait, on Mac you still lose (don't save) your data?
If so, this seems like a huge problem to me, who cares
if it's an easy cleanup task.

Comment 6

[Akkana Peck]

On Linux, after Opening a file in the editor and making some changes, clicking
Save or selecting it from the menu brings up a Save As dialog, instead of trying
to save to the original file name.  Then if I navigate through the file
selection dialog back to the original file name and double-click the filename, I
get a dialog that says "Saving file failed!" and indeed, it didn't write the
changes to the file.

There are two bugs here: (1) it should remember the original filename and not
make me re-select it again each time, and (2) it can't save over an existing
file.  Both issues are dogfood, so I'm adding a dependency to the editor dogfood
bug and setting platform to all (since it sounds like it has problems on both
Linux and Mac).

Comment 7

[leger]

Putting on [PDT]+ radar.

Comment 8

[Simon Fraser [no longer active]]

This is a file picker issue, not a composer issue. On Mac (and probably windows,
though I don't have a build to check on), the native UI puts up the dialog that
gets the user to confirm that they want to save over an existing file. That UI
needs to be implemenented on linux.

The actual file replacement does not happen until later, and that's covered in
bug 17102.

Comment 9

[Simon Fraser [no longer active]]

Ignore that last comment; it was meant for bug 17102

Comment 10

[Simon Fraser [no longer active]]

Akkana: your first issue above (it should remember which file you opened) is
covered by bug 7929. This bug is that it can't save over an existing file.

I just checked this, and it worked OK on Mac, so I wonder if the only remaining
problem here is the file picker 'replace' UI (bug 17102)? I'll check windows.

Comment 11

[Simon Fraser [no longer active]]

Yeah, this works on windows too, and the replace UI is there too. Moving OS to
linux, marking dep on the linux Replace UI Bug 17102. When that's done, this
might just work.

Comment 12

[Akkana Peck]

I'm confused as to why it doesn't just save, if the Save As dialog is saying to
save over the existing file and there is no confirmation dialog.  I understand
that the lack of the confirmation dialog is a bug, but that doesn't explain why
we get an error message when we actually try to save.

Comment 13

[Simon Fraser [no longer active]]

For the replace to work, nsIFileWidget::PutFile() must return
nsFileDlgResults_Replace. My guess is that it is not doing this on linux.

Comment 14

[rubydoo123]

this one has not been investigated but, simon knows the problem and has a fix in
mind. He may or may not require assistance from dougt

Comment 15

[Simon Fraser [no longer active]]

Actually the fix will be in linux file widget code; pavlov has the bug that this
depends on

Comment 16

[Simon Fraser [no longer active]]

Since this is entirely dependent on 17102, and no work remains here, closing
this. Note: to verify this, you will have to wait until 17102 is fixed.

Comment 17

[Chris McAfee]

This bug is not fixed, reopening.
Please leave this open so people don't file dups.
Mark it MLater or a dup, but not fixed.

Comment 18

[Simon Fraser [no longer active]]

*** This bug has been marked as a duplicate of 17102 ***

Comment 19

[sujay]

verified in 11/17 build.