957071 - [Flatfish]Dimension of "Volume Warning" on Flatfish not fit to the preview pane or the entire video apps

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Eric Chang [:ericcc] [:echang]]

Attachment: VolumeWarning.png

Gaia      56958810b8c51a513b6ef3263a362da7c9922d7f  │  
Gecko     55280696b85f2fb71aef1ec9f65546e2a264ea51  │  
BuildID   20140107064521             
Version   29.0a1                     
ro.build.version.incremental=20140107               │  
ro.build.date=Tue Jan  7 06:51:44 CST 2014

1. Plug in a headphone to Flatfish.
2. Open "Video" and start playing a video clip.
3. <ISSUE> a warning pops up that covers partially the preview pane, and the thumbnail one. See VolumeWarning.png

Comment 1

[Francis Lee [:frlee]]

+ Fred

Comment 2

[[e-mail]]

It's mostly CSS change, I'd glad to mentor this issue

Comment 3

[Michael V]

I would be interested in giving this a shot

Comment 4

[[e-mail]]

Nice! 

To solve this bug, You could check slides about developing FirefoxOS (gaia) to know the overall develop flow first
http://www.slideshare.net/gasolin/develop-firefox-os1-28348187


here are some checkpoints that can help you and me to spot the current step you are on

1. fork gaia from github, clone your gaia repository to local machine
2. run gaia with nightly browser
3. scale the responsive view to tablet layout
(change the responsive view size to '1312x831' in nighly browser, which fix the correct mapping to 1280x768)


Then you have everything settled to solve this bug.


please refer bug 935816 and bug 938518 to find how similar dialogs CSS style works
You can use `inspector` in browser developer tools to help investigate and manipulate styles.

my irc is: gasolin , feel free to ping me if you have any question.

Comment 5

[[e-mail]]

after you have done the first 3 steps, the last one is to reproduce the bug

go to apps/system/js/sound_manager.js replace the 

`window.addEventListener('volumeup', function()` {}

content with 

{
  showCEWarningDialog(null);
});


refresh the nightly browser, press volume up button in left side near top of responsive view (there's 2 black button). The dialog is shown there.


BTW, you may need to add a div wrapper in shared/js/custom_dialog to support transparent background

Comment 6

[Michael V]

Hi Fred,

I ran that command again and this is the output I got. At the end its saying [b2g|firefox] -profile /Users/michaelveis/Documents/gaia/gaia/profile-debug , do I run that? 

The whole output I get can be seen here: http://pastebin.mozilla.org/4092225

Comment 7

[[e-mail]]

It seems alright. Now you can run gaia via command

`/Application/FirefoxNightly.app/Contents/MacOS/firefox -profile /Users/michaelveis/Documents/gaia/gaia/profile-debug`

Comment 8

[Michael V]

thanks, It's running now

Comment 9

[Michael V]

One more question, should the volume warning fit the entire screen for 1312 X 831?

Comment 10

[[e-mail]]

The UI should looks like in https://bug929369.bugzilla.mozilla.org/attachment.cgi?id=8337483
in bug 929369

So the dialog it self should not change the size, but you need add an a div wrapper(overlay) to support the transparent background

Comment 11

[Ashutosh Verma]

Hi
i want to solve this bug.Please assign this to me

Comment 12

[[e-mail]]

Michael, are you still working on this issue?

Comment 13

[Michael V]

Hi Fred,

Yes I am still working on this issue.

Comment 14

[Syed Ali]

I'm a student from coventry university studying an opensource module, I would like to be assigned this as my first bug! Could you please point me in the right direction of how to start

Comment 15

[BMO Automation]

Firefox OS is not being worked on