95724 - Need to Properly integrate Mail in the Windows XP Start Menu

Status: VERIFIED FIXED

(SeaMonkey :: Installer, defect)

Description

[Todd Pringle]

In the Windows XP start menu, there is a default section at the top of the
lefthand pane (MSFT calls it the "pinned" area) that features your "default"
browser and mail application.

Currently, we properly register Navigator and Mail in such a way that we are a
configurable choice for this placement in the Start Menu, but a user has to go
in and specify us/customize their Start Menu in order for us to appear in this area.

For 0.9.4, we need to:

Place Navigator and Mail in this area upon install WHEN a user says "Yes" to the
desktop integration dialog asking them if they want Netscape to handle internet
file types.

I believe Sean has already investigated this and Montse knows where the MSFT
documentation on how to do this is.  It is critical that we get this for 0.9.4.

Comment 1

[Todd Pringle]

Adding nsBranch keyword.

Comment 2

[Jason Kersey]

Excellent.

Comment 3

[Todd Pringle]

What's the status on this one?  We need this for 0.9.4.  Setting that milestone
to get some attention.

Comment 4

[Sean Su]

The Mail part is dependent on MAPI support under mail.

Comment 5

[Todd Pringle]

Montse, is that true - I thought we were going to implement the Start Menu stuff
without having full SMAPI done.

Comment 6

[msanz]

I thought so too; it will require testing and document which MAPI support is
included. There is no reason why Browser work shouldn't be done in any case...

Comment 7

[Syd Logan]

I don't have a Windows XP machine, who can we get to do this work?

Comment 8

[Sean Su]

I have access to an XP system.

We currently do not support any MAPI functions.  However, bug 97702 should fix 
that.

Comment 9

[Todd Pringle]

As Montse said, this is something we need to do even if we don't have any MAPI
support.  We just need to be in the prominent Start Menu location of the default
mail program when users say yes to Netscape being their default handler.  Many
users will never hit instances where MAPI would be required to bring us up, but
all will use the Start Menu and look to click on and open their Mail application
of choice.

Comment 10

[Scott MacGregor]

this is already part of the mailnews PRD for eMojo. We had an issues meeting on
XP integration last week and this was one of the itemsI didn't realize this bug
was already floating around. I had Bhuvan signed up to do this work in another
bug. I'll coordinate between Sean and Bhuvan.

Comment 11

[Todd Pringle]

This is a must have, IMO for eMojo because of the Windows XP launch timeframe
(Oct, possibly earlier).  How is it coming?

Comment 12

[Scott MacGregor]

this work will happen during .9.5 but is still scheduled to land on the branch.

Comment 13

[Sean Su]

Updating summary to refer to only Mail.  A sperate bug has been filed to set the
browser up in Windows XP's Start menu: bug 97813

Setting up Mail to be the default mail handler under Windows XP (or any flavor
of Windows) is not as simple as setting the browser.  We need to talk with UE
people figure out the best way to do this. 

Comment 14

[Scott MacGregor]

For some reason your change caused us to lose the keywords. Resetting back the
nsBranch+. We don't need the enterprise+ because this is not an enterprise feature. 

Comment 15

[Asa Dotzler [:asa]]

This bug has nothing to do with security. Please remove the Netscape
Confidential flag or file a new version and mark this bug INVALID. Thanks.

Comment 16

[Sean Su]

reassigning to Srilatha because she's currently doing the work for this.

Comment 17

[Asa Dotzler [:asa]]

this bug needs to be marked invalid and refiled minus any confidential 
information that was incorrecly added to this bug. 

Comment 18

[sol]

Can someone tell me whether or not we must have any SMAPI support in order for
an end user to be able to launch Netscape Mail (as their default email client)
from the XP Start menu?

I understand that it might be somewhat clumsy for a user to see Netscape Mail in
the XP Start menu and then not be able to launch Netscape Mail (via SMAPI) from
Word or another Office app.

However, I think the must have feature is access to Netscape Mail from the XP
Start menu.

Comment 19

[Daniel Veditz [:dveditz]]

No response to Asa's two queries, and there are 74 other public bugs that
contain codenames so that's obviously not the reason.

http://bugzilla.mozilla.org/buglist.cgi?bug_status=NEW&bug_status=ASSIGNED&bug_status=REOPENED&email1=&emailtype1=substring&emailassigned_to1=1&email2=&emailtype2=substring&emailreporter2=1&bugidtype=include&bug_id=&changedin=&votes=&chfieldfrom=&chfieldto=Now&chfieldvalue=&short_desc=&short_desc_type=substring&long_desc=&long_desc_type=regexp&bug_file_loc=&bug_file_loc_type=substring&status_whiteboard=&status_whiteboard_type=substring&keywords=&keywords_type=anywords&field0-0-0=groupset&type0-0-0=lessthan&value0-0-0=1&field0-1-0=longdesc&type0-1-0=substring&value0-1-0=emojo&field0-1-1=longdesc&type0-1-1=substring&value0-1-1=machv&cmdtype=doit&newqueryname=&order=Reuse+same+sort+as+last+time

Comment 20

[esther]

Sol,  This bug confused me, I talked to Sean and I think I have an understanding
now of what this involves.  
1.)To fix this with a checkbox in the UI to make Netscape 6 Mail the "most often
used" Mail client displayed at the top of the "Easy Access" Start Menu would
would require a few changes to the Windows registry.
2.)To fix this with a checkbox in the UI to make Netscape 6 Mail both the "most
often used" mail client and the working default mail client would require
addtional changes to the Windows registry + SMAPI support.  
Doing only the 1st fix could cause confusion for the user since the Microsoft
gave the impression these two were tied together since Outlook was listed as the
default Mail app and the Most often used.  I don't think we should fix the 1st
one only.

Comment 21

[Jaime Rodriguez, Jr.]

Srilatha/Trudelle - What's the status on this one?

Comment 22

[Sean Su]

this problem will be fixed by bug 95122

Comment 23

[Jaime Rodriguez, Jr.]

Bug 95122 was checked in to branch yesterday. Can we verify that this has been 
resolved on the branch?

Comment 24

[Grace Bush]

I can verify that Mail has been integrated into the Windows XP Start Menu- when 
bug has been resolved fixed.  
Build 2001100505 on branch only
BUg 97813 - Navigator integration is complete as well

Note this verifies only that icon on StartMenu changes to Netscape 6 Mail when 
user answers yes to question.  The icon does not launch mail  as the Navigator 
icon launches Netscape 6 browser

Comment 25

[Grace Bush]

I can verify that Mail has been integrated into the Windows XP Start Menu- when 
bug has been resolved fixed.  
Build 2001100505 on branch only
BUg 97813 - Navigator integration is complete as well

Note this verifies only that icon on StartMenu changes to Netscape 6 Mail when 
user answers yes to question.  The icon does not launch mail  as the Navigator 
icon launches Netscape 6 browser

Comment 26

[Sean Su]

I think I see the problem as to why the Netscape 6 Mail shortcut in WinXP's 
Start menu does not launch Netscape 6 into mail.

In the file mailnews/mapi/registry/src/nsMapiRegistryUtils.cpp, the 
setDefaultMailClient() function is setting the following key:
  HKEY_LOCAL_MACHINE\Software\Clients\Mail\[brand name]\shell\open\command

Its (default) value is currently being set to:
  [path]\netscp6.exe "%1"

The way the installer was able to get it to work (in 6.1) was to set this 
(default) value to:
  [path]\netscp6.exe -mail

Since Mapi is being implemented, the installer is no longer setting this 
key/var.  The Mapi code is doing this now.  The patch that is causing this is 
http://bugzilla.mozilla.org/showattachment.cgi?attach_id=50918 in bug 95122.

I'm not sure what the right solution to this is because the Mapi code might 
require the "%1" instead of -mail.  Perhaps the fix would be to make sure it 
works with -mail "%1"?

Adding Srilatha to the cc: list.

Comment 27

[Srilatha Moturi]

Sean setDefaultMailClient is not actually setting this key.
HKEY_LOCAL_MACHINE\Software\Clients\Mail\[brand name]\shell\open\command
I will post a patch right away with this key.

Comment 28

[Srilatha Moturi]

Attachment: patch v1

Comment 29

[Sean Su]

Comment on attachment 52544 [details] [diff] [review]
patch v1

r=ssu

Comment 30

[Srilatha Moturi]

Attachment: patch v2. Added the DefaultIcon key

Comment 31

[Sean Su]

Comment on attachment 52585 [details] [diff] [review]
patch v2. Added the DefaultIcon key

r=ssu

Comment 32

[Daniel Veditz [:dveditz]]

Comment on attachment 52585 [details] [diff] [review]
patch v2. Added the DefaultIcon key

sr=dveditz for the branch. The branch->trunk landing as a whole needs careful review

Comment 33

[Jaime Rodriguez, Jr.]

is this soemthing we should bring before the PDT tomorrow?

Comment 34

[Sean Su]

yes.  we need this patch.  If we don't get this fix. people clicking on the 
Netscape 6 Mail (or whatever it'll be called) in the WinXP's start menu will not 
launch mail at all.

Comment 35

[Jaime Rodriguez, Jr.]

pls check this into the 094 branch - PDT+

Comment 36

[Srilatha Moturi]

Reassigning this to myself

Comment 37

[Srilatha Moturi]

Checked in the patch to 0.9.4 branch

Comment 38

[lchiang]

esther - can you verify this on the branch in WinXP latest build 2600?  Grace is
out of the office.
Henrik - if you want to go back to the QA contact on this one, pls reassign back
to yourself.

Comment 39

[esther]

I tested this with build 2001-10-15 on WinXP build 2626.  We don't update the
name of the preferred mail app in the Start menu.  

1. I made Outlook Express the preferred mail app via Start Menu properties.
2. I made Outlook Express the default mail app via IE Explorer Tools menu.
3. I installed the 10-15 branch build and checked the check box for Netscape 6
to be the default mail app.
4. I viewed the Start menu and it still listed Outlook Express.  So I exited
Netscape 6 and checked it again.  Still Outlook Express.  I clicked on Outlook
Express as the Mail app, but Netscape 6 launched.  I exited Netscape 6 and
viewed the Start Menu, still says Outlook Express.  I then tested if Netscape 6
was indeed the default mail app. it was.  I waited several minutes to see if it
took time for Outlook Express name to be replaced.  7 minutes no change.  I
logged off and did a switch users back to myself, still no change.  
To update the Start menu to display Netscape 6.2 I had to open the Start Menu
properties an then close it.  

Not completely fixed.

Comment 40

[esther]

I accidently resolved this as fixed, reopening.

Comment 41

[Sean Su]

Esther, the problem that you ran into dealing with the Start Menu not updating 
is bug 104943.

The uninstaller is also not doing the same thing.  That one is bug 104982.

I'm going to close this bug as fixed since there's already a bug opened on the 
last issue.

Comment 42

[Sean Su]

Oops.  Reopening this bug because only the branch is fixed.  Still waiting to 
land on the trunk.

Comment 43

[Srilatha Moturi]

changing milestone since the trunk landing for simpleMAPI will be done after 
0.9.6.
see bug #104672

Comment 44

[Srilatha Moturi]

Resolving this bug as fixed since mapi is landed on the trunk

Comment 45

[Grace Bush]

I am not seeing this as fixed on build 2002010903
The default Internet icon/program is changed to Netscape 6.2 but Mail is not
changed.

I started with Internet Explorer as default browser and Outlook Express as
default mail (after trying Netscape Messenger)
New installs do not ask me if I want to make N6.2 mail my default nor does it do
it automatically

H_Key_Local_machine/software/clients/mail/netscape 6/shell/open/command is set
to path
Netscpe6.exe -mail
but 
H_key_current_User/software/clients/mail - has only Netscape Messenger listed
Not sure which registry key to expect to be changed.

Srilatha,  I am expecting: 
1. to be asked if N6.2 mail should be default
2. icon in 'pinned area' to be N6.2 mail
3. a registry key set (not sure which)
Can you advise?

Comment 46

[Grace Bush]

Tried this again with build 2002011103 
N6 mail does not become default, nor am I asked as in Navigator

reopening
(on XP)

Comment 47

[Srilatha Moturi]

Sorry for the delay.
For Netscape 6 Mail to be the default mail client 
H_Key_Local_machine/software/clients/mail/netscape 6/shell/open/command should 
be set to path Netscpe6.exe -mail
For Netscape 6 Mail to show up in the start menu 
H_key_current_User/software/clients/mail should be set to netscape 6

One thing you can do for Netscape 6.2 to show up in the pinned area,
1) Go to preferences->Mail and Newsgroups
2) Uncheck the preference "Use Netscape mail as the default mail application", 
if it is checked
3) Click OK
4) Go to preferences->Mail and Newsgroups
5) Check the preference "Use Netscape mail as the default mail application"
4) Click Ok
Now you should see Netscape 6.2 Mail in the pinned area.

And also the prompt dialog "Do you want to set Netscape 6.2 as your default mail 
application" will appear only if netscape 6.2 is not your default mail client 
and only when you launch a mail window. From your registry settings, I see that 
netscape 6.2 is the default mail client on your machine.

Comment 48

[Grace Bush]

I tried your suggestions and N6 mail still does not show up in pinned area
The registry key hkey_current_user is not set either

I see the dialog about making mail default on other OS which is what had me
question that here.  Something about XP that makes it behave differently? 

I purposely set default mail to Outlook and did a clean install and was not
asked when I opened mail- I was asked by Navigator.

Comment 49

[Srilatha Moturi]

Grace, with the trunk builds I see that the registry keys are not being set. In 
the debug build everything works fine. Thanks to Sean for pointing this out.
I'm trying to figure out why it is not working in optimized build.

Comment 50

[Grace Bush]

thanks, nice to know I am not nuts :)

Comment 51

[Sean Su]

bug 90071 should fix this bug.

Comment 52

[Sean Su]

bug 90071 is fixed.  marking this one fixed too.

Comment 53

[Grace Bush]

not seeing a fix yet on XP, the pinned area now shows Outlook Express has been
removed,  but has no mail package.
The registry key  hkey_current_user is not set either

I can manually make this happen but that is not what this bug is about- right?

Comment 54

[scottputterman]

Sean, should you take this one?

Comment 55

[Grace Bush]

update with 1/30 build on XP, I am asked if I want to make Mail my default..., I 
said yes,  Netscape 6 6.2.1+ shows in pin area.  Not sure if the version 
numbering scheme is okay but the mail is finally getting to that area.

Comment 56

[Sean Su]

There are two ways to get our mail app in the 'pinned' area under WinXP:
1) install mozilla/n6, then go to Internet Options, Programs tab and select
mozilla mail/n6 mail for the E-mail: client.
2) install mozilla/n6, then run it's mail app.  it should ask if you want to
have it setup as the default mail client.  If yes, then it should set itself up
in the WinXP 'pinned' area.

The part I fixed was 1) (see bug 90071).  Srilatha fixed 2).  It looks like
Grace has been testing 2).

I'm closing this bug as fixed.  Please reopen this bug if 2) is not working.  If
1) is not working, please reopen bug 90071.

Comment 57

[Grace Bush]

verified on build 2002013003