Closed
Bug 957872
Opened 11 years ago
Closed 11 years ago
Remove SyncAdapters for all but the main Fennec ContentProvider
Categories
(Firefox for Android Graveyard :: Android Sync, defect)
Tracking
(firefox29 verified)
VERIFIED
FIXED
Firefox 29
| Tracking | Status | |
|---|---|---|
| firefox29 | --- | verified |
People
(Reporter: nalexander, Assigned: rnewman)
References
Details
(Whiteboard: [qa+])
Attachments
(2 files)
We were hoping to use Android's Settings check-boxes to allow user data elections, but that won't happen for first launch. So we need to go back to the single "Sync Firefox" checkbox, which means removing superfluous SyncAdapter definitions from the manifest and deleting the appropriate Java classes. (These were added by Bug 808813.)
This could also include backing out the changes from Bug 906884 (although they shouldn't hurt anything).
|
Assignee | |
Updated•11 years ago
|
OS: Mac OS X → Android
Hardware: x86 → All
Summary: Remove FxAccount SyncAdapter's for all but main Fennec ContentProvider → Remove SyncAdapters for all but the main Fennec ContentProvider
|
||
Updated•11 years ago
|
Whiteboard: [qa?]
|
|
Assignee | |
Comment 1•11 years ago
|
||
|
|
Assignee | |
Comment 2•11 years ago
|
||
Here's the hg application of this.
Attachment #8360155 -
Flags: review?(nalexander)
|
|
Assignee | |
Comment 3•11 years ago
|
||
QA: the result of this is that you'll only see one checkbox in the Firefox Account Android sync settings.
Whiteboard: [qa?] → [qa+]
|
Reporter | |
Comment 4•11 years ago
|
||
|
|
Assignee | |
Updated•11 years ago
|
Attachment #8360151 -
Flags: review?(nalexander) → review+
|
|
Assignee | |
Updated•11 years ago
|
Attachment #8360155 -
Flags: review?(nalexander) → review+
|
||
Comment 5•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 29
|
||
Comment 6•11 years ago
|
||
We should be able to verify this later. On Nightly (01/17), about:accounts is blank (even with identity.fxaccounts.enabled; true). Assume on waiting for more landings.
I can verify now that this added a custom Android Sync adapter.
Also this added a user-visible icon in the Android Application launcher for 'Firefox Account' (the native sync adapter). I assume we won't want that cruft populating user's application listings.
Flags: needinfo?(aaron.train)
Keywords: verifyme
|
|
||
Comment 7•11 years ago
|
||
Random Q: https://hg.mozilla.org/mozilla-central/rev/1ec000cfc0a5#l14.13 - Wes is using the flip in his patch for bug 957131. Is this correct here?
Flags: needinfo?(aaron.train)
|
|
Assignee | |
Comment 8•11 years ago
|
||
(In reply to Aaron Train [:aaronmt] from comment #7)
> Random Q: https://hg.mozilla.org/mozilla-central/rev/1ec000cfc0a5#l14.13 -
> Wes is using the flip in his patch for bug 957131. Is this correct here?
Yeah, the value of the constant is "default", so this is an accidentally zero-effect merge bug :D Well spotted!
|
|
||
Updated•11 years ago
|
|
||
Updated•7 years ago
|
Product: Android Background Services → Firefox for Android
|
|
||
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•