Closed Bug 957872 Opened 10 years ago Closed 10 years ago

Remove SyncAdapters for all but the main Fennec ContentProvider

Categories

(Firefox for Android Graveyard :: Android Sync, defect)

Product:
Firefox for Android Graveyard
Component:
Android Sync
Platform:
All
Android
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox29 verified)

Status:
VERIFIED FIXED
Milestone:
Firefox 29
Tracking Flags:
Tracking Status
firefox29 --- verified

People

(Reporter: nalexander, Assigned: rnewman)

References

Details

(Whiteboard: [qa+])

Attachments

(2 files)

Proposed patch. v1
57 bytes, text/x-github-pull-request
rnewman
: review+
Details | Review
hg patch. v1
11.72 KB, patch
rnewman
: review+
Details | Diff | Splinter Review 
We were hoping to use Android's Settings check-boxes to allow user data elections, but that won't happen for first launch.  So we need to go back to the single "Sync Firefox" checkbox, which means removing superfluous SyncAdapter definitions from the manifest and deleting the appropriate Java classes.  (These were added by Bug 808813.)

This could also include backing out the changes from Bug 906884 (although they shouldn't hurt anything).
OS: Mac OS X → Android
Hardware: x86 → All
Summary: Remove FxAccount SyncAdapter's for all but main Fennec ContentProvider → Remove SyncAdapters for all but the main Fennec ContentProvider
Whiteboard: [qa?]
Attached file Proposed patch. v1 — 
Assignee: nobody → rnewman
Status: NEW → ASSIGNED

        Attachment #8360151 -
        Flags: review?(nalexander)

    
    

    
  

      
      
      
      

        Attached patch
          
          
        hg patch. v1
        — 
          — Splinter Review
      

    


  
Here's the hg application of this.

        Attachment #8360155 -
        Flags: review?(nalexander)

    
    

    
  
QA: the result of this is that you'll only see one checkbox in the Firefox Account Android sync settings.
Whiteboard: [qa?] → [qa+]

    
  

        Attachment #8360151 -
        Flags: review?(nalexander) → review+

    
  

        Attachment #8360155 -
        Flags: review?(nalexander) → review+

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/1ec000cfc0a5
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 29

    
    

    
  
We should be able to verify this later. On Nightly (01/17), about:accounts is blank (even with identity.fxaccounts.enabled; true). Assume on waiting for more landings.

I can verify now that this added a custom Android Sync adapter.

Also this added a user-visible icon in the Android Application launcher for 'Firefox Account' (the native sync adapter). I assume we won't want that cruft populating user's application listings.
Flags: needinfo?(aaron.train)
Keywords: verifyme

    
    

    
  
Random Q: https://hg.mozilla.org/mozilla-central/rev/1ec000cfc0a5#l14.13 - Wes is using the flip in his patch for bug 957131. Is this correct here?
Flags: needinfo?(aaron.train)

    
    

    
  
(In reply to Aaron Train [:aaronmt] from comment #7)
> Random Q: https://hg.mozilla.org/mozilla-central/rev/1ec000cfc0a5#l14.13 -
> Wes is using the flip in his patch for bug 957131. Is this correct here?

Yeah, the value of the constant is "default", so this is an accidentally zero-effect merge bug :D  Well spotted!
Status: RESOLVED → VERIFIED

          status-firefox29:
          --- → verified
Keywords: verifyme

    
  
Product: Android Background Services → Firefox for Android

    
  
Product: Firefox for Android → Firefox for Android Graveyard

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: