958084 - Firefox Accounts Sync can successfully sync to guest browser profile and it won't sync to default profile

Status: RESOLVED DUPLICATE of bug 957131

(Firefox for Android Graveyard :: Android Sync, defect)

Description

[Aaron Train [:aaronmt]]

Currently a sync using Firefox Accounts (new Sync) will successfully sync to a guest browser profile.

Steps to Reproduce

i) Set up a new Firefox Account
ii) Start Firefox and switch to a Guest session
iii) Force a Sync through the Android accounts settings

Expected: Some form of profile detection and to not act on a guest profile.

Actual: Synced successfully to my temporary guest session. On return to my default profile, all my Synced data was dropped.

Comment 1

[Nick Alexander :nalexander [he/him]]

We'll do whatever existing Sync does.

Comment 2

[Aaron Train [:aaronmt]]

Noting here that the next Sync on the default (active) profile afterwards will yield and not successfully sync

I/FxAccounts(10539): fennec :: FxAccountSyncAdapter :: Syncing FxAccount account named mylovelyemail for authority org.mozilla.fennec.db.passwords with instance org.mozilla.gecko.fxa.sync.FxAccountSyncAdapter@41f56968.
D/SyncManager(  594): failed sync operation mylovelyemail u0 (org.mozilla.fennec_account), org.mozilla.fennec.db.tabs, USER, latestRunTime 5684652, reason: 1000, SyncResult: syncAlreadyInProgress: true stats []
W/InputMethodManagerService(  594): Window already focused, ignoring focus gain of: com.android.internal.view.IInputMethodClient$Stub$Proxy@432b51c8 attribute=null, token = android.os.BinderProxy@427237a0
D/SyncManager(  594): failed sync operation mylovelyemail u0 (org.mozilla.fennec_account), org.mozilla.fennec.db.formhistory, USER, latestRunTime 5684692, reason: 1000, SyncResult: syncAlreadyInProgress: true stats []
D/SyncManager(  594): failed sync operation mylovelyemail u0 (org.mozilla.fennec_account), org.mozilla.fennec.db.formhistory, USER, latestRunTime 5705105, reason: 1000, SyncResult: syncAlreadyInProgress: true stats []
D/SyncManager(  594): failed sync operation mylovelyemail u0 (org.mozilla.fennec_account), org.mozilla.fennec.db.browser, USER, latestRunTime 5705121, reason: 1000, SyncResult: syncAlreadyInProgress: true stats []
I/FxAccounts(10539): fennec :: FxAccountSyncAdapter :: Generated keypair. 
D/SyncManager(  594): failed sync operation mylovelyemail u0 (org.mozilla.fennec_account), org.mozilla.fennec.db.tabs, USER, latestRunTime 5705136, reason: 1000, SyncResult: syncAlreadyInProgress: true stats []
D/class ch.boye.httpclientandroidlib.impl.client.DefaultHttpClient(10539): Target requested authentication
W/FxAccounts(10539): fennec :: TokenServerClient :: {"location":"body","description":"Unauthorized","name":""}
E/FxAccounts(10539): fennec :: FxAccount :: Failed fetching server token.
E/FxAccounts(10539): org.mozilla.gecko.tokenserver.TokenServerException$TokenServerInvalidCredentialsException: {"status":"error","errors":[{"location":"body","description":"Unauthorized","name":""}]}
E/FxAccounts(10539):    at org.mozilla.gecko.tokenserver.TokenServerClient.processResponse(TokenServerClient.java:150)
E/FxAccounts(10539):    at org.mozilla.gecko.tokenserver.TokenServerClient$4.handleHttpResponse(TokenServerClient.java:212)
E/FxAccounts(10539):    at org.mozilla.gecko.sync.net.BaseResource.execute(BaseResource.java:264)
E/FxAccounts(10539):    at org.mozilla.gecko.sync.net.BaseResource.go(BaseResource.java:299)
E/FxAccounts(10539):    at org.mozilla.gecko.sync.net.BaseResource.get(BaseResource.java:305)
E/FxAccounts(10539):    at org.mozilla.gecko.fxa.sync.FxAccount$InnerFxAccountClientRequestDelegate.handleSuccess(FxAccount.java:62)
E/FxAccounts(10539):    at org.mozilla.gecko.background.fxa.FxAccountClient$10.handleSuccess$2637ceed(FxAccountClient.java:637)
E/FxAccounts(10539):    at org.mozilla.gecko.background.fxa.FxAccountClient$ResourceDelegate$2.run(FxAccountClient.java:208)
E/FxAccounts(10539):    at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1112)
E/FxAccounts(10539):    at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:587)
E/FxAccounts(10539):    at java.lang.Thread.run(Thread.java:841)
I/FxAccounts(10539): fennec :: FxAccountSyncAdapter :: Failed to get token.

Comment 3

[Nick Alexander :nalexander [he/him]]

(In reply to Aaron Train [:aaronmt] from comment #2)
> Noting here that the next Sync on the default (active) profile afterwards
> will yield and not successfully sync

Actually, I think this is happening for a different reason: you're getting a legit token server error, which I'm guessing is due to token server timestamp issues.  We're tracking the general problem and working on a strategy, and we'll want your help in the future to help us understand such issues in the wild.

You're correct that the multiple sync adapters cause some problems; the direction has changed and we're tearing them out: Bug 957872.

These early bug reports are really useful, thanks Aaaron!

Comment 4

[Wesley Johnston (:wesj)]

I'm going to guess that this is confused with bug 957131. Is there anything actionable to do here?

Comment 5

[Richard Newman [:rnewman]]

This should be fixed by Bug 957131 (the main report) and Bug 962668 and friends (the token error in Comment 2).

Full multiple profile support remains a future task.

Comment 6

[Nick Alexander :nalexander [he/him]]

Clearing needinfo.