Closed Bug 958533 Opened 6 years ago Closed 6 years ago

Add b2g desktop to the reftest sandbox

Categories

(Testing :: Reftest, defect)

x86_64
Linux
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla29

People

(Reporter: ahal, Assigned: ahal)

References

Details

Attachments

(1 file)

We need a way to disable reftests for the b2g desktop platform only.
Assignee: nobody → ahalberstadt
Status: NEW → ASSIGNED
Attachment #8358509 - Flags: review?(jgriffin)
Why isn't this covered by the existing B2G property?
Because b2g desktop's toolkit isn't gonk (it's gtk2 or cocoa depending on platform). I was thinking of doing something like:
B2G = appInfo.name == "b2g"
B2GRemote = B2G && toolkit == "gonk"
B2GDesktop = B2G && toolkit != "gonk"

But if people are used to disabling emulator tests with "B2G" they could accidentally and unknowingly disable b2g desktop tests as well.
Comment on attachment 8358509 [details] [diff] [review]
Patch 1.0 - add b2g desktop to reftest sandbox

Review of attachment 8358509 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me, unless dbaron has a different preference.
Attachment #8358509 - Flags: review?(jgriffin) → review+
https://hg.mozilla.org/mozilla-central/rev/1435517d890c
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
You need to log in before you can comment on or make changes to this bug.