If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Add b2g desktop to the reftest sandbox

RESOLVED FIXED in mozilla29

Status

Testing
Reftest
RESOLVED FIXED
4 years ago
3 years ago

People

(Reporter: ahal, Assigned: ahal)

Tracking

unspecified
mozilla29
x86_64
Linux
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
We need a way to disable reftests for the b2g desktop platform only.
(Assignee)

Comment 1

4 years ago
Created attachment 8358509 [details] [diff] [review]
Patch 1.0 - add b2g desktop to reftest sandbox
Assignee: nobody → ahalberstadt
Status: NEW → ASSIGNED
Attachment #8358509 - Flags: review?(jgriffin)
Why isn't this covered by the existing B2G property?
(Assignee)

Comment 3

4 years ago
Because b2g desktop's toolkit isn't gonk (it's gtk2 or cocoa depending on platform). I was thinking of doing something like:
B2G = appInfo.name == "b2g"
B2GRemote = B2G && toolkit == "gonk"
B2GDesktop = B2G && toolkit != "gonk"

But if people are used to disabling emulator tests with "B2G" they could accidentally and unknowingly disable b2g desktop tests as well.
Comment on attachment 8358509 [details] [diff] [review]
Patch 1.0 - add b2g desktop to reftest sandbox

Review of attachment 8358509 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me, unless dbaron has a different preference.
Attachment #8358509 - Flags: review?(jgriffin) → review+
(Assignee)

Comment 5

4 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/1435517d890c
https://hg.mozilla.org/mozilla-central/rev/1435517d890c
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
Blocks: 1094369
You need to log in before you can comment on or make changes to this bug.