Closed
Bug 958533
Opened 12 years ago
Closed 12 years ago
Add b2g desktop to the reftest sandbox
Categories
(Testing :: Reftest, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla29
People
(Reporter: ahal, Assigned: ahal)
References
Details
Attachments
(1 file)
|
1.85 KB,
patch
|
jgriffin
:
review+
|
Details | Diff | Splinter Review |
We need a way to disable reftests for the b2g desktop platform only.
|
Assignee | |
Comment 1•12 years ago
|
||
Assignee: nobody → ahalberstadt
Status: NEW → ASSIGNED
Attachment #8358509 -
Flags: review?(jgriffin)
Why isn't this covered by the existing B2G property?
|
|
Assignee | |
Comment 3•12 years ago
|
||
Because b2g desktop's toolkit isn't gonk (it's gtk2 or cocoa depending on platform). I was thinking of doing something like:
B2G = appInfo.name == "b2g"
B2GRemote = B2G && toolkit == "gonk"
B2GDesktop = B2G && toolkit != "gonk"
But if people are used to disabling emulator tests with "B2G" they could accidentally and unknowingly disable b2g desktop tests as well.
|
||
Comment 4•12 years ago
|
||
Comment on attachment 8358509 [details] [diff] [review]
Patch 1.0 - add b2g desktop to reftest sandbox
Review of attachment 8358509 [details] [diff] [review]:
-----------------------------------------------------------------
Looks good to me, unless dbaron has a different preference.
Attachment #8358509 -
Flags: review?(jgriffin) → review+
|
|
Assignee | |
Comment 5•12 years ago
|
||
|
|
||
Comment 6•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
You need to log in
before you can comment on or make changes to this bug.
Description
•