Closed
Bug 959419
Opened 10 years ago
Closed 10 years ago
Add "DOMIPCEnabled" (i.e. e10s) flag from crash reports to Socorro whitelist and Super Search
Categories
(Socorro :: General, task)
Socorro
General
Tracking
(Not tracked)
VERIFIED
FIXED
74
People
(Reporter: cpeterson, Assigned: adrian)
References
Details
(Whiteboard: [qa+])
There is currently no way to query Socorro crash stats for e10s-specific crash reports.
Comment 1•10 years ago
|
||
Does Super Search have its own white list or is it using the same as for the API?
Flags: needinfo?(adrian)
Comment 2•10 years ago
|
||
It's not really a "whitelist", each new field has to be added to the ES index in order to be searchable (AIUI).
Assignee | ||
Comment 3•10 years ago
|
||
The only "white list" Super Search has is here: https://github.com/mozilla/socorro/blob/master/socorro/external/elasticsearch/supersearch.py Super Search is not accessible through the public API yet, but it's one of our Q1 goals.
Assignee: nobody → adrian
Flags: needinfo?(adrian)
Comment 4•10 years ago
|
||
I'm confused. Where do we set up the field type for indexing? This is a boolean type, but supersearch.py doesn't seeem to mention any types at all.
Flags: needinfo?(adrian)
Assignee | ||
Comment 5•10 years ago
|
||
Sorry, I missed a few things. That list I linked to is the list of fields that can be returned by supersearch. There are two other "lists of fields": * the list of parameters that can be used in supersearch - https://github.com/mozilla/socorro/blob/master/socorro/lib/search_common.py#L74 * the list of all known fields in elasticsearch and their type - https://github.com/mozilla/socorro/blob/master/socorro/external/elasticsearch/mappings/socorro_index_settings.json
Flags: needinfo?(adrian)
Assignee | ||
Comment 6•10 years ago
|
||
Pull request: https://github.com/mozilla/socorro/pull/1862 Steps to QA ----------- 1. Go to super search 2. Verify that the field "dom ipc enabled" is accessible 3. Verify that querying that field returns some results (it might return no result for the "is false" value at the moment)
Whiteboard: [qa+]
Target Milestone: --- → 74
Comment 7•10 years ago
|
||
Commit pushed to master at https://github.com/mozilla/socorro https://github.com/mozilla/socorro/commit/0ed5d609b91b693c9d895871f588fe432c352827 Fixes bug 959419 - Added DOMIPCEnabled field to SuperSearch. r=peterbe
Updated•10 years ago
|
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Updated•10 years ago
|
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•