959503 - B2G RIL: Parcel handling threw ReferenceError: netHelpers is not defined

Status: RESOLVED FIXED

(Firefox OS Graveyard :: RIL, defect)

Description

[Vicamo Yang [:vicamo][:vyang]]

+++ This bug was initially created as a clone of Bug #958773 +++

I/Gecko   (   45): RIL Worker[0]: Parcel handling threw ReferenceError: netHelpers is not defined
I/Gecko   (   45): readDataCall_v6@resource://gre/modules/ril_worker.js:5836
I/Gecko   (   45): RIL[REQUEST_DATA_CALL_LIST]@resource://gre/modules/ril_worker.js:5866
I/Gecko   (   45): RIL[REQUEST_SETUP_DATA_CALL]@resource://gre/modules/ril_worker.js:5314
I/Gecko   (   45): RIL.handleParcel@resource://gre/modules/ril_worker.js:4949
I/Gecko   (   45): Buf.processParcel@resource://gre/modules/ril_worker.js:152
I/Gecko   (   45): require._tmpModules[":resource://gre/modules/workers/worker_buf.js"]/Buf.processIncoming@blob:78893422-8293-41e8-b462-fa4e991e9b71:536
I/Gecko   (   45): onRILMessage@resource://gre/modules/ril_worker.js:13910

Comment 1

[Vicamo Yang [:vicamo][:vyang]]

Working branch https://github.com/vicamo/b2g_mozilla-central/tree/bugzilla/959503/netHelper-undefined

Comment 2

[Vicamo Yang [:vicamo][:vyang]]

Attachment: patch

All of `options.ip`, `options.mask` and `options.broadcast` are only referenced in RadioInterfaceLayer or above and are never referenced in ril_worker.  Moving these assignments to prevent from loading "systemlibs.js" again, which was removed in bug 958773 to save memory.

Comment 3

[Vicamo Yang [:vicamo][:vyang]]

try https://tbpl.mozilla.org/?tree=Try&rev=804b2156142b

Comment 4

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Comment on attachment 8359648 [details] [diff] [review]
patch

Review of attachment 8359648 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

Comment 5

[Vicamo Yang [:vicamo][:vyang]]

https://hg.mozilla.org/integration/b2g-inbound/rev/51f5ff2e6667

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/51f5ff2e6667

Comment 8

[Joe Cheng [:jcheng] (please needinfo)]

Hi Vicamo, is this needed for 1.3? or even tarako? thanks

Comment 9

[Vicamo Yang [:vicamo][:vyang]]

(In reply to Joe Cheng [:jcheng] from comment #8)
> Hi Vicamo, is this needed for 1.3? or even tarako? thanks

Where ever the patch in bug 958773 is landed, the patch here MUST come after.  v1.3 => not needed, but v1.3t => needed.  I'll uplift this to v1.3t.

Comment 10

[Vicamo Yang [:vicamo][:vyang]]

Attachment: [v1.3t] patch

Comment 11

[Joe Cheng [:jcheng] (please needinfo)]

mark 1.3T?, remove [tarako] whiteboard

Comment 13

[Joe Cheng [:jcheng] (please needinfo)]

does not seem like [POVB], remove [POVB] whiteboard

Comment 14

[Joe Cheng [:jcheng] (please needinfo)]

triage: need this for tarako 1.3T+

Comment 15

[Vicamo Yang [:vicamo][:vyang]]

https://hg.mozilla.org/releases/mozilla-b2g28_v1_3t/rev/7e8dcd577c9a