Closed Bug 960250 Opened 12 years ago Closed 12 years ago

Show app titles in status bar

Categories

(Firefox OS Graveyard :: Gaia::System::Browser Chrome, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::System::Browser Chrome
Platform:
x86_64
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: benfrancis, Assigned: kgrandon)

References

Details

Attachments

(1 file, 2 obsolete files)

Github pull request to master
46 bytes, text/x-github-pull-request
vingtetun
: review+
Details | Review
Currently we only show page titles for browser windows. The UX spec also calls for app titles to be displayed when an app is open.
Assignee: nobody → kgrandon
Status: NEW → ASSIGNED
Attached file Pull request to master (obsolete) —
Comment on attachment 8362063 [details] [review] Pull request to master Ended up changing more, needs a review.
Attachment #8362063 - Attachment is obsolete: true
Blocks: 959353
No longer blocks: 941176
Patch has landed in rocketbar branch: https://github.com/mozilla-b2g/gaia/commit/5042f19da1eb8dd16974433be6a8a412f94eeac3
Summary: Show app titles in status bar → [IN ROCKETBAR] Show app titles in status bar
We will still need to track this for the master branch.
Blocks: 941176
Attachment #8362073 - Attachment is obsolete: true
Summary: [IN ROCKETBAR] Show app titles in status bar → Show app titles in status bar
Comment on attachment 8366996 [details] [review] Github pull request to master Ben or Vivien - could either one of you guys give this a quick review? This is necessary to catch master up to the rocketbar branch, and something we should probably do before turning it on. Thanks!
Attachment #8366996 - Flags: review?(bfrancis)
Attachment #8366996 - Flags: review?(21)
Comment on attachment 8366996 [details] [review] Github pull request to master r+ with nits.
Attachment #8366996 - Flags: review?(21) → review+
Comment on attachment 8366996 [details] [review] Github pull request to master Thanks for the review! Ben if you have any follow-ups let me know and we will address them.
Attachment #8366996 - Flags: review?(bfrancis)
I haven't had a proper look at this, but just one point - if we're not landing bug 941175 without integration tests, we probably shouldn't land this bug without them either.
(In reply to Ben Francis [:benfrancis] from comment #11) > I haven't had a proper look at this, but just one point - if we're not > landing bug 941175 without integration tests, we probably shouldn't land > this bug without them either. I think unit testing here is sufficient, but I'll see if I can crank out some integration tests as well. For bug 941175, I'm ok landing initially without integration tests, but I would prefer that we don't break existing ones. I can also help rebase that one later today - as most of the patches will have been landed in master. Will follow-up in that bug or in IRC.
Lando: https://github.com/mozilla-b2g/gaia/commit/9867bf994d2155fee660a0d09294881aa26c9ebd
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
I see app titles untranslated - is this expected?
Depends on: 966312
(In reply to Stefan Plewako [:stef] from comment #14) > I see app titles untranslated - is this expected? Thanks. Bug 966312 has been filed to address this.
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: