941176 - [User Story] [Meta] Browser Chrome: View title

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System::Browser Chrome, defect)

Description

[Peter Dolanjski [:pdol]]

User Story:
As a user I want to view the title of the web page I'm currently on so that I can see the title of the website I am currently viewing.

Acceptance Criteria:
Functionality should match existing Browser functionality unless described otherwise in UX spec.

Comment 1

[Kevin Grandon :kgrandon]

Attachment: Github pull request

Dale - just marking you as reviewer so you are aware. We should probably land your places datastore work first, or this will cause conflicts - and I'm sure I've given you plenty of those already :)

Feel free to review now, and we can land it at a later date. Tests are coming.

Comment 2

[Kevin Grandon :kgrandon]

Comment on attachment 8350674 [details] [review]
Github pull request

Starting to touch some system components, so alive should probably review this one as well :)

Comment 3

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8350674 [details] [review]
Github pull request

I'd like to publish the events from appWindow instead of appChrome.

To do this you need to add new events in AppWindow.REGISTERED_EVENTS and implement _handle_ + EVENT_NAME handler in AppWindow.prototype.

AppWindow.prototype.publish is your good friend to publish events.

Apology for not documenting these principles well.

Comment 4

[Kevin Grandon :kgrandon]

Comment on attachment 8350674 [details] [review]
Github pull request

Hi Alive,

Thanks for the awesome/quick review. I added one commit for some tests, and one commit for some adjustments. (Will squash before landing).

The new adjustments make sense and feel clean to me, so great ideas! Please let me know if you find anything else.

Comment 5

[Dale Harvey (:daleharvey)]

Comment on attachment 8350674 [details] [review]
Github pull request

Gonna clear r, theres a bug where navigating from web content to app contant (in particular e.me results) the title of the web content persists, I think its a pretty big bug that should be simple to fix, so think it would be good to fix before merging

It also looks strange on the lockscreen, however I think thats a more complex fix that will require UI follow up, so happy to merge before fixing that.

The rest looks really great, the tests on travis look unrelated so spun a new run

Comment 6

[Kevin Grandon :kgrandon]

Comment on attachment 8350674 [details] [review]
Github pull request

Hi Dale,

I've pushed a fix (including test), which does not allow inactive app windows to update the title. Before, the titlechange may have been updating the title after you close the window. I think this may have been what you are seeing.

To clarify, the following cases work for me:

1 - Open rocketbar, type url, press enter. Title appears.
2 - Press home, launch app
3 - Title disappears


1 - Open rocketbar, type url, press enter. Title appears.
2 - Open rocketbar again, and tap everything.me result
3 - Title updates with new E.me page title.

Comment 7

[Dale Harvey (:daleharvey)]

Comment on attachment 8350674 [details] [review]
Github pull request

Yup thats great, apologies for not being clearer with the STR

New version looking awesome

Comment 8

[Kevin Grandon :kgrandon]

Comment on attachment 8350674 [details] [review]
Github pull request

Alive - I've updated the pull request based on your feedback, and if you have any additional concerns, we can submit follow-up patches.

Comment 9

[Kevin Grandon :kgrandon]

Landed in master: https://github.com/mozilla-b2g/gaia/commit/56958810b8c51a513b6ef3263a362da7c9922d7f

Comment 10

[Ben Francis [:benfrancis]]

This is a good start but let's keep the user story open until we're ready for acceptance from Product/QA, we're not quite done here yet as it doesn't meet the UX spec.

Stealing.

Comment 11

[Ben Francis [:benfrancis]]

Let's make this a meta bug.

Comment 12

[Kevin Grandon :kgrandon]

I don't see a lot here, and I *think* that most work is now going to be a part of bug 959694. Closing so our focus for user testing makes sense.

Comment 13

[Ben Francis [:benfrancis]]

We're still not done here. Please leave this bug open until we're ready for acceptance by Product/UX/QA.

Unblocking 959353 as the patch on the Rocketbar branch fixes that requirement.

Comment 14

[Ben Francis [:benfrancis]]

Estimating as 2 points. This is assuming the necessary platform pieces are in place. We need some limited logic here to decide when to display the content of the <title> element, the app name, or the application-name meta tag.

Comment 15

[Kai-Chih Hu [:khu]]

Candice, can you help to assign updated target milestone for this 2.1 bug? Thanks.

Comment 16

[Ben Francis [:benfrancis]]

Looks like Vivien is working on this in bug 1039519, not much point in it being assigned to me.

https://bugzilla.mozilla.org/show_bug.cgi?id=1039519#c22

Comment 17

[Ben Francis [:benfrancis]]

Ready for acceptance testing :)