Closed Bug 962381 Opened 6 years ago Closed 6 years ago

Add support for NSIS 3.0a2

Categories

(Firefox :: Installer, defect)

x86_64
Windows 7
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 31

People

(Reporter: rstrong, Assigned: rstrong)

References

Details

(Whiteboard: [stubv2=])

Attachments

(2 files, 3 obsolete files)

NSIS 3.0a2 has functionality that I would like to have in Firefox. Specifically, a fix for bug 961958, the ability to specify supportedOS in the executable's manifest, and I am sure other things as well.
Note: Bug 962303 is for adding NSIS 3.0a2 to Mozilla Build.
Attached patch Installer changes (obsolete) — Splinter Review
This compiles and as far as I can tell works as expected. I'll make the configure changes in separate patch.
Assignee: nobody → robert.bugzilla
Status: NEW → ASSIGNED
Attached patch Installer changes (obsolete) — Splinter Review
Attachment #8363373 - Attachment is obsolete: true
This is backwards compatible with our current version of NSIS. I'm periodically seeing the compatibility prompt when cancelling and would like to get this landed since I might move forward with getting NSIS 3.0a2 on the build systems to fix that and a few other things.
Attachment #8365460 - Attachment is obsolete: true
Attachment #8396837 - Flags: review?(netzen)
Comment on attachment 8363591 [details] [diff] [review]
patch - configure changes

I'll request review from a build peer as well but I'd like to get your take on these changes.
Attachment #8363591 - Flags: feedback?(netzen)
Attachment #8363591 - Attachment is obsolete: true
Attachment #8363591 - Flags: feedback?(netzen)
Attachment #8396859 - Flags: feedback?(netzen)
Attachment #8396837 - Flags: review?(netzen) → review+
Attachment #8396859 - Flags: feedback?(netzen) → feedback+
Attachment #8396859 - Flags: review?(ted) → review?(gps)
Comment on attachment 8396837 [details] [diff] [review]
Installer changes

Pushed the NSIS installer changes to mozilla-inbound since they are backwards compatible and I want to make sure that all is well with them.
https://hg.mozilla.org/integration/mozilla-inbound/rev/08ec6ef03ae3
Attachment #8396837 - Flags: checkin+
Whiteboard: [stubv2=] → [leave open][stubv2=]
Attachment #8396859 - Flags: review?(gps) → review?(mshal)
Attachment #8396859 - Flags: review?(mshal) → review+
Pushed the configure changes to fx-team
https://hg.mozilla.org/integration/fx-team/rev/c4bd8d2d0a37
Flags: in-testsuite-
Whiteboard: [leave open][stubv2=] → [stubv2=]
Target Milestone: --- → Firefox 31
https://hg.mozilla.org/mozilla-central/rev/c4bd8d2d0a37
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Depends on: 1003758
You need to log in before you can comment on or make changes to this bug.