962453 - [DSDS] Once visit APN setting of one SIM, same APN of another SIM will be changed to "Custom"

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Enpei]

+++ This bug was initially created as a clone of Bug #960388 +++

When switch SIM 1 either data/message/A-GPS APN setting, i.e. select 2nd item in data apn setting, SIM 2 data setting will be set to "custom", vice versa.

* Build Number  
Fugu              
Gaia      a119a0692c24c5ed7c55bab838bae3ecdb9dbec9
Gecko     15ee4e78431b45922b41dea882464b0ccb6b4fac
BuildID   20140110174141
Version   28.0a2

* Reproduce Steps
1. Go to Data setting of SIM 1, select first APN item, not custom.
2. Go to Data setting of SIM 2, find that APN is set in custom, change it to first item.
3. Go back to Data setting of SIM 1.

* Expected Result
APN should be kept in first item.

* Actual Result
SIM 1 APN is set to custom. Same behavior on Data/Message and GPS APN settings.

* Occurrence rate
100%

Comment 1

[José Antonio Olivera Ortega [:jaoo]]

I'll take care of it. Need to review and touch a bit how to select the APN being used for the RIL plumbing when creating the APN list.

Comment 2

[José Antonio Olivera Ortega [:jaoo]]

Attachment: v1

This patch should fix the issue. Needs to be tested on fugu device. I'll request review as soon as I do the tests.

Comment 3

[Preeti Raghunath(:Preeti)]

Enpei

Please help with attaching a video of the same.

Comment 4

[José Antonio Olivera Ortega [:jaoo]]

Attachment: Pointer to Github PR https://github.com/mozilla-b2g/gaia/pull/15654

Comment 5

[José Antonio Olivera Ortega [:jaoo]]

Attachment: v2

Arthur, I wanted to touch a bit how to select the APN being used for the RIL plumbing when creating the APN list. This patch selects it correctly and solves the issue Enpei found. Could you take a look please? Thanks.

I found something we miss in the system/js/operator_variant/operator_variant.js file when we refactor that part for DSDS features. It is about authentication type for the APN. Please let me know if you want to take out and file a new bug for it.

PS. Feel free to review the patch through the PR.

Comment 6

[Enpei]

Attachment: VIDEO0026.mp4

Please notice that the video was taken after flash build. So when I opened SIM 2 data setting, the default checked item is "Custom" already which is very odd.

Comment 7

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8364465 [details] [diff] [review]
v2

Thanks for the patch, Jose. Please check my github comments.

Comment 8

[José Antonio Olivera Ortega [:jaoo]]

Attachment: v3

(In reply to Arthur Chen [:arthurcc] (OOO 1/30 ~ 2/4) from comment #7)
> Comment on attachment 8364465 [details] [diff] [review]
> v2
> 
> Thanks for the patch, Jose. Please check my github comments.

Thanks Arthur, comments addressed. Could you take a look a it again please? Thanks.

Comment 9

[José Antonio Olivera Ortega [:jaoo]]

Attachment: v4

Bug 962912 just landed. This is the version after rebasing. Arthur, Could you take a look a it again please? Thanks.

Comment 10

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8367266 [details] [diff] [review]
v4

A few comments related to UI, could you check them in github? Thanks.

Comment 11

[José Antonio Olivera Ortega [:jaoo]]

Attachment: v5

Address review comments made at comment #10. PR updated as well.

Comment 12

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8367849 [details] [diff] [review]
v5

r=me with the last comment addressed. Thank you for the effort!

Comment 13

[José Antonio Olivera Ortega [:jaoo]]

Thanks Arthur, landed on Gaia master branch at https://github.com/mozilla-b2g/gaia/commit/4d0b2ffaf044a20b5bea9d7d85d4ecc5a71080fd

Travis went green and everything seems to work correctly.

Comment 14

[John Ford [:jhford] CET/CEST Berlin Time]

I was not able to uplift this bug to v1.3.  If this bug has dependencies which are not marked in this bug, please comment on this bug.  If this bug depends on patches that aren't approved for v1.3, we need to re-evaluate the approval.  Otherwise, if this is just a merge conflict, you might be able to resolve it with:

  git checkout v1.3
  git cherry-pick -x -m1 4d0b2ffaf044a20b5bea9d7d85d4ecc5a71080fd
  <RESOLVE MERGE CONFLICTS>
  git commit

Comment 15

[José Antonio Olivera Ortega [:jaoo]]

Landed on Gaia v1.3 branch at https://github.com/mozilla-b2g/gaia/commit/7ca66153de633fad5d034908dea809dce1015dbb

Comment 16

[Enpei]

Verified.

Fugu - 
Gaia      bb36b4164d3e51ca04b612e507e1178f80bf240d
Gecko     4227240a4d3e1e418ced160c2a48cb454d7b5645
BuildID   20140204104742
Version   28.0