Closed Bug 962474 Opened 10 years ago Closed 10 years ago

[Download Manager] Confirmation screen is not displayed after trying delete a file

Categories

(Firefox OS Graveyard :: Gaia::Settings, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Settings
Platform:
Other
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
VERIFIED FIXED
Milestone:
1.4 S1 (14feb)

People

(Reporter: rafael.marquez, Assigned: crdlc)

References

Details

(Whiteboard: [systemsfe])

Attachments

(1 file)

Patch v1
190 bytes, text/html
borjasalguero
: review+
kaze
: feedback+
Details 
*Procedure
1. Opening Settings app
2. Opening Donwloads list
3. Press Edit button
4. Select a download
5. Press Delete button


*Exxpected Result
A confirmation screen is displayed (DM_settingsDrawer0.14 page 20 , bug 926955)

*Actual Result
The file is deleted but any confirmation screen is displayed.
Whiteboard: [systemsfe]
Assignee: nobody → crdlc
Status: NEW → ASSIGNED
blocking-b2g: --- → 1.4?
Attached file Patch v1 — 
There was not a bug, basically we forgot to show the confirmation UI before removing the selected download :)
Attachment #8370781 - Flags: review?(borja.bugzilla)
Attachment #8370781 - Flags: feedback?(kaze)
Attachment #8370781 - Flags: review?(borja.bugzilla) → review+
Merged in master:

https://github.com/crdlc/gaia/commit/59c415baffa13794baf5e745e44a580e33f043a0

Gracias Borja!
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.4 S1 (14feb)
Kaze,

    I got insane for a while and landed it without your feedback :( My apologies, feel free to open this bug if you see something wrong please. Sorry mate

Thanks
Flags: needinfo?(kaze)
Comment on attachment 8370781 [details]
Patch v1

Post-mortem f+, LGTM.

However, you should have requested Borja an f? and a Settings peer (e.g. Evelyn, Arthur or myself) an r? — not the opposite.
Attachment #8370781 - Flags: feedback?(kaze) → feedback+
Flags: needinfo?(kaze)
I was mistaken, sorry Fabien
This case is verified but i have just opened a bug to a similar feature. bug 970225
Status: RESOLVED → VERIFIED
blocking-b2g: 1.4? → ---
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: