962474 - [Download Manager] Confirmation screen is not displayed after trying delete a file

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[rafael.marquez]

*Procedure
1. Opening Settings app
2. Opening Donwloads list
3. Press Edit button
4. Select a download
5. Press Delete button


*Exxpected Result
A confirmation screen is displayed (DM_settingsDrawer0.14 page 20 , bug 926955)

*Actual Result
The file is deleted but any confirmation screen is displayed.

Comment 1

[Cristian Rodriguez (:crdlc)]

Attachment: Patch v1

There was not a bug, basically we forgot to show the confirmation UI before removing the selected download :)

Comment 2

[Cristian Rodriguez (:crdlc)]

Merged in master:

https://github.com/crdlc/gaia/commit/59c415baffa13794baf5e745e44a580e33f043a0

Gracias Borja!

Comment 3

[Cristian Rodriguez (:crdlc)]

Kaze,

    I got insane for a while and landed it without your feedback :( My apologies, feel free to open this bug if you see something wrong please. Sorry mate

Thanks

Comment 4

[Fabien Cazenave [:kaze]]

Comment on attachment 8370781 [details]
Patch v1

Post-mortem f+, LGTM.

However, you should have requested Borja an f? and a Settings peer (e.g. Evelyn, Arthur or myself) an r? — not the opposite.

Comment 5

[Cristian Rodriguez (:crdlc)]

I was mistaken, sorry Fabien

Comment 6

[rafael.marquez]

This case is verified but i have just opened a bug to a similar feature. bug 970225