Closed Bug 964049 Opened 10 years ago Closed 8 years ago

Fullscreen not working on Dailymotion.com

Categories

(Web Compatibility :: Site Reports, defect)

ARM
Android
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED WORKSFORME

People

(Reporter: iamjayakumars, Unassigned, Mentored, NeedInfo)

References

()

Details

(Whiteboard: [contactready] [country-fr] )

Hi, When i click the Fullscreen button on Dailymation.com video. Nothing happens.


Actual
When i click the full screen button, nothing happens. 


Expected

When i click the Full screenbutton, the video must show in fullscreen
Broken in desktop Firefox using a Firefox for Android user agent. Mike could someone from the website compatibility team look at this and check to see if this is an evangelism issue?
Flags: needinfo?(miket)
Ah indeed. It appears the problem is here: http://static1.dmcdn.net/js/gen/widget/pack/player.js.vaebabc6ce824d6139

More specifically at https://gist.github.com/miketaylr/8658799#file-gistfile1-txt-L3111-L3119 (beautified), there are a few instances of using webkit prefixed fullscreen API methods:

var L = (Modernizr.mobile || Modernizr.tablet) && !Modernizr.ios;
if ((this.forceFullscreen === "auto" || 
     this.forceFullscreen === true) && 
     this.player.webkitSupportsFullscreen && L) {
  var H = $(window).width(),
  y = $(window).height(),
  K = (H > y) ? y : H;
  if (this.forceFullscreen === true || K < 400) {
    this.player.webkitEnterFullscreen()
  }
}

There's also https://gist.github.com/miketaylr/8658799#file-gistfile1-txt-L3290-L3295

There are also these non-standard events: https://gist.github.com/miketaylr/8658799#file-gistfile1-txt-L2886-L2895 (mentioned here: https://developer.apple.com/library/safari/documentation/AudioVideo/Conceptual/Using_HTML5_Audio_Video/ControllingMediaWithJavaScript/ControllingMediaWithJavaScript.html) that may come into play with fixing this issue.

We should reach out to dailymotion and ask that they add the standard, non-prefixed variants to their mobile player code as well.
Whiteboard: [contactready][country-all]
Component: General → Mobile
Product: Firefox for Android → Tech Evangelism
Version: Firefox 27 → Trunk
Whiteboard: [contactready][country-all] → [contactready] [country-fr] [mentor=kdubost]
Seems to work fine now, videos play in fullscreen on Fx Android and Fx OS
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → WORKSFORME
This issue has been confirmed on Flame 2.0 during recent MWC testing 

@Adora - Could you see Mike's comment above and reach out to the Dev?
Status: RESOLVED → REOPENED
Flags: needinfo?(adora)
Resolution: WORKSFORME → ---
Mentor: kdubost
Whiteboard: [contactready] [country-fr] [mentor=kdubost] → [contactready] [country-fr]
@ Adora - Any updates on this bug?  Have we reached out to the developer?
Works now, Firefox Android
Status: REOPENED → RESOLVED
Closed: 10 years ago8 years ago
Resolution: --- → WORKSFORME
Enable these parameters "webkitallowfullscreen mozallowfullscreen allowfullscreen"
Product: Tech Evangelism → Web Compatibility
Component: Mobile → Site Reports
You need to log in before you can comment on or make changes to this bug.