964066 - Restyle the Quick filter bar

Status: RESOLVED FIXED

(Thunderbird :: Theme, defect)

Description

[Richard Marti (:Paenglab)]

Like bug 963946 this bug is to remove the border between the two QFB rows and to fix the different toolbar height when the tags are shown/not shown. On Aero the tags should become back the tag colors to make the recognition easier.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: patch

Fixes for XP and Vista/7/8

Comment 2

[Richard Marti (:Paenglab)]

Attachment: Win7.png

Upper half without patch on Aero and Classic. Remark the different button height.
Lower half with patch.

Comment 3

[Richard Marti (:Paenglab)]

Attachment: XP.png

The same on XP. Upper half without patch and lower half with patch on Luna blue and Classic.

Comment 4

[Josiah Bruner [:jsbruner]]

Comment on attachment 8365677 [details] [diff] [review]
patch

Review of attachment 8365677 [details] [diff] [review]:
-----------------------------------------------------------------

So this look good to me. I do have a few questions though. r+ with responses to my questions.

::: mail/themes/windows/mail/quickFilterBar-aero.css
@@ +134,5 @@
>  
> +#qfb-boolean-mode {
> +  margin: 0 1px;
> +  padding-top: 0 !important;
> +  padding-bottom: 0 !important;

Did you check to make sure the !importants are necessary?

@@ +191,5 @@
>  }
>  
> +#quick-filter-bar toolbarbutton,
> +#quick-filter-bar toolbarbutton:hover:active,
> +#quick-filter-bar toolbarbutton[checked] {

If we're sharing all these rules with all three selectors why don't we just use "#quick-filter-bar toolbarbutton"? Why do we need to include :hover:active and [checked]?

Comment 5

[Richard Marti (:Paenglab)]

Attachment: Patch for check-in

(In reply to Josiah Bruner [:JosiahOne] from comment #4)
> Comment on attachment 8365677 [details] [diff] [review]
> patch
> 
> Review of attachment 8365677 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> So this look good to me. I do have a few questions though. r+ with responses
> to my questions.
> 
> ::: mail/themes/windows/mail/quickFilterBar-aero.css
> @@ +134,5 @@
> >  
> > +#qfb-boolean-mode {
> > +  margin: 0 1px;
> > +  padding-top: 0 !important;
> > +  padding-bottom: 0 !important;
> 
> Did you check to make sure the !importants are necessary?

Yes, this is needed to override this http://mxr.mozilla.org/comm-central/source/mail/themes/windows/mail/mailWindow1-aero.css#231
 
> @@ +191,5 @@
> >  }
> >  
> > +#quick-filter-bar toolbarbutton,
> > +#quick-filter-bar toolbarbutton:hover:active,
> > +#quick-filter-bar toolbarbutton[checked] {
> 
> If we're sharing all these rules with all three selectors why don't we just
> use "#quick-filter-bar toolbarbutton"? Why do we need to include
> :hover:active and [checked]?

You're right, I moved it to the first #quick-filter-bar toolbarbutton rule and removed a padding: 3px on the #quick-filter-bar toolbarbutton:hover:active, #quick-filter-bar toolbarbutton[checked="true"] rule.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/comm-central/rev/63f631f47649