964104 - Icon moves when activating toolbar buttons that show panels

Status: VERIFIED FIXED

(Firefox :: Theme, defect)

Description

[Michael Monreal [:micmon]]

There are two kinds of "buttons" which can be placed on the toolbar: those who just execute one action ("open new window") and those who show a menu. I am talking about the second kind here. This is true for the current Linux nighlty build, I am not sure if other platforms have similar problems.

Currently there seem to be four (!) ways a "button which shows a menu" can work:

1.) the menu opens on mouse-release, icon changes position a few pixels to bottom/right. This can be seen here:
- Encoding
- History
- Web developer tools
- Downloads

2.) the menu opens on mouse-press, the icon changes position a few pixels to bottom/right. Does not support activation of items by press-drag-release. This can be seen here:
- Customize and control


3.) the menu opens on mouse-press, icon does never changes position but menu changes postion a few pixels to the right after moving the mouse pointer to the menu. Does support activation of items by press-drag-release. This can be seen here:
- Bookmarks

4.) the menu opens on long-press, icon changes postion but only when moving mouse away from the button while keeping the mouse button down. This can be seen here:
- Back
- Forward

IMHO 1-3 menus should 
a) already open on mouse-press
b) support press-drag-release to activate contained items
c) not move the icon around

Case 4 is special, it works fine but the icon should not change position.

Comment 1

[:Gijs (he/him)]

Some of these are known (e.g. the bookmarks menu moving is bug 940265), but what really concerns me is that you're seeing the icons move. I've not heard that before. Can you perhaps take a before/after screenshot?

Meanwhile, any ideas about this, Jared?

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Yes I had to work around this a little with my Linux toolbar buttons patch but I'm surprised it is still happening. I thought I had fixed them all. This is likely due to the buttons being implemented differently. Iirc, the margins on the icons may change in :hover:active.

Comment 3

[Michael Monreal [:micmon]]

Attachment: 1.png

This shows the problem on the menu button. The whole button actually moves one pixel to the right when pressed, the image seems to stay centered relative to the button borders.

Comment 4

[Michael Monreal [:micmon]]

The bookmarks menu seems to be working exactly as I would expect now, all other points are still valid in today's v29 australis-enabled Aurora build

Comment 5

[:Gijs (he/him)]

Attachment: fix icons moving when pressing down on Australis for Linux,

This fixes the buttons' states. Note that the downloads button needed an additional fix which is simply copied from the Windows theme - otherwise its dimensions were still off after having loaded the indicator overlay.

Comment 6

[:Gijs (he/him)]

Comment on attachment 8372885 [details] [diff] [review]
fix icons moving when pressing down on Australis for Linux,

Review of attachment 8372885 [details] [diff] [review]:
-----------------------------------------------------------------

Punting to Jared. :-)

Comment 7

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8372885 [details] [diff] [review]
fix icons moving when pressing down on Australis for Linux,

Review of attachment 8372885 [details] [diff] [review]:
-----------------------------------------------------------------

I tested out the padding change it looks good to me. rs=me on the downloads change.

::: browser/themes/linux/browser.css
@@ +559,5 @@
>  :-moz-any(#TabsToolbar, #nav-bar) .toolbarbutton-1 {
>    -moz-appearance: none;
>  }
>  
> +:-moz-any(#TabsToolbar, #nav-bar) .toolbarbutton-1[open="true"], 

nit, trailing whitespace

Comment 8

[:Gijs (he/him)]

remote:   https://hg.mozilla.org/integration/fx-team/rev/b563dbb8da42

Comment 9

[:Gijs (he/him)]

I've split off the press->move->activate stuff into bug 971260 so we can track things separately. The icons moving should be fixed on Fx-Team now, and will make its way down to a build near you in the usual manner.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/b563dbb8da42

Comment 11

[:Gijs (he/him)]

Comment on attachment 8372885 [details] [diff] [review]
fix icons moving when pressing down on Australis for Linux,

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Australis
User impact if declined: some buttons move on Linux when clicked
Testing completed (on m-c, etc.): on m-c for a while
Risk to taking this patch (and alternatives if risky): very low
String or IDL/UUID changes made by this patch: none

Comment 12

[:Gijs (he/him)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/75f50d988448