Closed Bug 964186 Opened 6 years ago Closed 6 years ago

B2G NFC: rename MozNdefRecord to MozNDEFRecord

Categories

(Firefox OS Graveyard :: NFC, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
1.4 S1 (14feb)

People

(Reporter: allstars.chh, Assigned: dgarnerlee)

References

Details

Attachments

(2 files, 3 obsolete files)

This is mentioned by Hsinyi during last WebAPI review with Jonas.

MozNdefRecord is not a consistent naming style, with comparing to readNDEF, writeNDEF, and sendNDEF from MozNFCTag and MozNFCPeer.

Also W3C NFC API also uses capital case for NDEF, i.e. NDEFRecord.
Agreed. We will need to add this as a depencency to the user stories ahead of time to get a smooth transition early and quick for MWC: it'll impact user code (1.3 and 1.4).
Depends on: 963556
browser, nfc_manager, and nfc_util updates.
Blocks: 963556
No longer depends on: 963556
Add missing webidl rename commit.
Attachment #8367029 - Attachment is obsolete: true
Attachment #8367032 - Flags: review?(alive)
Attachment #8367055 - Flags: superreview?(jonas)
Attachment #8367055 - Flags: review?(bugs)
Comment on attachment 8367055 [details] [diff] [review]
(v1.1) Bug 964186: Rename MozNdefRecord to MozNDEFRecord

I was expecting to see hg rename here. Not copying stuff to a new file and removing the old one.
Attachment #8367055 - Flags: review?(bugs) → review-
Per review comment, add the -M option to git format-patch to show renames properly.
Attachment #8367055 - Attachment is obsolete: true
Attachment #8367055 - Flags: superreview?(jonas)
Attachment #8367667 - Flags: review?(bugs)
Attachment #8367032 - Flags: review?(alive) → review+
Another hg run with updated rename patch: https://hg.mozilla.org/try/rev/1798acf2414f
Attachment #8367667 - Flags: superreview?(jonas)
Attachment #8367667 - Flags: review?(bugs) → review+
Attachment #8367032 - Attachment description: (v1) Rename MozNdefRecord to MozNDEFRecord (gaia) → (v1) Rename MozNdefRecord to MozNDEFRecord (gaia) r=alive
Attachment #8367667 - Attachment description: (v1.2) Bug 964186: Rename MozNdefRecord to MozNDEFRecord → (v1.2) Bug 964186: Rename MozNdefRecord to MozNDEFRecord r=smaug
Attachment #8367667 - Flags: superreview?(jonas) → superreview+
Assignee: nobody → dgarnerlee
Keywords: checkin-needed
https://hg.mozilla.org/integration/b2g-inbound/rev/0cd65176a922

Master: b495d7891692c958f02c1a743d1d03c8c72aae15
Keywords: checkin-needed
(In reply to Yoshi Huang[:allstars.chh] from comment #10)
> Please update the wiki as well https://wiki.mozilla.org/WebAPI/WebNFC

Thanks. Done.
https://hg.mozilla.org/mozilla-central/rev/0cd65176a922
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.4 S1 (14feb)
You need to log in before you can comment on or make changes to this bug.