Closed Bug 964186 Opened 6 years ago Closed 6 years ago
B2G NFC: rename Moz
Ndef Record to Moz NDEFRecord
46 bytes, text/x-github-pull-request
|Details | Review|
15.58 KB, patch
|Details | Diff | Splinter Review|
This is mentioned by Hsinyi during last WebAPI review with Jonas. MozNdefRecord is not a consistent naming style, with comparing to readNDEF, writeNDEF, and sendNDEF from MozNFCTag and MozNFCPeer. Also W3C NFC API also uses capital case for NDEF, i.e. NDEFRecord.
6 years ago
Agreed. We will need to add this as a depencency to the user stories ahead of time to get a smooth transition early and quick for MWC: it'll impact user code (1.3 and 1.4).
browser, nfc_manager, and nfc_util updates.
Add missing webidl rename commit.
Attachment #8367029 - Attachment is obsolete: true
Comment on attachment 8367055 [details] [diff] [review] (v1.1) Bug 964186: Rename MozNdefRecord to MozNDEFRecord I was expecting to see hg rename here. Not copying stuff to a new file and removing the old one.
Attachment #8367055 - Flags: review?(bugs) → review-
Per review comment, add the -M option to git format-patch to show renames properly.
Attachment #8367032 - Flags: review?(alive) → review+
Another hg run with updated rename patch: https://hg.mozilla.org/try/rev/1798acf2414f
Attachment #8367032 - Attachment description: (v1) Rename MozNdefRecord to MozNDEFRecord (gaia) → (v1) Rename MozNdefRecord to MozNDEFRecord (gaia) r=alive
Attachment #8367667 - Attachment description: (v1.2) Bug 964186: Rename MozNdefRecord to MozNDEFRecord → (v1.2) Bug 964186: Rename MozNdefRecord to MozNDEFRecord r=smaug
Attachment #8367667 - Flags: superreview?(jonas) → superreview+
Please update the wiki as well https://wiki.mozilla.org/WebAPI/WebNFC
https://hg.mozilla.org/integration/b2g-inbound/rev/0cd65176a922 Master: b495d7891692c958f02c1a743d1d03c8c72aae15
(In reply to Yoshi Huang[:allstars.chh] from comment #10) > Please update the wiki as well https://wiki.mozilla.org/WebAPI/WebNFC Thanks. Done.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.4 S1 (14feb)
You need to log in before you can comment on or make changes to this bug.