964697 - (emulator-NFC) B2G Emulator: NFC support in KK

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Emulator, defect)

Description

[Vicamo Yang [:vicamo][:vyang]]

+++ This bug was initially created as a clone of Bug #916863 +++

We have had NFC support in JellyBean emulator since bug 916863 and KitKat emulator builds in bug 957526.  To enable NFC to KitKat emulator, the very first thing we should do is to cherry-pick Mozilla B2G Emulator specific changes from https://github.com/mozilla-b2g/kernel_goldfish/tree/b2g-goldfish-2.6.29 to https://github.com/mozilla-b2g/kernel_goldfish/commit/6dff53c, which is the commit that current KitKat emulator kernel is built from[1].  Then we can go on to cherry-pick or merge remaining NFC-related changes in device/generic/goldfish, build, manifest, external/qemu.

[1]: See https://android.googlesource.com/platform/prebuilts/qemu-kernel/+/android-4.4.2_r1

Comment 1

[Vicamo Yang [:vicamo][:vyang]]

Update: NFC emulation changes had been merged into emulator-kitkat since https://github.com/mozilla-b2g/platform_external_qemu/commits/5ba6bcbdba30842b02f33f595660e32e3b9182d8 .

Comment 2

[Vicamo Yang [:vicamo][:vyang]]

Maybe we should ignore Bluedroid porting progress and cherry-pick NFC changes to KitKat first.  Depend on bug 997469 because it creates b2g-4.4.2_r1 branch in prebuilts/qemu-kernel.

Comment 3

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: Github tree for build/

Comment 4

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: Github tree for repository

Comment 5

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: Github tree for prebuilts/qemu-kernel/

Comment 6

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: Github tree for kernel driver

Comment 7

[Vicamo Yang [:vicamo][:vyang]]

Attachment: adb-logcat.txt.gz

Hi, I had a try with these pull requests but most NFC test cases fail except test_ndef.js.

Gecko: 3bf1a97537d3651304bb158e5cd9a500d9dcb846
Gaia: 52c3473fbe58b16e8729e11cb5a61078a93166cc
build: 5c3064cb3271c42e09fc386bf1da6bcd76e73b1f merged
external/libnfc-nci: 1ba9dcccf5b342bd74a2f8213b7ed3be78b9db44
external/qemu: e4b7cd053711ece3cd5616cd4fb7f75c43bce9c0
prebuilts/qemu-kernel: acbd9efc2a154943978d60dccbaea37a05a820d4
system/nfcd: aad3e80dea67774aa51ed4e6c054856168dd180b

Comment 8

[Thomas Zimmermann [:tzimmermann] [:tdz]]

(In reply to Vicamo Yang [:vicamo][:vyang] from comment #7)
> Created attachment 8480351 [details]
> adb-logcat.txt.gz

That file is compressed twice :D

> Hi, I had a try with these pull requests but most NFC test cases fail except
> test_ndef.js.

Thanks for trying. This logcat shows Marionette timeouts AFAICS and there's also the dead-object problem again:

> 08-28 04:41:32.580 E/GeckoConsole(   63): [JavaScript Error: "can't access dead object" {file: "jar:file:///system/b2g/omni.ja!/components/SettingsManager.js" line: 99}]

It's tracked in bug 777840.

> Gecko: 3bf1a97537d3651304bb158e5cd9a500d9dcb846
> Gaia: 52c3473fbe58b16e8729e11cb5a61078a93166cc
> build: 5c3064cb3271c42e09fc386bf1da6bcd76e73b1f merged
> external/libnfc-nci: 1ba9dcccf5b342bd74a2f8213b7ed3be78b9db44
> external/qemu: e4b7cd053711ece3cd5616cd4fb7f75c43bce9c0
> prebuilts/qemu-kernel: acbd9efc2a154943978d60dccbaea37a05a820d4
> system/nfcd: aad3e80dea67774aa51ed4e6c054856168dd180b

Comment 9

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Is the development still active?

Comment 10

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Sort of. The attached patches were complete for an older version of NFC at least. But since emulator-kk is only now getting an option, nothing has ever landed. Once we have automated tests for emulator-kk, I wanted to merge the patch set as well.

Comment 11

[Thomas Zimmermann [:tzimmermann] [:tdz]]

This bug is strictly KK.

Comment 12

[Vincent Chang[:vchang][changyihsin]]

Thomas, do you have time to work on this? We are willing to help if you are busy on others bug.

Comment 13

[Dimi Lee [:dimi]]

I have talked with thomas , i will work on this issue

Comment 14

[Dimi Lee [:dimi]]

Attachment: [PullRequest] Part1. Add nfcd & libnfc-nci to emulator KK repo

Comment 15

[Dimi Lee [:dimi]]

Attachment: [PullRequest] Part2. Update build to enable NFC

Comment 16

[Dimi Lee [:dimi]]

Attachment: [PullRequest] Part3. Update nfc permission and add config file

Comment 17

[Dimi Lee [:dimi]]

Attachment: [PullRequest] Part4. Update prebuilts/qemu-kernel/

Comment 18

[Dimi Lee [:dimi]]

Attachment: [PullRequest] Part5. Update kernel driver

Comment 19

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Comment on attachment 8601975 [details] [review]
[PullRequest] Part5. Update kernel driver

This looks like the JB driver, so it's probably save to r+. Are there any major changes in this patch?

Comment 20

[Dimi Lee [:dimi]]

(In reply to Thomas Zimmermann [:tzimmermann] [:tdz] from comment #19)
> Comment on attachment 8601975 [details] [review]
> [PullRequest] Part5. Update kernel driver
> 
> This looks like the JB driver, so it's probably save to r+. Are there any
> major changes in this patch?

No, i have checked the NFC testcases, emulator side seems work correctly

Comment 21

[(Out Sep 17-23) Ryan VanderMeulen]

Master: https://github.com/mozilla-b2g/b2g-manifest/commit/3a243043a7040dbe47a52245d17ee038cc9eb5d4

b2g-4.4.2_r1: https://github.com/mozilla-b2g/platform_build/commit/a8ace1361d702eef293e48f2ea525dac686daa86

b2g-4.4.2_r1: https://github.com/mozilla-b2g/device_generic_goldfish/commit/d4377e11659d54b41c51526547e971ba0cb11754

b2g-4.4.2_r1: https://github.com/mozilla-b2g/platform_prebuilts_qemu-kernel/commit/6a1bb59af65b6485b1090522f66fac95c3f9e22c

b2g-goldfish-3.4: https://github.com/mozilla-b2g/kernel_goldfish/commit/85f658c7bdbc9babdd2de5d93d72b053287a0f29