Closed
Bug 964805
Opened 10 years ago
Closed 10 years ago
shared media files no longer included in app zip file
Categories
(Firefox OS Graveyard :: Gaia, defect, P1)
Tracking
(blocking-b2g:1.4+, b2g-v1.4 fixed)
| Tracking | Status | |
|---|---|---|
| b2g-v1.4 | --- | fixed |
People
(Reporter: bkelly, Assigned: yurenju)
References
Details
(Keywords: regression, smoketest, Whiteboard: [c= p=1 s=2014.01.31 u=1.4])
Attachments
(1 file)
After bug 957497 landed ringtones and alert media files are no longer included in the ringtones application.zip. The directories are there, but no files. I assume its related to this code: https://github.com/mozilla-b2g/gaia/commit/3eb52bf51d1ce57cdbbf9ee8cade488d77985ef1#diff-8d06cf2fa60a709d7fe1324030517ce8R69
|
Reporter | |
Comment 1•10 years ago
|
||
This fixed the issue of missing ringtones and notification files in the zip. Yuren, how does this look to you?
Assignee: nobody → bkelly
Status: NEW → ASSIGNED
Attachment #8366675 -
Flags: review?(yurenju.mozilla)
|
|
Reporter | |
Updated•10 years ago
|
Whiteboard: [c= p=1 s= u=]
|
|
Reporter | |
Comment 2•10 years ago
|
||
Comment on attachment 8366675 [details] [review] Pull request at https://github.com/mozilla-b2g/gaia/pull/15769 Actually, this doesn't quite work completely. It fixes the issue for ringtones app, but fails on system app.
Attachment #8366675 -
Flags: review?(yurenju.mozilla) → feedback?(yurenju.mozilla)
|
|
Reporter | |
Comment 3•10 years ago
|
||
Unfortunately I don't have time to solve this. Yuren, can you take a look?
Assignee: bkelly → nobody
Status: ASSIGNED → NEW
|
||
Updated•10 years ago
|
blocking-b2g: --- → 1.4+
Keywords: regression,
smoketest
|
||
Comment 5•10 years ago
|
||
I will fix this by backout the offending commit. Verifying the offending commit by manually inspecting the package built now...
Assignee: nobody → timdream
Status: NEW → ASSIGNED
|
|
Reporter | |
Comment 6•10 years ago
|
||
(In reply to Tim Guan-tin Chien [:timdream] (MoCo-TPE) (please ni?) from comment #5) > I will fix this by backout the offending commit. > > Verifying the offending commit by manually inspecting the package built > now... Tim, the commit linked in comment 0 seemed to cause it for me.
|
|
||
Comment 7•10 years ago
|
||
(In reply to Ben Kelly [:bkelly] from comment #6) > Tim, the commit linked in comment 0 seemed to cause it for me. Yes, I can verify Gaia before the offending commit does correctly include media files. Reassign to Yuren to resolve the revert conflict.
Assignee: timdream → yurenju.mozilla
|
Assignee | |
Comment 8•10 years ago
|
||
revert commits to solve it: https://github.com/mozilla-b2g/gaia/commit/e9fdf382c56857492ebe0b85cf0a4ebe80a3c0a0 https://github.com/mozilla-b2g/gaia/commit/8ed91982a0a85b57b9f7c02941aaea9bc5ad5fb8 https://github.com/mozilla-b2g/gaia/commit/87c66e243ab66164d207301ba551c1df75e204ca https://github.com/mozilla-b2g/gaia/commit/127aa58c777e81fe857bba1d45a9aaf9d32799cd
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Updated•10 years ago
|
Attachment #8366675 -
Flags: feedback?(yurenju.mozilla)
|
||
Updated•10 years ago
|
Priority: -- → P1
Whiteboard: [c= p=1 s= u=] → [c= p=1 s=2014.01.31 u=1.4]
|
|
||
Updated•10 years ago
|
Target Milestone: --- → 1.3 C3/1.4 S3(31jan)
|
||
Updated•10 years ago
|
status-b2g-v1.4:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•