Closed Bug 964805 Opened 11 years ago Closed 11 years ago

shared media files no longer included in app zip file

Categories

(Firefox OS Graveyard :: Gaia, defect, P1)

Product:
Firefox OS Graveyard
Component:
Gaia
Platform:
ARM
Gonk (Firefox OS)
Type:
defect

Tracking

(blocking-b2g:1.4+, b2g-v1.4 fixed)

Status:
RESOLVED FIXED
Milestone:
1.3 C3/1.4 S3(31jan)
Project Flags:
blocking-b2g 1.4+
Tracking Flags:
Tracking Status
b2g-v1.4 --- fixed

People

(Reporter: bkelly, Assigned: yurenju)

References

Details

(Keywords: regression, smoketest, Whiteboard: [c= p=1 s=2014.01.31 u=1.4])

Attachments

(1 file)

Pull request at https://github.com/mozilla-b2g/gaia/pull/15769
46 bytes, text/x-github-pull-request
Details | Review
After bug 957497 landed ringtones and alert media files are no longer included in the ringtones application.zip. The directories are there, but no files. I assume its related to this code: https://github.com/mozilla-b2g/gaia/commit/3eb52bf51d1ce57cdbbf9ee8cade488d77985ef1#diff-8d06cf2fa60a709d7fe1324030517ce8R69
This fixed the issue of missing ringtones and notification files in the zip. Yuren, how does this look to you?
Assignee: nobody → bkelly
Status: NEW → ASSIGNED
Attachment #8366675 - Flags: review?(yurenju.mozilla)
Blocks: 964768
Whiteboard: [c= p=1 s= u=]
Comment on attachment 8366675 [details] [review] Pull request at https://github.com/mozilla-b2g/gaia/pull/15769 Actually, this doesn't quite work completely. It fixes the issue for ringtones app, but fails on system app.
Attachment #8366675 - Flags: review?(yurenju.mozilla) → feedback?(yurenju.mozilla)
Unfortunately I don't have time to solve this. Yuren, can you take a look?
Assignee: bkelly → nobody
Status: ASSIGNED → NEW
blocking-b2g: --- → 1.4+
Keywords: regression, smoketest
I will fix this by backout the offending commit. Verifying the offending commit by manually inspecting the package built now...
Assignee: nobody → timdream
Status: NEW → ASSIGNED
(In reply to Tim Guan-tin Chien [:timdream] (MoCo-TPE) (please ni?) from comment #5) > I will fix this by backout the offending commit. > > Verifying the offending commit by manually inspecting the package built > now... Tim, the commit linked in comment 0 seemed to cause it for me.
(In reply to Ben Kelly [:bkelly] from comment #6) > Tim, the commit linked in comment 0 seemed to cause it for me. Yes, I can verify Gaia before the offending commit does correctly include media files. Reassign to Yuren to resolve the revert conflict.
Assignee: timdream → yurenju.mozilla
Attachment #8366675 - Flags: feedback?(yurenju.mozilla)
Priority: -- → P1
Whiteboard: [c= p=1 s= u=] → [c= p=1 s=2014.01.31 u=1.4]
Target Milestone: --- → 1.3 C3/1.4 S3(31jan)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: