965853 - Display SIM indication in missed call notification

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Description

[Anthony Ricaud (:rik)]

They should now read "SIM 1 - Missed call".

Comment 1

[Anthony Ricaud (:rik)]

Attachment: https://github.com/mozilla-b2g/gaia/pull/16370

Comment 2

[Anthony Ricaud (:rik)]

Carrie: When we are on a dual sim device with only 1 sim inserted, we don't display the SIM information (so just "Missed call"). Is that ok per spec?

Comment 3

[Carrie Wang [New account: [e-mail]]]

Hi Anthony,

I've been thinking about this question and I almost wanted to change my spec and add the SIM indication on notification and call button when there is only one SIM inserted. However, given that we don't provide rename function for users, if we show "SIM 1" everywhere, they might think, "hmmm, so where is the SIM 2?". In addition, the information will be a little bit too much and messy. Hence, I'd suggest keeping it simple and following the single SIM scenario. Thanks!

Comment 4

[Etienne Segonzac (:etienne)]

Comment on attachment 8377186 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/16370

The code change is clean, I like the extra coverage in dialer_test.js.
But the tests are red on travis and on my machine (APP=communications/dialer make test-agent-test).

Looks like a simple mocking issue, feel free to ask for an extra review round if it requires deeper changes.

Comment 5

[Anthony Ricaud (:rik)]

Comment on attachment 8377186 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/16370

Re-requesting review because I'm also touching handled_call_test.js.

Comment 6

[Etienne Segonzac (:etienne)]

Comment on attachment 8377186 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/16370

all good!

Comment 7

[Anthony Ricaud (:rik)]

https://github.com/mozilla-b2g/gaia/commit/77e8ceae894e5a9edb8ccd138fd80d5d941b6b06