Closed Bug 965853 Opened 6 years ago Closed 6 years ago

Display SIM indication in missed call notification

Categories

(Firefox OS Graveyard :: Gaia::Dialer, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
1.4 S2 (28feb)

People

(Reporter: rik, Assigned: rik)

References

Details

Attachments

(1 file)

They should now read "SIM 1 - Missed call".
Target Milestone: 1.4 S1 (14feb) → 1.4 S2 (28feb)
Attachment #8377186 - Flags: review?(etienne)
Carrie: When we are on a dual sim device with only 1 sim inserted, we don't display the SIM information (so just "Missed call"). Is that ok per spec?
Flags: needinfo?(cawang)
Hi Anthony,

I've been thinking about this question and I almost wanted to change my spec and add the SIM indication on notification and call button when there is only one SIM inserted. However, given that we don't provide rename function for users, if we show "SIM 1" everywhere, they might think, "hmmm, so where is the SIM 2?". In addition, the information will be a little bit too much and messy. Hence, I'd suggest keeping it simple and following the single SIM scenario. Thanks!
Flags: needinfo?(cawang)
Comment on attachment 8377186 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/16370

The code change is clean, I like the extra coverage in dialer_test.js.
But the tests are red on travis and on my machine (APP=communications/dialer make test-agent-test).

Looks like a simple mocking issue, feel free to ask for an extra review round if it requires deeper changes.
Attachment #8377186 - Flags: review?(etienne) → review+
Comment on attachment 8377186 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/16370

Re-requesting review because I'm also touching handled_call_test.js.
Attachment #8377186 - Flags: review+ → review?(etienne)
https://github.com/mozilla-b2g/gaia/commit/77e8ceae894e5a9edb8ccd138fd80d5d941b6b06
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
blocking-b2g: 1.4? → ---
Depends on: 977337
Blocks: b2g-dsds-1.4
Depends on: 979453
You need to log in before you can comment on or make changes to this bug.