966211 - Screen should not timeout when I have a running stopwatch

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Clock, defect)

Description

[Dale Harvey (:daleharvey)]

I need to know how long to cook my eggs damnit

Comment 1

[Sukant Garg [:gargsms]]

Hey, Dale,
I would like to work on this bug. Please guide me.

Comment 2

[Dale Harvey (:daleharvey)]

Hey Marcus

Is this a feature we want, is it in any backlog etc?

Comment 3

[Marcus Cavanaugh [:mcav]]

I don't think this is in any backlog, but it appears iOS keeps the screen alive, and it makes sense that if I was running a stopwatch, I'd likely want the screen to stay active unless I exit the app or manually lock it. Seems reasonable to me to fix.

Comment 4

[Sukant Garg [:gargsms]]

Attachment: Changed stopwatch_panel.js, working fine now

Comment 5

[Marcus Cavanaugh [:mcav]]

Comment on attachment 8369111 [details] [diff] [review]
Changed stopwatch_panel.js, working fine now

Looks good to me! I'd make two minor changes (which I can do when I land it, if you like, or you can update the patch if you prefer):

- I'd change `lockObj` to something more descriptive like `screenWakeLock`

- I'd just use `navigator` instead of `window.navigator`.

I'll test on Monday when I get back into work, and if all looks well, I'll land it in master.

Comment 6

[Marcus Cavanaugh [:mcav]]

[setting needinfo for me so that I can track it]

Comment 7

[Sukant Garg [:gargsms]]

(In reply to Marcus Cavanaugh [:mcav] <[e-mail]> from comment #5)
> Comment on attachment 8369111 [details] [diff] [review]
> Changed stopwatch_panel.js, working fine now
> 
> Looks good to me! I'd make two minor changes (which I can do when I land it,
> if you like, or you can update the patch if you prefer):
> 
> - I'd change `lockObj` to something more descriptive like `screenWakeLock`
> 
> - I'd just use `navigator` instead of `window.navigator`.
> 
> I'll test on Monday when I get back into work, and if all looks well, I'll
> land it in master.

I did update the patch. Thank you!

Comment 8

[Sukant Garg [:gargsms]]

Attachment: Comment #5 taken into account

Comment 9

[Marcus Cavanaugh [:mcav]]

Comment on attachment 8369157 [details] [diff] [review]
Comment #5 taken into account

r+, though the diff is backwards (minus lines instead of plus lines). Will land after travis passes.

Comment 10

[Marcus Cavanaugh [:mcav]]

Landed in master:

https://github.com/mozilla-b2g/gaia/commit/6901d4f612fdbb3634f2867a1f6e1924e60f426e

Thanks for your patch!

Comment 11

[Sukant Garg [:gargsms]]

(In reply to Marcus Cavanaugh [:mcav] <[e-mail]> from comment #9)
> Comment on attachment 8369157 [details] [diff] [review]
> Comment #5 taken into account
> 
> r+, though the diff is backwards (minus lines instead of plus lines). Will
> land after travis passes.

Oops, sorry for that. It was my first ever actual bug fix. :)