Drop support for MSThemeCompatible

VERIFIED FIXED in Firefox 55

Status

()

defect
VERIFIED FIXED
5 years ago
2 months ago

People

(Reporter: fb+mozdev, Assigned: mats)

Tracking

({dev-doc-complete, site-compat})

Trunk
mozilla56
Points:
---
Dependency tree / graph
Bug Flags:
qe-verify -

Firefox Tracking Flags

(firefox55 verified, firefox56 verified)

Details

Attachments

(1 attachment)

Reporter

Description

5 years ago
meta[http-equiv="MSThemeCompatible"] is non-standard and produces bugs.
Reporter

Updated

5 years ago
Duplicate of this bug: 486551
Reporter

Updated

5 years ago
Duplicate of this bug: 484172
Reporter

Updated

5 years ago
No longer blocks: 484172, 486551
See Also: → 420363, 464876

Updated

3 years ago
Component: Widget → DOM
Assignee

Comment 3

2 years ago
It seems that neither Chrome, Safari or Edge support this feature.
Assignee: nobody → mats
Comment on attachment 8878271 [details] [diff] [review]
Remove support for <meta http-equiv="msthemecompatible" content="no">

Review of attachment 8878271 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/base/nsContentSink.cpp
@@ -345,5 @@
> -    nsAutoString value(aValue);
> -    if (value.LowerCaseEqualsLiteral("no")) {
> -      nsIPresShell* shell = mDocument->GetShell();
> -      if (shell) {
> -        shell->DisableThemeSupport();

Do we still need nsIPresShell::DisableThemeSupport? Apparently this is the only caller [1] and nsIPresShell is not scriptable.

We could also remove nsGkAtoms::msthemecompatible.

[1] https://dxr.mozilla.org/mozilla-central/search?q=DisableThemeSupport
Comment on attachment 8878271 [details] [diff] [review]
Remove support for <meta http-equiv="msthemecompatible" content="no">

Please also remove nsIPresShell::mIsThemeSupportDisabled.

r=dbaron with that
Attachment #8878271 - Flags: review?(dbaron) → review+
Assignee

Comment 8

2 years ago
Good point, I removed the PresShell bits too.

Comment 9

2 years ago
Pushed by mpalmgren@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/47143d875634
Remove support for <meta http-equiv="msthemecompatible" content="no">.  r=dbaron

Comment 10

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/47143d875634
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
Assignee

Comment 11

2 years ago
Comment on attachment 8878271 [details] [diff] [review]
Remove support for <meta http-equiv="msthemecompatible" content="no">

Approval Request Comment
[Feature/Bug causing the regression]: The culprit is the "msthemecompatible" feature as such, but it was mostly harmless until bug 605985 landed which made checkbox/radio controls invisible when "msthemecompatible" is requested
[User impact if declined]: invisible checkbox/radio controls (I suspect that "msthemecompatible" is very rare on the web though)
[Is this code covered by automated tests?]:no
[Has the fix been verified in Nightly?]:not yet
[Needs manual test from QE? If yes, steps to reproduce]: sure, there's a testcase in bug 1373417
[List of other uplifts needed for the feature/fix]:none
[Is the change risky?]:no
[Why is the change risky/not risky?]:it removes a feature that none of the other major browsers support, and the patch is fairly trivial
[String changes made/needed]:none
Attachment #8878271 - Flags: approval-mozilla-beta?
Comment on attachment 8878271 [details] [diff] [review]
Remove support for <meta http-equiv="msthemecompatible" content="no">

sounds sensible enough, beta55+

Should be in 55.0b3
Attachment #8878271 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Already verified in bug 1373417.
Flags: qe-verify-
As mentioned in Bug 1373417, the patch requires an uplift request for the release channel so the bug will be fixed with 54.0.1.
Flags: needinfo?(mats)
Assignee

Comment 17

2 years ago
Not my decision to make.
Flags: needinfo?(mats)
(In reply to Mats Palmgren (:mats) from comment #17)
> Not my decision to make.

Then who is making the decision? I thought developers (you in this case) make an uplift request and release drivers make a decision. No?
Flags: needinfo?(mats)
(In reply to Masatoshi Kimura [:emk] from comment #18)
> Then who is making the decision? I thought developers (you in this case)
> make an uplift request and release drivers make a decision. No?

Believe so.
Assignee

Comment 20

2 years ago
I generally don't request uplift to the _release channel_ unless it's for
a major web-compat or crash or security issue.  This bug doesn't fit that
criteria IMO.
Flags: needinfo?(mats)
I've added a note to the Fx55 rel notes to cover this:

https://developer.mozilla.org/en-US/Firefox/Releases/55#HTML_2

I didn't make any changes to the ref docs, as we never mentioned this value in the first place.
Component: DOM → DOM: Core & HTML
Product: Core → Core
You need to log in before you can comment on or make changes to this bug.