966449 - ctrl-backspace in compose window doesn't do anything

Status: RESOLVED FIXED

(Thunderbird :: Message Compose Window, defect)

Description

[Jonathan Kamens]

In thunderbird 24.2 on my Fedora 20 x86_64 box, ctrl-backspace in a compose window deletes the previous word as it should.

In thunderbird trunk updated from Hg yesterday, ctrl-backspace in a compose window does nothing.

Comment 1

[iamjayakumars]

OMG!

Its opposite in MAC OS X 10.9.1

CMD + DEL - Must delete the entire line

Works fine in Thunderbird Daily(29.01), not working in Thunderbird Stable (24.2.0)


Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:29.0) Gecko/20100101 Thunderbird/29.0a1

Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:24.0) Gecko/20100101 Thunderbird/24.2.0

Comment 2

[Alice0775 White]

Regression window(c-c)
Good:
http://hg.mozilla.org/mozilla-central/rev/8f4ecbf938cd
http://hg.mozilla.org/comm-central/rev/bcca0f06c29a
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:29.0) Gecko/20100101 Thunderbird/29.0a1 ID:20140122030457
Bad:
http://hg.mozilla.org/mozilla-central/rev/1a75d37e1e39
http://hg.mozilla.org/comm-central/rev/bdb58bfe1041
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:29.0) Gecko/20100101 Thunderbird/29.0a1 ID:20140123030202
Pushlog:
http://hg.mozilla.org/comm-central/pushloghtml?fromchange=bcca0f06c29a&tochange=bdb58bfe1041
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=8f4ecbf938cd&tochange=1a75d37e1e39




Steps To Reproduce in Firefox:
1. Open http://www-archive.mozilla.org/editor/midasdemo/
2. Type something
3. Ctrl + backspace

Actual Results:
Nothing happens

Expected Results:
A previous word should be deleted



Regression window(m-i)
Good:
http://hg.mozilla.org/integration/mozilla-inbound/rev/9ba11d59bf3f
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:29.0) Gecko/20100101 Firefox/29.0 ID:20140122190708
Bad:
http://hg.mozilla.org/integration/mozilla-inbound/rev/30fefae6278f
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:29.0) Gecko/20100101 Firefox/29.0 ID:20140122191908
Pushlog:
http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=9ba11d59bf3f&tochange=30fefae6278f
Regressed by:
30fefae6278f	Ehsan Akhgari — Bug 289384 - Run the native key binding handlers from nsEditorEventListener; r=Neil,masayuki

Comment 3

[(no longer active)]

This seems like a dupe of the core bug 966552.  I have a patch there up for review.

Comment 4

[(no longer active)]

Jonathan, can you please verify that this is indeed fixed now?

Comment 5

[Jonathan Kamens]

Yes, seems to be working from trunk today.

Comment 6

[Jonathan Kamens]

Scratch that, it's NOT fixed. I see very strange behavior now (trunk checked out just a few minutes ago).

If I open a new message composition window and click in the main text area of the window immediately, before entering anything in the header, then ctrl-backspace works.

However, if I use the TAB key to move from the To field to the Subject and from the Subject field to the main text area, then ctrl-backspace then does NOT work in the main text area.

If I then click in the main text area (the one that I'm already in!), ctrl-backspace starts working again.

Comment 7

[[e-mail]]

When you click on the message body frame, it becomes the focused window and there is no focused element. When you tab from the subject field, this actually calls SetMsgBodyFrameFocus() which tries to advance the focus into the message body frame, however this ends up setting the focus to the frame's document element. Is this confusing the native key binding code because it's outside of the editable area?

Comment 8

[(no longer active)]

This might be half a dupe of bug 966552 and half a dupe of bug 966155.  The latter's patch was just pushed to inbound.  Please retest in the next nightly/daily.

Comment 9

[Jonathan Kamens]

Yes, seems to be fixed. Now if only bug 973266 were fixed...

Comment 10

[(no longer active)]

(In reply to comment #9)
> Yes, seems to be fixed. Now if only bug 973266 were fixed...

Thanks, but that bug is quite unrelated to this one.