966552 - Ctrl+Backspace no longer deletes the previous word in the Gmail compose window

Status: RESOLVED FIXED

(Core :: DOM: Editor, defect)

Description

[Jared Wein [:jaws] (please needinfo? me)]

STR:
Log in to Gmail and start to compose a new message
Type a few words
Press ctrl+backspace to delete the last word

ER:
The last word is deleted.

AR:
The cursor doesn't move.

This was broken by the patch in bug 289384, found using mozregression (it is the most likely out of http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=b9d9649e7ec0&tochange=9d650c07b547).

Comment 1

[Alice0775 White]

Steps To Reproduce:
1. Open http://www-archive.mozilla.org/editor/midasdemo/
2. Type something
3. Ctrl + backspace

Actual Results:
Nothing happens

Expected Results:
A previous word should be deleted

Comment 3

[[e-mail]]

I see what the problem is on Windows; the IsHTMLEditableFieldFocused() check fails for design mode documents, as they don't have a focused element. (Unfortunately I only thought to test the patch for bug 289384 on contenteditable regions.) As for bug 966449, the test case works for me on Linux as the native keybindings apply in that case.

Comment 4

[Roman R.]

Because some of us use Firefox for real work, I request the patch be reversed quickly while you look for a complete solution to this problem.

Comment 6

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

(In reply to [e-mail] from comment #3)
> I see what the problem is on Windows; the IsHTMLEditableFieldFocused() check
> fails for design mode documents, as they don't have a focused element.
> (Unfortunately I only thought to test the patch for bug 289384 on
> contenteditable regions.) As for bug 966449, the test case works for me on
> Linux as the native keybindings apply in that case.

Then, when the document node is editable, it should check if the window has focus. See http://mxr.mozilla.org/mozilla-central/source/editor/libeditor/html/nsHTMLEditor.cpp#5112

Comment 7

[(no longer active)]

Attachment: Ensure that we pick the editor XBL window key handler for designMode documents no matter where the focus is; r=Neil

Comment 9

[[e-mail]]

Comment on attachment 8373418 [details] [diff] [review]
Ensure that we pick the editor XBL window key handler for designMode documents no matter where the focus is; r=Neil

r=me on the code, although I don't understand the test, as I was expecting you to have two words and check that Ctrl+Bksp deletes one of them.

Comment 10

[(no longer active)]

The test puts the caret here: te|st and then does a Ctrl+Backspace which is supposed to delete the preceding word, hence leave st in the DOM.

http://hg.mozilla.org/integration/mozilla-inbound/rev/a1b01f4a6d6a

Comment 11

[(no longer active)]

Comment on attachment 8373418 [details] [diff] [review]
Ensure that we pick the editor XBL window key handler for designMode documents no matter where the focus is; r=Neil

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 289384
User impact if declined: comment 0
Testing completed (on m-c, etc.): locally
Risk to taking this patch (and alternatives if risky): minimal
String or IDL/UUID changes made by this patch: none

Comment 13

[Sylvestre Ledru [:Sylvestre]]

Please land it on m-c before requesting the uplift :)

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/a1b01f4a6d6a

Comment 15

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/d5609fd7f799

Comment 16

[(no longer active)]

This should still be tracked for Firefox 30.