Closed
Bug 966552
Opened 10 years ago
Closed 10 years ago
Ctrl+Backspace no longer deletes the previous word in the Gmail compose window
Categories
(Core :: DOM: Editor, defect)
Tracking
()
RESOLVED
FIXED
mozilla30
Tracking | Status | |
---|---|---|
firefox28 | --- | unaffected |
firefox29 | + | fixed |
firefox30 | + | fixed |
People
(Reporter: jaws, Assigned: ehsan.akhgari)
References
Details
(Keywords: regression)
Attachments
(1 file)
STR: Log in to Gmail and start to compose a new message Type a few words Press ctrl+backspace to delete the last word ER: The last word is deleted. AR: The cursor doesn't move. This was broken by the patch in bug 289384, found using mozregression (it is the most likely out of http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=b9d9649e7ec0&tochange=9d650c07b547).
Reporter | ||
Updated•10 years ago
|
tracking-firefox29:
--- → ?
Reporter | ||
Updated•10 years ago
|
status-firefox28:
--- → unaffected
status-firefox29:
--- → affected
Reporter | ||
Updated•10 years ago
|
Keywords: regression
Version: Trunk → 29 Branch
Comment 1•10 years ago
|
||
Steps To Reproduce: 1. Open http://www-archive.mozilla.org/editor/midasdemo/ 2. Type something 3. Ctrl + backspace Actual Results: Nothing happens Expected Results: A previous word should be deleted
OS: Windows 7 → All
Comment 3•10 years ago
|
||
I see what the problem is on Windows; the IsHTMLEditableFieldFocused() check fails for design mode documents, as they don't have a focused element. (Unfortunately I only thought to test the patch for bug 289384 on contenteditable regions.) As for bug 966449, the test case works for me on Linux as the native keybindings apply in that case.
Because some of us use Firefox for real work, I request the patch be reversed quickly while you look for a complete solution to this problem.
Updated•10 years ago
|
Comment 6•10 years ago
|
||
(In reply to neil@parkwaycc.co.uk from comment #3) > I see what the problem is on Windows; the IsHTMLEditableFieldFocused() check > fails for design mode documents, as they don't have a focused element. > (Unfortunately I only thought to test the patch for bug 289384 on > contenteditable regions.) As for bug 966449, the test case works for me on > Linux as the native keybindings apply in that case. Then, when the document node is editable, it should check if the window has focus. See http://mxr.mozilla.org/mozilla-central/source/editor/libeditor/html/nsHTMLEditor.cpp#5112
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → ehsan
Assignee | ||
Comment 7•10 years ago
|
||
Assignee | ||
Updated•10 years ago
|
Attachment #8373418 -
Flags: review?(neil)
Assignee | ||
Updated•10 years ago
|
status-firefox30:
--- → affected
tracking-firefox30:
--- → ?
Comment 9•10 years ago
|
||
Comment on attachment 8373418 [details] [diff] [review] Ensure that we pick the editor XBL window key handler for designMode documents no matter where the focus is; r=Neil r=me on the code, although I don't understand the test, as I was expecting you to have two words and check that Ctrl+Bksp deletes one of them.
Attachment #8373418 -
Flags: review?(neil) → review+
Assignee | ||
Comment 10•10 years ago
|
||
The test puts the caret here: te|st and then does a Ctrl+Backspace which is supposed to delete the preceding word, hence leave st in the DOM. http://hg.mozilla.org/integration/mozilla-inbound/rev/a1b01f4a6d6a
Assignee | ||
Comment 11•10 years ago
|
||
Comment on attachment 8373418 [details] [diff] [review] Ensure that we pick the editor XBL window key handler for designMode documents no matter where the focus is; r=Neil [Approval Request Comment] Bug caused by (feature/regressing bug #): bug 289384 User impact if declined: comment 0 Testing completed (on m-c, etc.): locally Risk to taking this patch (and alternatives if risky): minimal String or IDL/UUID changes made by this patch: none
Attachment #8373418 -
Flags: approval-mozilla-aurora?
Comment 13•10 years ago
|
||
Please land it on m-c before requesting the uplift :)
Comment 14•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/a1b01f4a6d6a
Status: NEW → RESOLVED
Closed: 10 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
Updated•10 years ago
|
Attachment #8373418 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Assignee | ||
Updated•10 years ago
|
Keywords: checkin-needed
Comment 15•10 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/d5609fd7f799
Keywords: checkin-needed
Updated•10 years ago
|
tracking-firefox30:
? → ---
Assignee | ||
Comment 16•10 years ago
|
||
This should still be tracked for Firefox 30.
tracking-firefox30:
--- → ?
Updated•10 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•