966678 - Australis' customize mode's "Restore defaults" button disabled styling is broken

Status: VERIFIED FIXED

(Firefox :: Theme, defect)

Description

[:Gijs (he/him)]

I probably broke this in bug 940093. See also bug 940009.

Comment 1

[:Gijs (he/him)]

Steven, would it be possible to get a quick mockup of how this button is meant to look when you're in the default state?

Comment 2

[Stephen Horlander [:shorlander]]

Attachment: Restore Defaults — Disabled

If we just keep the default styling but set the opacity to .5 it should work.

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Patch

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

https://hg.mozilla.org/integration/fx-team/rev/db98e96431ba

Comment 5

[:Gijs (he/him)]

https://hg.mozilla.org/mozilla-central/rev/db98e96431ba

Comment 6

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8376427 [details] [diff] [review]
Patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 940093
User impact if declined: restore defaults' button isn't obviously disabled
Testing completed (on m-c, etc.): on m-c for a while now
Risk to taking this patch (and alternatives if risky): none
String or IDL/UUID changes made by this patch: no

Comment 7

[Jared Wein [:jaws] (please needinfo? me)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/38fd05aec765

Comment 8

[Cornel Ionce [:noni] [Hubs QA]]

Mozilla/5.0 (Windows NT 5.2; WOW64; rv:29.0) Gecko/20100101 Firefox/29.0
Build ID: 20140318013849
Mozilla/5.0 (Windows NT 5.2; WOW64; rv:30.0) Gecko/20100101 Firefox/30.0
Build ID: 20140320004001

Verified on Windows XP 64bit. The "Restore defaults" button disabled styling is now implemented accordingly the design.