966775 - Decouple bottom-bar target area from home screen gesture

Status: RESOLVED INVALID

(Firefox OS Graveyard :: Gaia::System::Window Mgmt, defect)

Description

[Michael Henretty [:mikehenrty][:mhenretty]]

Right now the target area (touch listener) for home screen gestures is hidden and displayed in the home screen gesture code. Now the new notification tray will need to use this target area as well, so we have to make sure the home screen gesture code does not modify that area.

Comment 1

[Michael Henretty [:mikehenrty][:mhenretty]]

Attachment: Make home gesture code never hide bottom-bar

Hi Tim, could you (or someone familiar with the home gesture code) take a look at this? I want to reuse the bottom bar target div for the new notification tray. If you think this is not the best way forward, I'm open for discussion. Interaction between home gesture, and new notification UX will be a little tricky.

Comment 2

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8369220 [details] [review]
Make home gesture code never hide bottom-bar

George, could you help reviewing this patch? Thanks!

Comment 3

[(Inactive after June) George Duan [:gduan] [:喬智]]

Hi Michael,
I don't know how you will implement the new notification tray with the bottom bar.
Basically, this patch has two pbs , 
1. when utility tray shows, it cannot be closed since bottom bar will block the touch area.
2. unit tests failed.

Comment 4

[Michael Henretty [:mikehenrty][:mhenretty]]

Yup, my bad. I sent PR promptly forgot to follow up. The idea is we want to re-use the bottom bar for swipe gestures for both the homescreen gesture and the new notification tray (which is being moved to the bottom). Since they use the same exact gesture, getting the interaction right between the two is important. In any case, I will fix the two (related) issues you mention and reflag this PR.

Comment 5

[Michael Henretty [:mikehenrty][:mhenretty]]

This bug is no longer needed since the notification spec has changed and the toaster will not be located at the bottom of the screen.