Closed Bug 968087 Opened 6 years ago Closed 6 years ago

[Cost Control] Refactor and simplify Cost Control start-up process.

Categories

(Firefox OS Graveyard :: Gaia::Cost Control, defect)

x86_64
Linux
defect
Not set

Tracking

(b2g-v2.0 fixed)

RESOLVED FIXED
2.0 S1 (9may)
Tracking Status
b2g-v2.0 --- fixed

People

(Reporter: salva, Assigned: mai)

References

Details

Attachments

(1 file)

46 bytes, text/x-github-pull-request
salva
: review+
Details | Review
DSDS scenario has added a lot of complexity to the Cost Control start-up process and it must be reviewed to improve maintainability and reduce technical debt.

This should cover:
 - A way for discern between SIM modes in order to provide the specific UI (or UI configuration) for each of them.
 - A review of settings module to include how to properly load all the SIM-related stuff (specific settings, iccinfo, data / mobile configurations...).
 - We should reconsider bug 834334.
Bug 834334 is not part of the start-up process but includes its own start-up so it is somehow related.
Depends on: 991831
Attached file patch v1.0
Salva, could you review the patch?
Regards
Attachment #8412380 - Flags: review?(salva)
Blocks: 977077
Comment on attachment 8412380 [details] [review]
patch v1.0

Nice improvements and more simple start-up. Thank you very much, Mai. Please attend the nits I leave to you on GitHub.
Attachment #8412380 - Flags: review?(salva) → review+
Master: b60317430513fd1cc7262ffccc531a42c20002f0
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2.0 S1 (9may)
Depends on: 1007667
You need to log in before you can comment on or make changes to this bug.