968435 - "Now Syncing" doorhanger displays over other applications

Status: VERIFIED FIXED

(Firefox :: Sync, defect)

Description

[Richard Newman [:rnewman]]

Firefox has a long-standing problem with doing this all the damn time -- e.g., with tooltips on links (Bug 148624).

Open Firefox after setting up FxA Sync. Switch to terminal. Wait a minute. See doorhanger on top of my terminal.

Comment 1

[Mark Hammond [:markh] [:mhammond] - PTO until April 20]

Windows too.

Comment 2

[Mark Hammond [:markh] [:mhammond] - PTO until April 20]

Attachment: Remove 'level' attribute from sync panels

The problem is that the panels have an attribute level="top", which means on top of windows from other applications.  level="parent" is the behaviour we want, but https://developer.mozilla.org/en-US/docs/XUL/panel cautions about using this - it says we should just rely on the default.  This means that in theory, Linux will still display on top of other windows, but presumably the default for that platform exists for a reason - so this patch just removes the attribute entirely.  This fixes the problem for me on Windows, but I've not tested other platforms.

Comment 3

[Tim Taubert [:ttaubert] (inactive)]

Comment on attachment 8375299 [details] [diff] [review]
Remove 'level' attribute from sync panels

Review of attachment 8375299 [details] [diff] [review]:
-----------------------------------------------------------------

Yeah, the Australis team did the same recently, iirc.

Comment 5

[Mark Hammond [:markh] [:mhammond] - PTO until April 20]

https://hg.mozilla.org/integration/fx-team/rev/a39438d36c9a

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/a39438d36c9a

Comment 7

[Mark Hammond [:markh] [:mhammond] - PTO until April 20]

Comment on attachment 8375299 [details] [diff] [review]
Remove 'level' attribute from sync panels

[Approval Request Comment]
Bug caused by (feature/regressing bug #): FxA sync
User impact if declined: Sync panel may appear over other windows
Testing completed (on m-c, etc.): Landed on MC
Risk to taking this patch (and alternatives if risky): Low
String or IDL/UUID changes made by this patch: None

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/587656ee1125

Comment 10

[Tracy Walker [:tracy]]

Verified the door hanger is no longer on top on latest Nightly and Aurora.  

However, since clicking anywhere dismisses the dialog, it is not seen. 

Well, sort of.

I used a terminal with a small amount of transparency to reproduce rnewmans original steps.  I could see the door hanger through the terminal window.  But, when I clicked the terminal window to move it to reveal the door hanger, the door hanger flashed on top for an instant then disappeared.  

Please advise if current behavior is expected, given click anywhere to dismiss.

Comment 11

[Mark Hammond [:markh] [:mhammond] - PTO until April 20]

(In reply to [:tracy] Tracy Walker - QA Mentor from comment #10)
> Please advise if current behavior is expected, given click anywhere to
> dismiss.

It is currently expected, although bug 966098 exists to come up with something better.