968550 - [B2G][Settings][FDN] After adding a number to FDN and entering the wrong SIM2 pin the "The PIN2 code is incorrect." message does not appear.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: RIL, defect)

Description

[Lionel Mauritson]

Attachment: 2014-02-05-13-56-52.png

Description:
If the user goes to Settings -> Call Settings -> Fixed dialing numbers, and then adds a number to the list, a message asking for the PIN2 code will appear. If the user enters the wrong code there will be no notification, and when they have entered the wrong PIN2 several times even the correct code will no longer be accepted. The error string should read: "The PIN2 code is incorrect." or the equivalent for the current language, the same as it does in other areas where the PIN2 code is asked for. 
This happens in all languages.

Repro Steps:
1) Update a Buri to BuildID: 20140205004002
2) Go to Settings -> Call Settings -> Fixed dialing numbers
3) Tap Authorized numbers, then add a new name and number and tap done.
4) Enter an incorrect PIN2 code.
>> There will be no notification that there was an error
5) Enter an incorrect PIN2 code 5 more times.
6) Try to enter the correct PIN2
>> Nothing happens
7) Back out of the screen using the back button
8) Tap on the switch to turn FDN on or off.
>> The user will be asked to enter the PUK2 code.

Actual:
No error message appears when entering an incorrect SIM2. After enough tries even the correct SIM2 will no longer work.
The user can become locked out of their device.

Expected:
An error message appears when the entered SIM2 is incorrect: "The PIN2 code is incorrect."

1.3 Environmental Variables:
Device: Buri 1.3 MOZ
BuildID: 20140205004002
Gaia: 3405c205cfb5625073b9db1e12ed5d173bdcc78c
Gecko: 2c7f237ba88b
Version: 28.0
Firmware Version: v1.2-device.cfg

Notes: Does NOT occur in 1.2

Repro frequency: 100%

See: http://youtu.be/Jww9_W08sLc and attached image

Comment 1

[Jason Smith [:jsmith]]

I need specific details of what is happening on 1.2 here. Can we get an explanation of the behavior seen on 1.2?

Comment 2

[Ross Kuhlman ([e-mail])]

This feature is not currently functional in v1.2. This has been bugged separately.
https://bugzilla.mozilla.org/show_bug.cgi?id=972103

Comment 3

[Ross Kuhlman ([e-mail])]

Quick description of events in 1.2:
When prompted to enter a PIN2, nothing happens if the user enters the PIN2 correctly. The device will not navigate from the 'Enter PIN2' page, and the number is not added to the authorized number list.
If the user enters an incorrect PIN2, then they will be returned to the list of authorized numbers, and the new number has not been added to the list. The user is not alerted that the PIN has been entered incorrectly.

Comment 4

[Jason Smith [:jsmith]]

What happens if you test this with an older Buri base image with latest 1.3 gaia/gecko on top?

Comment 5

[Jason Smith [:jsmith]]

(In reply to Jason Smith [:jsmith] from comment #4)
> What happens if you test this with an older Buri base image with latest 1.3
> gaia/gecko on top?

I'm going to flag bug 972103 with this request.

Comment 6

[Enpei]

Fugu also has this bug.

Fugu
Gaia      26e8a950f3ac703310ee8efcb741ff2418e9d190
Gecko     0d2a915d0b66dba35ee9936bdeafef820a5c3357
BuildID   20140217152248
Version   28.0

Comment 7

[Jason Smith [:jsmith]]

Alright, so this isn't related to the base image. Based on the video here, this looks like busted UX with no user feedback. So nominating.

Comment 8

[Preeti Raghunath(:Preeti)]

Can we please get a regression window? Would like to explore backout options

Comment 9

[Jason Smith [:jsmith]]

We've already know we can block on this, but let's get that window.

Comment 10

[J Zimbrick]

Last Working Environmental Variables:
Device: Buri
BuildID: 20131205040201
Gaia: 1dd0e5c644b4c677a4e8fa02e50d52136db489d9
Gecko: 725c36b5de1a
Version: 28.0a1
Base Image: V1.2-device.cfg

First Broken Environmental Variables:
Device: Buri 
BuildID: 20131206040203
Gaia: 8fca2ca67e8a6022fe6ed8cb576e5d59dfb5237f
Gecko: 1401e4b394ad
Version: 28.0a1
Base Image: V1.2-device.cfg

Last Working Gaia/First Broken Gecko: Issue DOES Reproduce
Gaia: 1dd0e5c644b4c677a4e8fa02e50d52136db489d9
Gecko: 1401e4b394ad

First Broken Gaia/Last Working Gecko: Issue Does NOT Reproduce
Gaia: 8fca2ca67e8a6022fe6ed8cb576e5d59dfb5237f
Gecko: 725c36b5de1a

Comment 11

[Jason Smith [:jsmith]]

So that concludes this is a gecko bug, but I need a logcat before I can diagnose what's failing here.

Comment 12

[Jason Smith [:jsmith]]

http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=725c36b5de1a&tochange=1401e4b394ad

Comment 13

[J Zimbrick]

Attachment: log.txt

Logcat attached.

The "RIL Worker[0]: RIL Worker errorundefined" message is displayed in logcat when tapping the done button when attempting to enter the PIN2.

Comment 14

[:gerard-majax]

I will try to see if I can help on this one.

Comment 15

[:gerard-majax]

Okay, so I think I'm reproducing it:
 - Blocking SIM PIN2
 - Taping on FDN, trying to add a number
 - When validating the new FDN entry, I'm getting the SIM PIN2 interface.

This is wrong:
 - my SIM PIN2 is already locked, it should be asking for PUK2
 - when tapping Done on the top right corner, nothing happens.

Comment 16

[:gerard-majax]

Lionel, can you confirm my previous message correctly describes the issue you reported ?

Comment 17

[Fabien Cazenave [:kaze]]

Following our discussion on IRC: stealing, so that Alexandre can focus on his other 1.3+ blocker.

Comment 18

[:gerard-majax]

After looking at the code, I think that we are just showing the SIM PIN UI without properly checking the state of the SIM card.

Comment 19

[Lionel Mauritson]

(In reply to Alexandre LISSY :gerard-majax from comment #15)
> Okay, so I think I'm reproducing it:
>  - Blocking SIM PIN2
>  - Taping on FDN, trying to add a number
>  - When validating the new FDN entry, I'm getting the SIM PIN2 interface.
> 
> This is wrong:
>  - my SIM PIN2 is already locked, it should be asking for PUK2
>  - when tapping Done on the top right corner, nothing happens.

This is correct, though the SIM PIN2 will be accepted if entered correctly. The SIM PIN2 must be entered incorrectly for the issue to occur.

Comment 20

[Fabien Cazenave [:kaze]]

There is a bug for sure, but I’m experiencing something else with my Inari + Orange SIM card:
 • my SIM PIN2 has been refused or ignored a few times when trying to add a new FDN contact (not expected);
 • now PIN2 is locked and I get the PUK2 message (expected);
 • the PUK2 code does not seem to work (not expected… unless this PUK2 code is incorrect — checking with the telco).

Now trying with my Free Mobile SIM card and with an Android device to compare.

Comment 21

[Fabien Cazenave [:kaze]]

Turns out my SIM card was really locked and my PUK2 code was incorrect. Once the PIN2 is locked, if the device is restarted it becomes impossible to unlock it because the SIM card is never detected again — this might be related to bug 976497.

So I confirm that there’s no error message when the PIN2 is wrong. This should be tested by the following function in simcard_dialog.js:

  function updateFdnContact() {
    var req = icc.updateContact('fdn', _fdnContactInfo, pinInput.value);

    req.onsuccess = function onsuccess() {
      _onsuccess(_fdnContactInfo);
      close();
    };

    req.onerror = function onerror(e) {
      var wrongPin2 = /IncorrectPassword/.test(req.error.name);
      if (wrongPin2) { // TODO: count retries (not supported by the platform)
        _action = initUI('get_pin2');
        showMessage('fdnErrorMsg');
        pinInput.value = '';
        pinInput.focus();
      } else {
        _oncancel(_fdnContactInfo);
        close();
        throw new Error('Could not edit FDN contact on SIM card', e);
      }
    };
  }

When the PIN2 code is correct, `req.onsuccess' is fired (as expected).
When the PIN2 code is incorrect, `req.onerror' is not fired (unexpected) — and neither is `req.onsuccess'.

This might be a Gecko regression. Investigating.

Comment 22

[Fabien Cazenave [:kaze]]

OK, I missed the 'RIL Worker errorundefined' story. Please kill me. :-/

Comment 23

[Anthony Ricaud (:rik)]

Yeah I also missed that it was already identified as a Gecko issue in comment 10 and 11. Kaze will continue to investigate and may come up with a fix.

Hsin-Yi: If there is no proposed patch when you read this, can anyone from RIL look at this? It's a 1.3+ blocker so prioritise accordingly.

Comment 24

[Fabien Cazenave [:kaze]]

Attachment: patch

I think this is an old regression caused by bug 944725. This fix works fine on my device.

Comment 25

[Fabien Cazenave [:kaze]]

Attachment: patch

Here’s a better and simpler patch: in `processICCIOError', it makes no sense to default to a global `onerror' function if no error callback is passed. We already have a good debug message anyway.

I don’t really understand what the `onmessage()' and `onerror()' functions are expected to do (see last lines of ril_worker.js), but that could be addressed with a less urgent patch. :-)

Comment 26

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Comment on attachment 8382421 [details] [diff] [review]
patch

Review of attachment 8382421 [details] [diff] [review]:
-----------------------------------------------------------------

my bad, sorry.

Comment 27

[Fabien Cazenave [:kaze]]

Thanks Yoshi, can you land this patch please? I guess it has to land on central + b2g28?

Comment 28

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Patch. v1.1

convert patch to Unix format, and add r=me.

Comment 29

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

https://hg.mozilla.org/integration/b2g-inbound/rev/bfc87261fa2a

Comment 30

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: (for b2g28_v1_3) Patch

This is the patch for v1.3
Let me run try server first then request for approval_b2g28_v1.3?

Comment 31

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

try result for v1.3 
https://tbpl.mozilla.org/?tree=Try&rev=58262da8916f

Comment 32

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Comment on attachment 8382835 [details] [diff] [review]
(for b2g28_v1_3) Patch

NOTE: This flag is now for security issues only. Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 944725
User impact if declined: User cannot get the error message when the PIN2 is incorrect.
Testing completed: https://tbpl.mozilla.org/?tree=Try&rev=58262da8916f
Risk to taking this patch (and alternatives if risky): low. It's just a typo in the first place.

String or UUID changes made by this patch: no

Comment 33

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/bfc87261fa2a

Comment 34

[John Hammink]

Gaia      9422aca1931ba6c68784f9e80bb1b6a7fcfd92e3
Gecko     https://hg.mozilla.org/mozilla-central/rev/58eca03214a6
BuildID   20140228040203
Version   30.0a1
ro.build.version.incremental=324
ro.build.date=Thu Dec 19 14:04:55 CST 2013

I see that I'm getting now the messages that SIM2 PIN is incorrect, and after the correct number of tries, SIM PIN is locked.

After backing out and going back into Call Settings => FDN I am prompted for the SIM Pin2 a second time.  Entering that incorrectly I get a screen announcing (correctly, I believe) that THe SIM Card is locked.  It also prompts for the PUK2 code and asks me to create a PIN2.

Comment 35

[Jason Smith [:jsmith]]

(In reply to John Hammink from comment #34)
> Gaia      9422aca1931ba6c68784f9e80bb1b6a7fcfd92e3
> Gecko     https://hg.mozilla.org/mozilla-central/rev/58eca03214a6
> BuildID   20140228040203
> Version   30.0a1
> ro.build.version.incremental=324
> ro.build.date=Thu Dec 19 14:04:55 CST 2013
> 
> I see that I'm getting now the messages that SIM2 PIN is incorrect, and
> after the correct number of tries, SIM PIN is locked.
> 
> After backing out and going back into Call Settings => FDN I am prompted for
> the SIM Pin2 a second time.  Entering that incorrectly I get a screen
> announcing (correctly, I believe) that THe SIM Card is locked.  It also
> prompts for the PUK2 code and asks me to create a PIN2.

We need to verify that the correct PIN code can eventually work here before declaring this is verified.

Comment 36

[Peter Bylenga [:PBylenga]]

Verified that the Sim PIN2 can be successfully entered to enable & disable FDN.

Sim PIN2 works on first try
Sim PIN2 works when 2 tries left
Sim PIN2 works on last try

This was done on v1.4

v1.4 Environmental Variables:
Device: Buri v1.4 MOZ
BuildID: 20140228040203
Gaia: 9422aca1931ba6c68784f9e80bb1b6a7fcfd92e3
Gecko: 58eca03214a6
Version: 30.0a1
Firmware Version: v1.2-device.cfg

Comment 37

[Jason Smith [:jsmith]]

(In reply to Peter Bylenga from comment #36)
> Verified that the Sim PIN2 can be successfully entered to enable & disable
> FDN.
> 
> Sim PIN2 works on first try
> Sim PIN2 works when 2 tries left
> Sim PIN2 works on last try
> 
> This was done on v1.4
> 
> v1.4 Environmental Variables:
> Device: Buri v1.4 MOZ
> BuildID: 20140228040203
> Gaia: 9422aca1931ba6c68784f9e80bb1b6a7fcfd92e3
> Gecko: 58eca03214a6
> Version: 30.0a1
> Firmware Version: v1.2-device.cfg

Fixing the flags...

Comment 38

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g28_v1_3/rev/be3a31d33318