968592 - Use expired tokens for info/collections fetches

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: Android Sync, defect, P5)

Description

[Richard Newman [:rnewman]]

Client implementation for Bug 960878 -- we can avoid the overhead of a new token fetch if we have no local data to upload for the syncing engines, or are doing a download-only sync, and just want to check if there's anything new on the server.

This will go a long way toward making short-circuit syncs cheaper, at the cost of increasing client complexity.

Comment 1

[Richard Newman [:rnewman]]

This won't make 29.

Comment 2

[Nick Alexander :nalexander [he/him]]

Some work in progress commits that test that the Sync endpoints are doing the right thing are at:

https://github.com/mozilla-services/android-sync/tree/nalexander/bug-968592-expired-tokens/

Of course, the endpoints don't accept expired tokens yet, so this fails.  But the tests are useful, and the old data might be useful too.

Comment 3

[Nick Alexander :nalexander [he/him]]

See also Bug 985007, which should allow to set the token duration in test code.

Comment 4

[Firefox Bug Husbandry Bot]

Re-triaging per https://bugzilla.mozilla.org/show_bug.cgi?id=1473195

Needinfo :susheel if you think this bug should be re-triaged.

Comment 5

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.