Closed Bug 968675 Opened 6 years ago Closed 6 years ago
Add Makefile for communications
46 bytes, text/x-github-pull-request
|Details | Review|
add a makefile for communications and migrate communications related code from applications-data.js, webapp-manifest.js and webapp-optimize.js. we should build this app in build_stage because code snippet in webapp-manifest.js modify manifest.webapp of communications, or we will see some modification in git for each make
Assignee: nobody → yurenju.mozilla
WIP here, https://github.com/yurenju/gaia/commit/308a51fdf78840e2c576c67ab14f03c358d3b43f still need integration tests and addressing some nits.
Hi Tim and Albert, could you review this pull request? thank you :D
Comment on attachment 8373934 [details] [review] github PR: https://github.com/mozilla-b2g/gaia/pull/16166 It's much clear on what you do with https://github.com/mozilla-b2g/gaia/pull/16166/files?w=1 Please fix the nits on Github and make sure test passes before landing.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
I had to back this out because it is breaking make install-gaia. https://github.com/mozilla-b2g/gaia/commit/2e546129dd7860ee3e62b3f86ab222647dfcaae4
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Rik, thanks for backout it, I'm investigating it
Rik, I can't reproduce on my mac, could you checkout commit e6f7bfd0c2f1e302375951d3a612c117e94a054c and paste log to me? thanks!
Here is the output of make install-gaia: adb remount remount succeeded XULrunner directory: xulrunner-sdk-26/xulrunner-sdk run-js-command preferences Exception: TypeError: webapp is undefined execute/<@resource://gre/modules/commonjs/toolkit/loader.js -> file:///Users/rik24d/code/gaia/build/preferences.js:29 execute@resource://gre/modules/commonjs/toolkit/loader.js -> file:///Users/rik24d/code/gaia/build/preferences.js:28 @-e:1 make: *** [preferences] Error 3
okay I can reproduce it if create a directory with any name in apps/ and travis is green :-) https://travis-ci.org/mozilla-b2g/gaia/builds/18777866
previous I used Array.map() to get all webapp in |utils-xpc.js:makeWebappsObject()| but I should filter webapp if it doesn't exist. now using Array.forEach() and push webapp into apps if exists.
Attachment #8375410 - Flags: review?(timdream) → review+
Status: REOPENED → RESOLVED
Closed: 6 years ago → 6 years ago
Resolution: --- → FIXED
Component: Gaia → Gaia::Build
You need to log in before you can comment on or make changes to this bug.