968675 - Add Makefile for communications

Status: RESOLVED FIXED

Description

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

add a makefile for communications and migrate communications related code from applications-data.js, webapp-manifest.js and webapp-optimize.js.

we should build this app in build_stage because code snippet in webapp-manifest.js modify manifest.webapp of communications, or we will see some modification in git for each make

Comment 1

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

WIP here, https://github.com/yurenju/gaia/commit/308a51fdf78840e2c576c67ab14f03c358d3b43f

still need integration tests and addressing some nits.

Comment 2

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Created attachment 8373934 [details] [review]
github PR: https://github.com/mozilla-b2g/gaia/pull/16166

Hi Tim and Albert, could you review this pull request? thank you :D

Comment 3

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8373934 [details] [review]
github PR: https://github.com/mozilla-b2g/gaia/pull/16166

It's much clear on what you do with

https://github.com/mozilla-b2g/gaia/pull/16166/files?w=1

Please fix the nits on Github and make sure test passes before landing.

Comment 4

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

merged.

https://github.com/mozilla-b2g/gaia/commit/e6f7bfd0c2f1e302375951d3a612c117e94a054c

Comment 5

[Anthony Ricaud (:rik)]

I had to back this out because it is breaking make install-gaia.

https://github.com/mozilla-b2g/gaia/commit/2e546129dd7860ee3e62b3f86ab222647dfcaae4

Comment 6

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Rik, thanks for backout it, I'm investigating it

Comment 7

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Rik, I can't reproduce on my mac, could you checkout commit e6f7bfd0c2f1e302375951d3a612c117e94a054c and paste log to me? thanks!

Comment 8

[Anthony Ricaud (:rik)]

Here is the output of make install-gaia:

adb remount
remount succeeded
XULrunner directory: xulrunner-sdk-26/xulrunner-sdk
run-js-command  preferences
Exception: TypeError: webapp is undefined
execute/<@resource://gre/modules/commonjs/toolkit/loader.js -> file:///Users/rik24d/code/gaia/build/preferences.js:29
execute@resource://gre/modules/commonjs/toolkit/loader.js -> file:///Users/rik24d/code/gaia/build/preferences.js:28
@-e:1

make: *** [preferences] Error 3

Comment 9

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

okay I can reproduce it if create a directory with any name in apps/ and travis is green :-)

https://travis-ci.org/mozilla-b2g/gaia/builds/18777866

Comment 10

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Created attachment 8375410 [details] [review]
github PR: https://github.com/mozilla-b2g/gaia/pull/16235

previous I used Array.map() to get all webapp in |utils-xpc.js:makeWebappsObject()| but I should filter webapp if it doesn't exist.

now using Array.forEach() and push webapp into apps if exists.

Comment 11

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Merged again.

https://github.com/mozilla-b2g/gaia/commit/0c44f595055203484d1e8a293d9724ab609f213f