968677 - [settings] add marionette test for Messaging Settings panel

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[[e-mail]]

Overview Description:

Add marionette test for Messaging Settings panel


Steps to Reproduce:
1) run make test-perf APP=settings
2) run make test-integration APP=settings


Actual Results:

No such integration test for Messaging Settings panel


Expected Results:

Write that integration test and make test pass

Comment 1

[[e-mail]]

Reproducibility:

100%

Additional Information:

Please refer to bug 956210 for more information.

Comment 2

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Took this bug.

Comment 3

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Attachment: patch on master

Comment 4

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Comment on attachment 8438909 [details] [review]
patch on master

Hi Evan,

I just added the marionette test for message panel and they will be only run on real devices. 

Can you help me review them ? thanks :)

Comment 5

[Evan Tseng [:evanxd]]

Hi EJ,
I added comments for the PR.

Comment 6

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

@Evan I put some comments on the PR to respond your questions, can you check them ? 

Thanks !! (Please ni? me again after reading, thanks!)

Comment 7

[Evan Tseng [:evanxd]]

Hi EJ,

I add comments in the PR. And please make sure the test work well on the device. Thanks.b

Comment 8

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Evan, I just updated the patch, can you help me take a look again !?

Thanks for your reviewing :)

Comment 9

[Evan Tseng [:evanxd]]

Hi EJ,

Please remove the useless method.

Thanks.

Comment 10

[Evan Tseng [:evanxd]]

Comment on attachment 8438909 [details] [review]
patch on master

And I have a nit[1] for the patch. Then the patch looks good to me.

[1] https://github.com/mozilla-b2g/gaia/pull/20404/files#diff-53b9917eccadbda2e8703e017a078fcaR20

Comment 11

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Ok just removed them ! Thanks Evan :]

Comment 12

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Thanks all !

Just merged this into Gaia/master : d0c2cfb7e5b4fa4ef4d9db22d2daa7cfe7e4b05a