Overview Description: Add marionette test for Messaging Settings panel Steps to Reproduce: 1) run make test-perf APP=settings 2) run make test-integration APP=settings Actual Results: No such integration test for Messaging Settings panel Expected Results: Write that integration test and make test pass
Reproducibility: 100% Additional Information: Please refer to bug 956210 for more information.
Took this bug.
Comment on attachment 8438909 [details] [review] patch on master Hi Evan, I just added the marionette test for message panel and they will be only run on real devices. Can you help me review them ? thanks :)
Hi EJ, I added comments for the PR.
@Evan I put some comments on the PR to respond your questions, can you check them ? Thanks !! (Please ni? me again after reading, thanks!)
Hi EJ, I add comments in the PR. And please make sure the test work well on the device. Thanks.b
Evan, I just updated the patch, can you help me take a look again !? Thanks for your reviewing :)
Hi EJ, Please remove the useless method. Thanks.
Comment on attachment 8438909 [details] [review] patch on master And I have a nit for the patch. Then the patch looks good to me.  https://github.com/mozilla-b2g/gaia/pull/20404/files#diff-53b9917eccadbda2e8703e017a078fcaR20
Ok just removed them ! Thanks Evan :]
Thanks all ! Just merged this into Gaia/master : d0c2cfb7e5b4fa4ef4d9db22d2daa7cfe7e4b05a