968679 - [settings] add marionette test for Sound panel

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[[e-mail]]

Overview Description:

Add marionette test for Sound panel


Steps to Reproduce:
1) run make test-perf APP=settings
2) run make test-integration APP=settings


Actual Results:

No such integration test for Sound panel


Expected Results:

Write that integration test and make test pass

Comment 1

[[e-mail]]

Reproducibility:

100%

Additional Information:

Please refer to bug 956210 for more information.

Comment 2

[[e-mail]]

https://github.com/mozilla-b2g/gaia/pull/16112 wait for travis 30x result

Comment 3

[[e-mail]]

remove the Audible touch tones select option test since it's come from fowardlock and not available in B2G desktop.

Comment 4

[[e-mail]]

Attachment: pull request redirect to github

tests fails in calendar day view but looks fine for sound test

Comment 5

[Evan Tseng [:evanxd]]

Test case: Change the "Vibrate" item.
>> Make sure the mozSettings value is correct.

Test case: Change the volume of the "Ringer & Notifications" item.
>> Make sure the mozSettings value is correct.

Test case: Change the volume of the "Alarm" item.
>> Make sure the mozSettings value is correct.

Test case: Change all of the "Other sounds" item.
>> Make sure the mozSettings value is correct.

If have any question, please discuss here.
Thanks. :)

Comment 6

[Evan Tseng [:evanxd]]

Comment on attachment 8374584 [details] [review]
pull request redirect to github

Hi Gasolin,

We could review the patch, after we do the test case spec.
Thanks. :)

Comment 7

[[e-mail]]

Comment on attachment 8374584 [details] [review]
pull request redirect to github

filled checkedbox check, need do the slider check before review

Comment 8

[[e-mail]]

added slider test by monitoring slider tap action, which should change the current setting state

Comment 9

[[e-mail]]

Comment on attachment 8374584 [details] [review]
pull request redirect to github

All green.

for marionette_js_stable_check it pass 20 times without error before timeout
https://api.travis-ci.org/jobs/19305299/log.txt?deansi=true

It's timeout for 50min because of there are too many test cases in sound panel.

Comment 10

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8374584 [details] [review]
pull request redirect to github

r=me with the comments addressed, thanks!

Comment 11

[[e-mail]]

merged to gaia-master https://github.com/mozilla-b2g/gaia/commit/e863025d0bcdd468011aa4604f25a0f720f99c7f
thanks!

Comment 12

[Evan Tseng [:evanxd]]

Comment on attachment 8374584 [details] [review]
pull request redirect to github

Thanks for Arthur's review.