968681 - [settings] add marionette test for Display panel

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[[e-mail]]

Overview Description:

Add marionette test for Display panel


Steps to Reproduce:
1) run make test-perf APP=settings
2) run make test-integration APP=settings


Actual Results:

No such integration test for Display panel


Expected Results:

Write that integration test and make test pass

Comment 1

[[e-mail]]

Reproducibility:

100%

Additional Information:

Please refer to bug 956210 for more information.

Comment 2

[Evan Tseng [:evanxd]]

Test case spec for the Display panel:

Test case: Change the "Lock orientation" item.
>> Make sure the mozSettings value is correct.

Test case: Change the "Wallpaper" item.
>> Make sure the mozSettings value is correct.
>> Make sure the Wallpaper on Settings App is changed.

Test case: Change the "Adjust automatically" item.
>> Make sure the mozSettings value is correct.
>> Make sure the bright bar is hidden or not.

Test case: Change the "Screen timeout" item.
>> Make sure the mozSettings value is correct.

If have any question, please discuss here.
Thanks. :)

Comment 3

[Arthur Chen [:arthurcc][inactive after 6/30]]

Attachment: link to https://github.com/mozilla-b2g/gaia/pull/16596

Evan, EJ, could you take a look at this patch? Thanks!

Comment 4

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Comment on attachment 8381184 [details]
link to https://github.com/mozilla-b2g/gaia/pull/16596

Hi Arthur,

I left some comments on Github, please check it later when you have time :)

(Bypassing reviewing process to Evan !)

Comment 5

[Evan Tseng [:evanxd]]

Comment on attachment 8381184 [details]
link to https://github.com/mozilla-b2g/gaia/pull/16596

Hi Arthur,

Just left comments for your patch.
Please check it out.
Set r? again once they are fixed.

Thanks. :)

Comment 6

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8381184 [details]
link to https://github.com/mozilla-b2g/gaia/pull/16596

Comments addressed. Would you mind take a look at it again? Thanks!

Comment 7

[Arthur Chen [:arthurcc][inactive after 6/30]]

Weird, travis seems not run the tests 30 times.

Comment 8

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

(In reply to Arthur Chen [:arthurcc] from comment #7)
> Weird, travis seems not run the tests 30 times.

https://github.com/mozilla-b2g/gaia/commit/70ebc9f5faa7047e97b4cac829d5d83093f29d85

Check b2g-gaia mailing list !

Comment 9

[Evan Tseng [:evanxd]]

Yes, so we need to add the travis script temporarily, if we would like to make sure the 30 time things.

Comment 10

[Arthur Chen [:arthurcc][inactive after 6/30]]

Evan, the test has already passed 30 times. https://travis-ci.org/mozilla-b2g/gaia/builds/19955099

Comment 11

[Evan Tseng [:evanxd]]

Comment on attachment 8381184 [details]
link to https://github.com/mozilla-b2g/gaia/pull/16596

Hi Arthur,

Nice job.
Please remove the marionette_js_stable_check actions before we land the patch.
Thanks. :)

Comment 12

[Arthur Chen [:arthurcc][inactive after 6/30]]

Thanks for reviewing, Evan!

master: 88cd69708b2d40f6ea8b06d9d14385ca91163476