[settings] add marionette test for Display panel

RESOLVED FIXED in 1.4 S2 (28feb)

Status

RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: gasolin, Assigned: arthurcc)

Tracking

unspecified
1.4 S2 (28feb)
ARM
Gonk (Firefox OS)
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [ft:system-platform])

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
Overview Description:

Add marionette test for Display panel


Steps to Reproduce:
1) run make test-perf APP=settings
2) run make test-integration APP=settings


Actual Results:

No such integration test for Display panel


Expected Results:

Write that integration test and make test pass
(Reporter)

Comment 1

5 years ago
Reproducibility:

100%

Additional Information:

Please refer to bug 956210 for more information.
Assignee: nobody → arthur.chen
(Reporter)

Updated

5 years ago
Blocks: 969265
No longer blocks: 956210
Target Milestone: --- → 1.4 S2 (28feb)

Comment 2

5 years ago
Test case spec for the Display panel:

Test case: Change the "Lock orientation" item.
>> Make sure the mozSettings value is correct.

Test case: Change the "Wallpaper" item.
>> Make sure the mozSettings value is correct.
>> Make sure the Wallpaper on Settings App is changed.

Test case: Change the "Adjust automatically" item.
>> Make sure the mozSettings value is correct.
>> Make sure the bright bar is hidden or not.

Test case: Change the "Screen timeout" item.
>> Make sure the mozSettings value is correct.

If have any question, please discuss here.
Thanks. :)
(Reporter)

Updated

5 years ago
Blocks: 973443

Updated

5 years ago
Whiteboard: [ft:system-platform]
Created attachment 8381184 [details]
link to https://github.com/mozilla-b2g/gaia/pull/16596

Evan, EJ, could you take a look at this patch? Thanks!
Attachment #8381184 - Flags: review?(evanxd)
Attachment #8381184 - Flags: feedback?(ejchen)
Comment on attachment 8381184 [details]
link to https://github.com/mozilla-b2g/gaia/pull/16596

Hi Arthur,

I left some comments on Github, please check it later when you have time :)

(Bypassing reviewing process to Evan !)
Attachment #8381184 - Flags: feedback?(ejchen) → feedback+

Comment 5

5 years ago
Comment on attachment 8381184 [details]
link to https://github.com/mozilla-b2g/gaia/pull/16596

Hi Arthur,

Just left comments for your patch.
Please check it out.
Set r? again once they are fixed.

Thanks. :)
Attachment #8381184 - Flags: review?(evanxd)
Comment on attachment 8381184 [details]
link to https://github.com/mozilla-b2g/gaia/pull/16596

Comments addressed. Would you mind take a look at it again? Thanks!
Attachment #8381184 - Flags: review?(evanxd)
Weird, travis seems not run the tests 30 times.
(In reply to Arthur Chen [:arthurcc] from comment #7)
> Weird, travis seems not run the tests 30 times.

https://github.com/mozilla-b2g/gaia/commit/70ebc9f5faa7047e97b4cac829d5d83093f29d85

Check b2g-gaia mailing list !

Comment 9

5 years ago
Yes, so we need to add the travis script temporarily, if we would like to make sure the 30 time things.
Evan, the test has already passed 30 times. https://travis-ci.org/mozilla-b2g/gaia/builds/19955099
Flags: needinfo?(evanxd)
Comment on attachment 8381184 [details]
link to https://github.com/mozilla-b2g/gaia/pull/16596

Hi Arthur,

Nice job.
Please remove the marionette_js_stable_check actions before we land the patch.
Thanks. :)
Attachment #8381184 - Flags: review?(evanxd) → review+
Flags: needinfo?(evanxd)
Thanks for reviewing, Evan!

master: 88cd69708b2d40f6ea8b06d9d14385ca91163476
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.