Closed Bug 968682 Opened 7 years ago Closed 7 years ago

[settings] add marionette test for Notifications panel

Categories

(Firefox OS Graveyard :: Gaia::Settings, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
1.4 S2 (28feb)

People

(Reporter: gasolin, Assigned: gasolin)

References

Details

(Whiteboard: [ft:system-platform])

Attachments

(1 file)

46 bytes, text/x-github-pull-request
arthurcc
: review+
evanxd
: review+
Details | Review
Overview Description:

Add marionette test for Notifications panel


Steps to Reproduce:
1) run make test-perf APP=settings
2) run make test-integration APP=settings


Actual Results:

No such integration test for Notifications panel


Expected Results:

Write that integration test and make test pass
Reproducibility:

100%

Additional Information:

Please refer to bug 956210 for more information.
Blocks: 969265
Assignee: nobody → gasolin
Test case spec for the Notifications panel:

Test case: Change the "Notifications" item.
>> Make sure the mozSettings value is correct.

If have any question, please discuss here.
Thanks. :)
wait for 30x test
Attachment #8375237 - Flags: review?(evanxd)
Attachment #8375237 - Flags: review?(arthur.chen)
Comment on attachment 8375237 [details] [review]
pull request redirect to github

Thanks for the patch. Please check my comment in github.
Attachment #8375237 - Flags: review?(arthur.chen)
Comment on attachment 8375237 [details] [review]
pull request redirect to github

Hi Gasolin,

Sorry for the late reply.

There is a new rule for review process of marionette test:

Please make sure the `marionette_js_stable_check` action of the patch is passed on Travis
(https://travis-ci.org/mozilla-b2g/gaia/jobs/18937817), then we could set r? for the patch.

Thanks.
Attachment #8375237 - Flags: review?(evanxd)
Comment on attachment 8375237 [details] [review]
pull request redirect to github

Passed new rule, please kindly review it again, thanks!
Attachment #8375237 - Flags: review?(evanxd)
Attachment #8375237 - Flags: review?(arthur.chen)
Whiteboard: [ft:system-platform]
Target Milestone: --- → 1.4 S2 (28feb)
Comment on attachment 8375237 [details] [review]
pull request redirect to github

r=me. Thanks!
Attachment #8375237 - Flags: review?(arthur.chen) → review+
Comment on attachment 8375237 [details] [review]
pull request redirect to github

Hi Gasolin,

Good job!
r+, just a little nit for code style.
Attachment #8375237 - Flags: review?(evanxd) → review+
updated and merged to gaia-master https://github.com/mozilla-b2g/gaia/commit/98b095fd4ea10ae180bf00925135be0a15b2c7b8

thanks!
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.