968682 - [settings] add marionette test for Notifications panel

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[[e-mail]]

Overview Description:

Add marionette test for Notifications panel


Steps to Reproduce:
1) run make test-perf APP=settings
2) run make test-integration APP=settings


Actual Results:

No such integration test for Notifications panel


Expected Results:

Write that integration test and make test pass

Comment 1

[[e-mail]]

Reproducibility:

100%

Additional Information:

Please refer to bug 956210 for more information.

Comment 2

[Evan Tseng [:evanxd]]

Test case spec for the Notifications panel:

Test case: Change the "Notifications" item.
>> Make sure the mozSettings value is correct.

If have any question, please discuss here.
Thanks. :)

Comment 3

[[e-mail]]

Attachment: pull request redirect to github

wait for 30x test

Comment 4

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8375237 [details] [review]
pull request redirect to github

Thanks for the patch. Please check my comment in github.

Comment 5

[Evan Tseng [:evanxd]]

Comment on attachment 8375237 [details] [review]
pull request redirect to github

Hi Gasolin,

Sorry for the late reply.

There is a new rule for review process of marionette test:

Please make sure the `marionette_js_stable_check` action of the patch is passed on Travis
(https://travis-ci.org/mozilla-b2g/gaia/jobs/18937817), then we could set r? for the patch.

Thanks.

Comment 6

[[e-mail]]

Comment on attachment 8375237 [details] [review]
pull request redirect to github

Passed new rule, please kindly review it again, thanks!

Comment 7

[[e-mail]]

https://travis-ci.org/mozilla-b2g/gaia/builds/19014016

Comment 8

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8375237 [details] [review]
pull request redirect to github

r=me. Thanks!

Comment 9

[Evan Tseng [:evanxd]]

Comment on attachment 8375237 [details] [review]
pull request redirect to github

Hi Gasolin,

Good job!
r+, just a little nit for code style.

Comment 10

[[e-mail]]

updated and merged to gaia-master https://github.com/mozilla-b2g/gaia/commit/98b095fd4ea10ae180bf00925135be0a15b2c7b8

thanks!