968692 - [settings] add marionette test for Screen lock panel

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[[e-mail]]

Overview Description:

Add marionette test for Screen lock panel


Steps to Reproduce:
1) run make test-perf APP=settings
2) run make test-integration APP=settings


Actual Results:

No such integration test for Date & Time panel


Expected Results:

Write that integration test and make test pass

Reproducibility:

100%

Additional Information:

Please refer to bug 956210 for more information.

There are some hidden field need SIM card inserted

Comment 1

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Attachment: patch on master

Comment 2

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Comment on attachment 8373135 [details] [review]
patch on master

Hi Arthur & Evan,

I just made 3 tests for screenLock. I think these 3 tests are required for screenLock and please help me review & feedback for this !

BTW, Related tests on Travis just got passed, oh yeah !
(https://travis-ci.org/mozilla-b2g/gaia/jobs/18561449#L2187)

Thanks :P

Comment 3

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

For Reference : https://travis-ci.org/mozilla-b2g/gaia/builds/18562457

Comment 4

[Evan Tseng [:evanxd]]

Test case spec for the Screen lock panel:

Test case: Change the "Lock screen" item.
>> Make sure the mozSettings value is correct.

Test case: Add a new password.
>> Make sure the mozSettings value(password) is correct.

Test case: Add a new password and change the "Require passcode".
>> Make sure the mozSettings value(password) is correct.

Test case: Add a new password and change the password.
>> Make sure the mozSettings value(password) is correct.

If have any question, please discuss here.
Thanks. :)

Comment 5

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8373135 [details] [review]
patch on master

Per Evan's comment, we need to add the following tests:

- Check require passcode settings
- Check whether the stored passcode is the same as the input one

And I would suggest to add another test, which is when the passcode lock is enabled, a passcode prompt will be pop when users try to disable the lock screen.

Comment 6

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Please Check 30 tests here : https://travis-ci.org/evanxd/gaia/builds/19008887

Comment 7

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Comment on attachment 8373135 [details] [review]
patch on master

Hi Arthur & Evan,

just passed 30 tests on Evan's repo on Github ! Please help me review again when you have time ! Thanks :)

Comment 8

[Evan Tseng [:evanxd]]

Comment on attachment 8373135 [details] [review]
patch on master

Hi EJ(小龍哥),

Sorry for the late reply.

There is a new rule for review process of marionette test:

Please make sure the `marionette_js_stable_check` action of the patch is passed on Travis
(https://travis-ci.org/mozilla-b2g/gaia/jobs/18937817), then you could set r? for your patch.

Thanks.

Comment 9

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Comment on attachment 8373135 [details] [review]
patch on master

Hi Evan, 

this just passed tests on Travis (https://travis-ci.org/mozilla-b2g/gaia/builds/19014025).

Please help me review this when you have time ! Thanks :)

Comment 10

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8373135 [details] [review]
patch on master

Thanks, EJ. For the lock screen test, we need to ensure the checkbox is still enabled when users type the incorrect passcode. This did failed once, so I would suggest to include this test.

Comment 11

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

(In reply to Arthur Chen [:arthurcc] from comment #10)
> Comment on attachment 8373135 [details] [review]
> patch on master
> 
> Thanks, EJ. For the lock screen test, we need to ensure the checkbox is
> still enabled when users type the incorrect passcode. This did failed once,
> so I would suggest to include this test.

I added one more commit to make sure when testing isXXXEnabled(), I will also check isXXXCheced().

Is this ok for you, Arthur ?

Comment 12

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8373135 [details] [review]
patch on master

r=me, thanks!

Comment 13

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Thanks all, just merged at gaia/master : 6003c319780f49871dbe91ce5af32f5fc8ec06d9

Comment 14

[Evan Tseng [:evanxd]]

Comment on attachment 8373135 [details] [review]
patch on master

Thanks for Arthur's review.