968693 - [settings] add marionette test for App permissions panel

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[[e-mail]]

Overview Description:

Add marionette test for App permissions panel


Steps to Reproduce:
1) run make test-perf APP=settings
2) run make test-integration APP=settings


Actual Results:

No such integration test for App permissions panel


Expected Results:

Write that integration test and make test pass

Reproducibility:

100%

Additional Information:

Please refer to bug 956210 for more information.

Comment 1

[(Inactive after June) George Duan [:gduan] [:喬智]]

Attachment: PR to bubble-tea

waiting for test

Comment 2

[(Inactive after June) George Duan [:gduan] [:喬智]]

Comment on attachment 8389540 [details] [review]
PR to bubble-tea

Hi Arthur,
I wrote a test for app permission and it already pass 30 tests.
Please kindly check it.

Comment 3

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8389540 [details] [review]
PR to bubble-tea

Sorry for the late review. Please check my comments, thanks!

Comment 4

[(Inactive after June) George Duan [:gduan] [:喬智]]

Attachment: PR to master

replace pr with this one.
waiting for travis.

Comment 5

[(Inactive after June) George Duan [:gduan] [:喬智]]

Comment on attachment 8394254 [details] [review]
PR to master

Hi Arthur,
I updated the patch and move to master. Please kindly check again, thanks.

Comment 6

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8394254 [details] [review]
PR to master

r=me, thank you!

Comment 7

[(Inactive after June) George Duan [:gduan] [:喬智]]

Thanks,
in master
https://github.com/mozilla-b2g/gaia/commit/af13f191f854512ad02ad7339429e2db3a630944