Closed Bug 968693 Opened 8 years ago Closed 8 years ago
[settings] add marionette test for App permissions panel
Overview Description: Add marionette test for App permissions panel Steps to Reproduce: 1) run make test-perf APP=settings 2) run make test-integration APP=settings Actual Results: No such integration test for App permissions panel Expected Results: Write that integration test and make test pass Reproducibility: 100% Additional Information: Please refer to bug 956210 for more information.
waiting for test
Comment on attachment 8389540 [details] [review] PR to bubble-tea Hi Arthur, I wrote a test for app permission and it already pass 30 tests. Please kindly check it.
Comment on attachment 8389540 [details] [review] PR to bubble-tea Sorry for the late review. Please check my comments, thanks!
replace pr with this one. waiting for travis.
Attachment #8389540 - Attachment is obsolete: true
Comment on attachment 8394254 [details] [review] PR to master Hi Arthur, I updated the patch and move to master. Please kindly check again, thanks.
Attachment #8394254 - Flags: review?(arthur.chen)
Comment on attachment 8394254 [details] [review] PR to master r=me, thank you!
Attachment #8394254 - Flags: review?(arthur.chen) → review+
Thanks, in master https://github.com/mozilla-b2g/gaia/commit/af13f191f854512ad02ad7339429e2db3a630944
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.