973454 - [settings] refactor App permissions panel with AMD pattern

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[[e-mail]]

Overview Description:

Refactor App permissions panel with AMD pattern referring to
https://github.com/crh0716/gaia/tree/settings2_iterative

to make it modularize and more easier to maintain

Steps to Reproduce:
1) run make test-perf APP=settings
2) run make test-integration APP=settings


Expected Results:

pass all settings test and act the same as original implementation

Additional Information:

Comment 1

[(Inactive after June) George Duan [:gduan] [:喬智]]

Attachment: PR to master

waiting for travis.

Comment 2

[(Inactive after June) George Duan [:gduan] [:喬智]]

Comment on attachment 8402541 [details] [review]
PR to master

Hi Arthur,
could you help me to review this patch?
Thanks.

Comment 3

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8402541 [details] [review]
PR to master

Great work, George! Please check my github comments, thanks!

Comment 4

[(Inactive after June) George Duan [:gduan] [:喬智]]

Comment on attachment 8402541 [details] [review]
PR to master

Hi Arthur,
patch is updated as you suggested. Please kindly check again, thanks!

Comment 5

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8402541 [details] [review]
PR to master

Thank you for working on this, George! Please check my comments in github.

Comment 6

[(Inactive after June) George Duan [:gduan] [:喬智]]

Comment on attachment 8402541 [details] [review]
PR to master

Hi Arthur,
thanks for your reviewing. I think all issues are already addressed. Thanks.
Please kindly check again.

Comment 7

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8402541 [details] [review]
PR to master

We are almost there. There are a few issue but should be easy to fix. Please check my comments, thanks!

Comment 8

[(Inactive after June) George Duan [:gduan] [:喬智]]

Comment on attachment 8402541 [details] [review]
PR to master

Hi Arthur,
thanks for your comments, I just addressed, plz kindly check again.

Comment 9

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8402541 [details] [review]
PR to master

r=me, thank you for the effort!

Comment 10

[(Inactive after June) George Duan [:gduan] [:喬智]]

Thanks Arthur,
merge to master
https://github.com/mozilla-b2g/gaia/commit/fab96691c62543b0277cbb28bef195f9a0bd7595

Comment 11

[Carsten Book [:Tomcat]]

sorry, had to revert this change because it might have caused https://tbpl.mozilla.org/php/getParsedLog.php?id=38308895&tree=B2g-Inbound

Comment 12

[(Inactive after June) George Duan [:gduan] [:喬智]]

Attachment: PR to master 2

Previous pr has passed travis test.
It seems that tbpl has different gaia-ui test.
I'll put to try server later.

Comment 13

[Zac C (:zac)]

George, on TBPL the size of the font is different, sometimes makes the buttons different sized. Marionette may not be tapping on the menu option correctly.

Comment 14

[(Inactive after June) George Duan [:gduan] [:喬智]]

tbpl try-server: 
https://tbpl.mozilla.org/?tree=Try&rev=2d0830cc7328

Comment 15

[(Inactive after June) George Duan [:gduan] [:喬智]]

merge to master again,
https://github.com/mozilla-b2g/gaia/pull/18565

Comment 16

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Sorry George, 

I have to revert your patch because yours got overlapped with mine (got backedout with one test failure).

Commit: 972ea2e91ed2938fc1a35672cc9047c0e51d4364

Comment 17

[(Inactive after June) George Duan [:gduan] [:喬智]]

Attachment: PR to master 3

PR again.

Comment 18

[(Inactive after June) George Duan [:gduan] [:喬智]]

Merge to master,
https://github.com/mozilla-b2g/gaia/commit/cadddcac2b8ce162a5e27e6dc105557b00a94478