Closed
Bug 968856
Opened 12 years ago
Closed 12 years ago
Move unconditional LOCAL_INCLUDES into moz.build
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla30
People
(Reporter: Ms2ger, Assigned: Ms2ger)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
|
51.77 KB,
patch
|
mshal
:
review+
|
Details | Diff | Splinter Review |
|
5.50 KB,
patch
|
mshal
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•12 years ago
|
||
Drops us from 81 to 46.
Attachment #8371550 -
Flags: review?(mshal)
|
|
Assignee | |
Comment 2•12 years ago
|
||
Attachment #8371551 -
Flags: review?(mshal)
|
||
Comment 3•12 years ago
|
||
Comment on attachment 8371550 [details] [diff] [review]
Part 1: automatic moves
>diff --git a/modules/libmar/sign/moz.build b/modules/libmar/sign/moz.build
>--- a/modules/libmar/sign/moz.build
>+++ b/modules/libmar/sign/moz.build
>@@ -7,8 +7,15 @@
> LIBRARY_NAME = 'signmar'
>
> UNIFIED_SOURCES += [
> 'mar_sign.c',
> 'nss_secutil.c',
> ]
>
> FORCE_STATIC_LIB = True
>+
>+LOCAL_INCLUDES += [
>+ '../src',
>+ '../verify',
>+ '/dist/include',
>+]
/dist/include can go away since we get it from config/config.mk, right?
Attachment #8371550 -
Flags: review?(mshal) → review+
|
|
||
Updated•12 years ago
|
Attachment #8371551 -
Flags: review?(mshal) → review+
|
|
Assignee | |
Comment 4•12 years ago
|
||
Flags: in-testsuite-
|
||
Comment 5•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
|
||
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•