Closed Bug 968856 Opened 6 years ago Closed 6 years ago

Move unconditional LOCAL_INCLUDES into moz.build

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla30

People

(Reporter: Ms2ger, Assigned: Ms2ger)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

No description provided.
Drops us from 81 to 46.
Attachment #8371550 - Flags: review?(mshal)
Attached patch Part 2: fixupsSplinter Review
Attachment #8371551 - Flags: review?(mshal)
Comment on attachment 8371550 [details] [diff] [review]
Part 1: automatic moves

>diff --git a/modules/libmar/sign/moz.build b/modules/libmar/sign/moz.build
>--- a/modules/libmar/sign/moz.build
>+++ b/modules/libmar/sign/moz.build
>@@ -7,8 +7,15 @@
> LIBRARY_NAME = 'signmar'
> 
> UNIFIED_SOURCES += [
>     'mar_sign.c',
>     'nss_secutil.c',
> ]
> 
> FORCE_STATIC_LIB = True
>+
>+LOCAL_INCLUDES += [
>+    '../src',
>+    '../verify',
>+    '/dist/include',
>+]

/dist/include can go away since we get it from config/config.mk, right?
Attachment #8371550 - Flags: review?(mshal) → review+
Attachment #8371551 - Flags: review?(mshal) → review+
https://hg.mozilla.org/mozilla-central/rev/20d7a9037429
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.